Skip to content

fix: runtime module should get executed first always#3978

Merged
hyf0 merged 1 commit intomainfrom
03-28-fix_runtime_module_should_get_executed_first_always
Apr 6, 2025
Merged

fix: runtime module should get executed first always#3978
hyf0 merged 1 commit intomainfrom
03-28-fix_runtime_module_should_get_executed_first_always

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Mar 28, 2025 •
edited
Loading

Description

Fixes #3650.

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Mar 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 28, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 0b6ea42
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67f0e45facbfea000895c13c
😎 Deploy Preview https://deploy-preview-3978--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hyf0 hyf0 force-pushed the 03-28-fix_runtime_module_should_get_executed_first_always branch from b1ceca8 to c5cd23b Compare March 28, 2025 10:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(01772db)
  • pr: 03-28-fix_runtime_module_should_get_executed_first_always(0b6ea42)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     72.1±2.05ms        ? ?/sec    1.03     74.0±3.15ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     93.5±0.83ms        ? ?/sec    1.02     95.1±1.10ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    106.9±1.37ms        ? ?/sec    1.01    108.4±1.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     81.4±0.82ms        ? ?/sec    1.02     82.8±1.04ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    120.4±1.07ms        ? ?/sec    1.02    122.3±1.22ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    197.9±2.44ms        ? ?/sec    1.01    200.3±1.96ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.02    240.1±3.39ms        ? ?/sec    1.00    234.9±2.44ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    133.2±1.22ms        ? ?/sec    1.02    136.2±1.43ms        ? ?/sec
bundle/bundle@threejs                                               1.00     41.5±0.70ms        ? ?/sec    1.00     41.5±1.24ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     87.5±2.62ms        ? ?/sec    1.00     86.8±0.68ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    101.8±0.80ms        ? ?/sec    1.00    102.1±0.91ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.3±0.47ms        ? ?/sec    1.00     48.4±0.56ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    426.5±3.43ms        ? ?/sec    1.00    428.1±4.51ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1069.8±7.00ms        ? ?/sec    1.01   1082.4±6.28ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1245.8±7.14ms        ? ?/sec    1.01  1261.5±10.74ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    498.0±3.09ms        ? ?/sec    1.01    501.0±3.00ms        ? ?/sec
remapping/remapping                                                 1.00     25.9±0.90ms        ? ?/sec    1.01     26.2±0.92ms        ? ?/sec
remapping/render-chunk-remapping                                    1.05     68.8±4.81ms        ? ?/sec    1.00     65.6±4.63ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     96.4±1.10ms        ? ?/sec    1.02     98.4±1.39ms        ? ?/sec
scan/scan@threejs                                                   1.00     32.0±1.11ms        ? ?/sec    1.00     31.9±0.99ms        ? ?/sec
scan/scan@threejs10x                                                1.00    320.1±3.69ms        ? ?/sec    1.01    322.1±5.60ms        ? ?/sec

@hyf0 hyf0 force-pushed the 03-28-fix_runtime_module_should_get_executed_first_always branch 2 times, most recently from 7e8527f to 4b9ffd5 Compare April 5, 2025 07:57
@hyf0 hyf0 marked this pull request as ready for review April 5, 2025 07:57
@hyf0 hyf0 requested review from IWANABETHATGUY and Copilot April 5, 2025 07:58
Copilot AI reviewed Apr 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 27 changed files in this pull request and generated no comments.

Files not reviewed (17)
  • crates/rolldown/tests/rolldown/function/advanced_chunks/basic/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/issue_2617/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/max_module_size/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/max_module_size_fallback/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/max_size/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/max_size2/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/max_size3/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/min_module_size/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/min_module_size_fallback/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/min_share_count/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/min_share_count_fallback/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/min_size/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/min_size_fallback/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/function/advanced_chunks/split_node_modules/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/issues/3437/artifacts.snap: Language not supported
  • crates/rolldown/tests/rolldown/issues/3650/_config.json: Language not supported
  • crates/rolldown/tests/rolldown/issues/3650/artifacts.snap: Language not supported
Comments suppressed due to low confidence (2)

crates/rolldown/src/stages/generate_stage/advanced_chunks.rs:150

  • The use of the 'let-else' syntax may require a specific Rust version or feature flag; verify that this pattern is supported across all targeted build environments.
else {

crates/rolldown/tests/rolldown/issues/3650/first.js:1

  • [nitpick] The alias 'v' for the value may be too terse for clarity in tests; consider using a more descriptive alias to improve readability.
import { value as v } from './second.js'

@hyf0 hyf0 force-pushed the 03-28-fix_runtime_module_should_get_executed_first_always branch 2 times, most recently from cc144ba to e294c87 Compare April 5, 2025 08:00
@hyf0 hyf0 force-pushed the 03-28-fix_runtime_module_should_get_executed_first_always branch from e294c87 to 0b6ea42 Compare April 5, 2025 08:05
IWANABETHATGUY
IWANABETHATGUY reviewed Apr 6, 2025
View reviewed changes
@hyf0 hyf0 added this pull request to the merge queue Apr 6, 2025
Merged via the queue into main with commit 1c679ee Apr 6, 2025
27 checks passed
@hyf0 hyf0 deleted the 03-28-fix_runtime_module_should_get_executed_first_always branch April 6, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Circular deps caused by advancedChunks would throw error of referenced value is undefined

3 participants

@hyf0 @IWANABETHATGUY