Skip to content

Comments

fix(rolldown_utils): normalize ids before filtering#3955

Merged
sapphi-red merged 1 commit intomainfrom
03-25-fix_rolldown_utils_normalize_ids_before_filtering
Mar 25, 2025
Merged

fix(rolldown_utils): normalize ids before filtering#3955
sapphi-red merged 1 commit intomainfrom
03-25-fix_rolldown_utils_normalize_ids_before_filtering

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 25, 2025 •
edited
Loading

Description

Normalize \ to / before running the hook filter for ids so that plugins don't have to write foo[/\]bar.

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Mar 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Mar 25, 2025
Merged
@sapphi-red sapphi-red marked this pull request as ready for review March 25, 2025 04:21
@sapphi-red sapphi-red force-pushed the 03-25-fix_rolldown_utils_normalize_ids_before_filtering branch from 833e468 to 9b7da51 Compare March 25, 2025 04:22
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(57b0d44)
  • pr: 03-25-fix_rolldown_utils_normalize_ids_before_filtering(602f8d8)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     68.6±0.78ms        ? ?/sec    1.00     68.2±0.70ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     92.1±1.50ms        ? ?/sec    1.00     90.9±2.22ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.01    104.4±0.73ms        ? ?/sec    1.00    103.2±1.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     78.8±0.81ms        ? ?/sec    1.00     78.4±1.07ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    120.1±1.40ms        ? ?/sec    1.00    119.7±1.89ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    195.2±2.51ms        ? ?/sec    1.00    194.3±1.20ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    235.3±1.85ms        ? ?/sec    1.00    235.0±1.64ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    131.9±1.76ms        ? ?/sec    1.00    132.3±1.72ms        ? ?/sec
bundle/bundle@threejs                                               1.01     40.9±2.03ms        ? ?/sec    1.00     40.4±0.28ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     84.6±0.42ms        ? ?/sec    1.02     86.0±0.37ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     99.7±0.48ms        ? ?/sec    1.01    100.8±0.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.3±0.57ms        ? ?/sec    1.00     47.3±0.35ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    427.4±2.99ms        ? ?/sec    1.00    428.3±3.52ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1058.6±6.54ms        ? ?/sec    1.01   1072.6±5.29ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1236.4±5.44ms        ? ?/sec    1.01   1246.2±5.57ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    495.3±3.01ms        ? ?/sec    1.00    495.9±3.34ms        ? ?/sec
remapping/remapping                                                 1.06     27.4±0.41ms        ? ?/sec    1.00     26.0±0.87ms        ? ?/sec
remapping/render-chunk-remapping                                    1.04     69.4±4.09ms        ? ?/sec    1.00     66.5±5.11ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     93.9±1.60ms        ? ?/sec    1.03     96.7±1.15ms        ? ?/sec
scan/scan@threejs                                                   1.01     31.5±1.39ms        ? ?/sec    1.00     31.2±0.35ms        ? ?/sec
scan/scan@threejs10x                                                1.00   320.0±12.38ms        ? ?/sec    1.00    319.2±6.44ms        ? ?/sec

Base automatically changed from 03-25-test_hook_filter_tests to main March 25, 2025 05:57
@sapphi-red sapphi-red force-pushed the 03-25-fix_rolldown_utils_normalize_ids_before_filtering branch from 9b7da51 to 602f8d8 Compare March 25, 2025 05:58
@netlify
Copy link

netlify bot commented Mar 25, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 602f8d8
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67e245ed4712a0000889a05b

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 25, 2025

Merge activity

  • Mar 25, 1:58 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@sapphi-red sapphi-red added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit dc245f0 Mar 25, 2025
27 checks passed
@sapphi-red sapphi-red deleted the 03-25-fix_rolldown_utils_normalize_ids_before_filtering branch March 25, 2025 06:29
@sapphi-red sapphi-red mentioned this pull request May 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @IWANABETHATGUY