Skip to content

Comments

test: hook filter tests#3954

Merged
sapphi-red merged 1 commit intomainfrom
03-25-test_hook_filter_tests
Mar 25, 2025
Merged

test: hook filter tests#3954
sapphi-red merged 1 commit intomainfrom
03-25-test_hook_filter_tests

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 25, 2025 •
edited
Loading

Description

Ported tests from vitejs/vite#19602 to ensure the behavior is consistent.

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Mar 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Mar 25, 2025
Merged
@netlify
Copy link

netlify bot commented Mar 25, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 556e2c7
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67e22ed98f329d0008b66076

@sapphi-red sapphi-red marked this pull request as ready for review March 25, 2025 04:20
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     76.6±1.26ms        ? ?/sec    1.01     77.2±1.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.02    100.0±1.69ms        ? ?/sec    1.00     98.0±1.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    107.9±1.54ms        ? ?/sec    1.03    110.9±1.27ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     86.1±2.62ms        ? ?/sec    1.00     84.2±1.12ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    123.6±1.97ms        ? ?/sec    1.01    125.0±1.95ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    220.1±6.79ms        ? ?/sec    1.00    219.6±4.31ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    258.2±6.66ms        ? ?/sec    1.00    257.4±3.99ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    136.1±1.69ms        ? ?/sec    1.01    138.0±1.52ms        ? ?/sec
bundle/bundle@threejs                                               1.01     43.7±0.77ms        ? ?/sec    1.00     43.3±2.45ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     88.7±0.75ms        ? ?/sec    1.00     88.4±0.78ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    104.1±0.92ms        ? ?/sec    1.00    103.8±0.79ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     49.0±0.80ms        ? ?/sec    1.00     48.5±0.27ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    432.5±3.91ms        ? ?/sec    1.01    435.1±7.89ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1081.8±7.74ms        ? ?/sec    1.00   1085.8±6.52ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1265.4±7.28ms        ? ?/sec    1.00  1265.0±11.21ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    509.7±8.99ms        ? ?/sec    1.00    503.5±3.91ms        ? ?/sec
remapping/remapping                                                 1.00     26.4±0.76ms        ? ?/sec    1.02     26.9±0.14ms        ? ?/sec
remapping/render-chunk-remapping                                    1.10     69.8±4.64ms        ? ?/sec    1.00     63.5±0.35ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     97.7±1.60ms        ? ?/sec    1.04    101.5±1.88ms        ? ?/sec
scan/scan@threejs                                                   1.00     32.5±1.00ms        ? ?/sec    1.02     33.1±1.43ms        ? ?/sec
scan/scan@threejs10x                                                1.00    323.4±4.35ms        ? ?/sec    1.02    328.4±3.61ms        ? ?/sec

@sapphi-red sapphi-red added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 57b0d44 Mar 25, 2025
32 checks passed
@sapphi-red sapphi-red deleted the 03-25-test_hook_filter_tests branch March 25, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @IWANABETHATGUY @hyf0