refactor(ts): clean up methods of RolldownBuild#388
Merged
Conversation
This was referenced Nov 24, 2023
Merged
Member
Author
hyfdev
force-pushed
the
11-24-refactor_ts_cleanup_methods_of_RolldownBuild_
branch
from
November 24, 2023 14:41
f777b87 to
f1352f2
Compare
RolldownBuildRolldownBuild
hyfdev
force-pushed
the
11-24-refactor_ts_cleanup_methods_of_RolldownBuild_
branch
from
November 24, 2023 14:50
f1352f2 to
2736bd1
Compare
underfin
approved these changes
Nov 25, 2023
Member
Merge activity
|
hyfdev
force-pushed
the
11-23-feat_exclude_modules_in_code_splitting
branch
from
November 27, 2023 05:15
8a6d333 to
c696891
Compare
hyfdev
force-pushed
the
11-24-refactor_ts_cleanup_methods_of_RolldownBuild_
branch
from
November 27, 2023 05:15
2736bd1 to
34b150d
Compare
hyfdev
force-pushed
the
11-23-feat_exclude_modules_in_code_splitting
branch
from
December 4, 2023 02:09
c696891 to
14727d7
Compare
hyfdev
force-pushed
the
11-24-refactor_ts_cleanup_methods_of_RolldownBuild_
branch
from
December 4, 2023 02:09
34b150d to
f518007
Compare
hyfdev
force-pushed
the
11-23-feat_exclude_modules_in_code_splitting
branch
from
December 4, 2023 02:17
14727d7 to
4219dcb
Compare
Base automatically changed from
11-23-feat_exclude_modules_in_code_splitting
to
main
December 4, 2023 02:18
hyfdev
force-pushed
the
11-24-refactor_ts_cleanup_methods_of_RolldownBuild_
branch
from
December 4, 2023 02:18
f518007 to
e310570
Compare
hyfdev
deleted the
11-24-refactor_ts_cleanup_methods_of_RolldownBuild_
branch
December 4, 2023 02:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Should not expose those methods to userland. This rule also includes the constuctor method. So
RolldownBuildwill be aninterfacerather than aclassin the future.Test Plan