Skip to content

refactor(ts): clean up methods of RolldownBuild#388

Merged
hyfdev merged 1 commit into
mainfrom
11-24-refactor_ts_cleanup_methods_of_RolldownBuild_
Dec 4, 2023
Merged

refactor(ts): clean up methods of RolldownBuild#388
hyfdev merged 1 commit into
mainfrom
11-24-refactor_ts_cleanup_methods_of_RolldownBuild_

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 24, 2023

Copy link
Copy Markdown
Member

Description

Should not expose those methods to userland. This rule also includes the constuctor method. So RolldownBuild will be an interface rather than a class in the future.

Test Plan


@hyfdev
hyfdev force-pushed the 11-24-refactor_ts_cleanup_methods_of_RolldownBuild_ branch from f777b87 to f1352f2 Compare November 24, 2023 14:41
@hyfdev hyfdev changed the title refactor(ts): cleanup methods of RolldownBuild refactor(ts): clean up methods of RolldownBuild Nov 24, 2023
@hyfdev
hyfdev force-pushed the 11-24-refactor_ts_cleanup_methods_of_RolldownBuild_ branch from f1352f2 to 2736bd1 Compare November 24, 2023 14:50

Boshen commented Nov 27, 2023

Copy link
Copy Markdown
Member

Merge activity

@hyfdev
hyfdev force-pushed the 11-23-feat_exclude_modules_in_code_splitting branch from 8a6d333 to c696891 Compare November 27, 2023 05:15
@hyfdev
hyfdev force-pushed the 11-24-refactor_ts_cleanup_methods_of_RolldownBuild_ branch from 2736bd1 to 34b150d Compare November 27, 2023 05:15
@hyfdev
hyfdev force-pushed the 11-23-feat_exclude_modules_in_code_splitting branch from c696891 to 14727d7 Compare December 4, 2023 02:09
@hyfdev
hyfdev force-pushed the 11-24-refactor_ts_cleanup_methods_of_RolldownBuild_ branch from 34b150d to f518007 Compare December 4, 2023 02:09
@hyfdev
hyfdev force-pushed the 11-23-feat_exclude_modules_in_code_splitting branch from 14727d7 to 4219dcb Compare December 4, 2023 02:17
Base automatically changed from 11-23-feat_exclude_modules_in_code_splitting to main December 4, 2023 02:18
@hyfdev
hyfdev force-pushed the 11-24-refactor_ts_cleanup_methods_of_RolldownBuild_ branch from f518007 to e310570 Compare December 4, 2023 02:18
@hyfdev
hyfdev merged commit de6c324 into main Dec 4, 2023
@hyfdev
hyfdev deleted the 11-24-refactor_ts_cleanup_methods_of_RolldownBuild_ branch December 4, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants