feat: treeshaking in module level#382
Merged
Merged
Conversation
This was referenced Nov 23, 2023
Merged
Member
Author
This was referenced Nov 23, 2023
hyfdev
force-pushed
the
11-23-fix_more_meaningful_chunk_filename
branch
from
November 23, 2023 14:55
5b25629 to
52e7db7
Compare
hyfdev
force-pushed
the
11-23-feat_treeshaking_in_module_level
branch
from
November 23, 2023 14:55
937684f to
e03368e
Compare
underfin
approved these changes
Nov 24, 2023
Member
Merge activity
|
hyfdev
force-pushed
the
11-23-fix_more_meaningful_chunk_filename
branch
from
November 27, 2023 05:15
52e7db7 to
d9427fc
Compare
hyfdev
force-pushed
the
11-23-feat_treeshaking_in_module_level
branch
from
November 27, 2023 05:15
e03368e to
a1621a7
Compare
milesj
reviewed
Nov 27, 2023
| modules: &'a ModuleVec, | ||
| symbols: &'a Symbols, | ||
| is_included_vec: &'a mut IndexVec<ModuleId, IndexVec<StmtInfoId, bool>>, | ||
| is_module_included_vec: &'a mut IndexVec<ModuleId, bool>, |
Contributor
There was a problem hiding this comment.
Curious, is IndexVec faster than a simple HashSet?
hyfdev
force-pushed
the
11-23-fix_more_meaningful_chunk_filename
branch
from
December 4, 2023 02:09
d9427fc to
8710382
Compare
hyfdev
force-pushed
the
11-23-feat_treeshaking_in_module_level
branch
from
December 4, 2023 02:09
a1621a7 to
353e012
Compare
hyfdev
force-pushed
the
11-23-fix_more_meaningful_chunk_filename
branch
from
December 4, 2023 02:15
8710382 to
950dea1
Compare
Base automatically changed from
11-23-fix_more_meaningful_chunk_filename
to
main
December 4, 2023 02:16
hyfdev
force-pushed
the
11-23-feat_treeshaking_in_module_level
branch
from
December 4, 2023 02:16
353e012 to
970d53d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Plan