Skip to content

feat(hmr): detects defult export and shims import.meta.hot#3795

Merged
hyfdev merged 1 commit into
mainfrom
03-09-feat_hmr_detects_defult_export_and_shims_import.meta.hot_
Mar 9, 2025
Merged

feat(hmr): detects defult export and shims import.meta.hot#3795
hyfdev merged 1 commit into
mainfrom
03-09-feat_hmr_detects_defult_export_and_shims_import.meta.hot_

Conversation

@hyfdev

@hyfdev hyfdev commented Mar 9, 2025

Copy link
Copy Markdown
Member

Description

@hyfdev
hyfdev marked this pull request as ready for review March 9, 2025 11:42
This was referenced Mar 9, 2025
Merged
Merged
@hyfdev Graphite App

hyfdev commented Mar 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 9, 2025
Merged
Merged
@hyfdev
hyfdev changed the base branch from 03-09-chore_examples_rename_react-hmr_to_hmr-raw_ to graphite-base/3795 March 9, 2025 11:46
@hyfdev
hyfdev force-pushed the graphite-base/3795 branch from f8127f2 to e280673 Compare March 9, 2025 11:47
@hyfdev
hyfdev force-pushed the 03-09-feat_hmr_detects_defult_export_and_shims_import.meta.hot_ branch from d83479e to 9d4aa9f Compare March 9, 2025 11:47
@hyfdev
hyfdev changed the base branch from graphite-base/3795 to 03-09-chore_examples_rename_react-hmr_to_hmr-raw_ March 9, 2025 11:47
@hyfdev
hyfdev force-pushed the 03-09-chore_examples_rename_react-hmr_to_hmr-raw_ branch from e280673 to c7fd963 Compare March 9, 2025 12:11
@hyfdev
hyfdev force-pushed the 03-09-feat_hmr_detects_defult_export_and_shims_import.meta.hot_ branch from 9d4aa9f to b3abca1 Compare March 9, 2025 12:11
@github-actions

github-actions Bot commented Mar 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: 03-09-chore_examples_rename_react-hmr_to_hmr-raw_(c7fd963)
  • pr: 03-09-feat_hmr_detects_defult_export_and_shims_import.meta.hot_(fb70a00)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     71.0±0.79ms        ? ?/sec    1.00     71.3±1.00ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     93.8±1.10ms        ? ?/sec    1.01     94.8±2.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    109.5±4.54ms        ? ?/sec    1.00    109.1±1.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     81.2±1.11ms        ? ?/sec    1.04     84.4±2.84ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    122.4±1.36ms        ? ?/sec    1.03    125.5±3.11ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.05    210.4±6.99ms        ? ?/sec    1.00    201.1±2.32ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.03    243.5±5.79ms        ? ?/sec    1.00    236.3±2.61ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    135.7±1.67ms        ? ?/sec    1.00    136.0±1.57ms        ? ?/sec
bundle/bundle@threejs                                               1.00     40.8±0.79ms        ? ?/sec    1.00     40.9±1.57ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     86.8±2.65ms        ? ?/sec    1.00     86.0±0.94ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.06    106.7±3.54ms        ? ?/sec    1.00    100.8±0.82ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.6±0.65ms        ? ?/sec    1.01     47.9±1.01ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    435.7±5.76ms        ? ?/sec    1.01    439.8±5.31ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1094.8±8.66ms        ? ?/sec    1.01   1100.9±8.52ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1285.0±18.99ms        ? ?/sec    1.00   1286.4±5.51ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    510.9±4.12ms        ? ?/sec    1.00    504.5±2.89ms        ? ?/sec
remapping/remapping                                                 1.00     25.5±0.24ms        ? ?/sec    1.05     26.7±1.02ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     65.8±2.47ms        ? ?/sec    1.08     70.8±4.71ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     94.6±1.49ms        ? ?/sec    1.01     95.8±1.85ms        ? ?/sec
scan/scan@threejs                                                   1.00     31.2±0.66ms        ? ?/sec    1.03     32.0±2.30ms        ? ?/sec
scan/scan@threejs10x                                                1.00    318.0±4.49ms        ? ?/sec    1.01    320.6±5.68ms        ? ?/sec

@hyfdev
hyfdev force-pushed the 03-09-feat_hmr_detects_defult_export_and_shims_import.meta.hot_ branch from b3abca1 to fb70a00 Compare March 9, 2025 12:30
@hyfdev
hyfdev force-pushed the 03-09-chore_examples_rename_react-hmr_to_hmr-raw_ branch from c7fd963 to 10820ed Compare March 9, 2025 12:30
@hyfdev
hyfdev changed the base branch from 03-09-chore_examples_rename_react-hmr_to_hmr-raw_ to graphite-base/3795 March 9, 2025 12:55
@hyfdev
hyfdev force-pushed the graphite-base/3795 branch from 10820ed to c7fd963 Compare March 9, 2025 12:55
IWANABETHATGUY
IWANABETHATGUY reviewed Mar 9, 2025
View reviewed changes
Comment thread crates/rolldown/src/runtime/runtime-extra-dev.js
@hyfdev
hyfdev force-pushed the graphite-base/3795 branch from c7fd963 to a24c3a5 Compare March 9, 2025 14:46
@hyfdev
hyfdev force-pushed the 03-09-feat_hmr_detects_defult_export_and_shims_import.meta.hot_ branch from fb70a00 to 9744710 Compare March 9, 2025 14:46
@hyfdev
hyfdev changed the base branch from graphite-base/3795 to main March 9, 2025 14:46
@hyfdev
hyfdev added this pull request to the merge queue Mar 9, 2025
Merged via the queue into main with commit 4a3ffed Mar 9, 2025
@hyfdev
hyfdev deleted the 03-09-feat_hmr_detects_defult_export_and_shims_import.meta.hot_ branch March 9, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyfdev @IWANABETHATGUY