Skip to content

feat(rust/hmr): improve runtime and generate runnable patch#3792

Merged
hyfdev merged 1 commit into
mainfrom
03-09-feat_rust_hmr_improve_runtime_and_generate_runnable_patch
Mar 9, 2025
Merged

feat(rust/hmr): improve runtime and generate runnable patch#3792
hyfdev merged 1 commit into
mainfrom
03-09-feat_rust_hmr_improve_runtime_and_generate_runnable_patch

Conversation

@hyfdev

@hyfdev hyfdev commented Mar 9, 2025

Copy link
Copy Markdown
Member

Description

@hyfdev
hyfdev marked this pull request as ready for review March 9, 2025 10:33
@hyfdev Graphite App

hyfdev commented Mar 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 9, 2025
Merged
Merged
@netlify

netlify Bot commented Mar 9, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 05663cd
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67cd702074eca5000801bb97

@hyfdev
hyfdev force-pushed the 03-09-feat_rust_hmr_improve_runtime_and_generate_runnable_patch branch from 191b135 to 05663cd Compare March 9, 2025 10:40
@hyfdev
hyfdev added this pull request to the merge queue Mar 9, 2025
@github-actions

github-actions Bot commented Mar 9, 2025

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(9b28db1)
  • pr: 03-09-feat_rust_hmr_improve_runtime_and_generate_runnable_patch(05663cd)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.07     76.1±2.83ms        ? ?/sec    1.00     71.4±3.15ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     95.3±1.60ms        ? ?/sec    1.00     95.5±1.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.02    106.7±1.49ms        ? ?/sec    1.00    104.1±1.06ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     80.5±0.94ms        ? ?/sec    1.00     80.6±0.74ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    119.9±1.37ms        ? ?/sec    1.01    121.2±0.92ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00   206.1±11.23ms        ? ?/sec    1.00    206.0±1.65ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    238.5±6.57ms        ? ?/sec    1.00    239.4±1.82ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    132.9±2.00ms        ? ?/sec    1.02    135.5±5.27ms        ? ?/sec
bundle/bundle@threejs                                               1.03     42.7±1.40ms        ? ?/sec    1.00     41.4±0.57ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.05     90.4±4.21ms        ? ?/sec    1.00     86.3±0.47ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.04    107.8±4.00ms        ? ?/sec    1.00    104.0±3.28ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     48.5±0.49ms        ? ?/sec    1.00     48.1±0.95ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    440.7±7.24ms        ? ?/sec    1.00    439.9±5.70ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1101.7±11.56ms        ? ?/sec    1.01   1110.3±6.23ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1260.8±7.19ms        ? ?/sec    1.01   1267.3±4.54ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    505.2±3.50ms        ? ?/sec    1.02    514.6±9.34ms        ? ?/sec
remapping/remapping                                                 1.00     26.1±0.73ms        ? ?/sec    1.03     26.8±0.88ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     64.4±0.33ms        ? ?/sec    1.00     64.2±0.26ms        ? ?/sec
scan/scan@rome-ts                                                   1.02     97.5±2.01ms        ? ?/sec    1.00     95.3±1.35ms        ? ?/sec
scan/scan@threejs                                                   1.00     31.4±0.98ms        ? ?/sec    1.03     32.5±2.58ms        ? ?/sec
scan/scan@threejs10x                                                1.00    317.2±3.99ms        ? ?/sec    1.01    318.9±2.65ms        ? ?/sec

Merged via the queue into main with commit 4511b29 Mar 9, 2025
@hyfdev
hyfdev deleted the 03-09-feat_rust_hmr_improve_runtime_and_generate_runnable_patch branch March 9, 2025 11:01
This was referenced Mar 9, 2025
Merged
Merged
@hyfdev hyfdev mentioned this pull request Jun 10, 2026
Merged
graphite-app Bot pushed a commit that referenced this pull request Jun 10, 2026
@hyfdev @claude
chore(hmr): delete commented-out dead code left from old register-mod…
a10acb7 
…ule codegen (#9707)

The block in generate_runtime_module_register_for_hmr was superseded by
HmrAstBuilder::create_register_module_stmt (called right above it) back
in #3792 and even references the since-deleted snippet field; the two
commented unreachable! lines were dead decision residue.

Co-Authored-By: Claude Fable 5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyfdev @IWANABETHATGUY