Skip to content

feat(rust): rendering runtime module in snapshot testing#375

Merged
underfin merged 3 commits into
mainfrom
11-23-feat_rust_rendering_runtime_module_in_snapshot_testing
Nov 28, 2023
Merged

feat(rust): rendering runtime module in snapshot testing#375
underfin merged 3 commits into
mainfrom
11-23-feat_rust_rendering_runtime_module_in_snapshot_testing

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 23, 2023

Copy link
Copy Markdown
Member

Description

Test Plan


@hyfdev
hyfdev force-pushed the 11-23-feat_rust_rendering_runtime_module_in_snapshot_testing branch from 5daaca2 to bf15a55 Compare November 23, 2023 08:44
@underfin

Copy link
Copy Markdown
Contributor

The runtime code is larger, it is difficult to review, maybe we can use another idea to exclude it. I see esbuild snapshot also hasn't runtime code.

@hyfdev

hyfdev commented Nov 23, 2023

Copy link
Copy Markdown
Member Author

The runtime code is larger, it is difficult to review, maybe we can use another idea to exclude it. I see esbuild snapshot also hasn't runtime code.

This tests the behaviors of treeshaking with runtime module. Feel free to open a team meeting to discuss this PR.

@underfin

Copy link
Copy Markdown
Contributor

Track here #390.

@underfin

underfin commented Nov 25, 2023

Copy link
Copy Markdown
Contributor

Other we need to add tree shaking option to enable the behaviors of treeshaking with module. You can do it at new pr.

Boshen commented Nov 27, 2023

Copy link
Copy Markdown
Member

Merge activity

  • Nov 26, 10:26 PM: @Boshen started a stack merge that includes this pull request via Graphite.
  • Nov 26, 10:38 PM: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

@Boshen
Boshen force-pushed the 11-23-feat_improve_side-effect_detection_of_MemberExpression_ branch from 76168f9 to 0e41b6a Compare November 27, 2023 03:34
Base automatically changed from 11-23-feat_improve_side-effect_detection_of_MemberExpression_ to main November 27, 2023 03:38
@hyfdev
hyfdev force-pushed the 11-23-feat_rust_rendering_runtime_module_in_snapshot_testing branch from 193fd16 to 424651e Compare November 27, 2023 05:15
@underfin
underfin merged commit 3cb39a2 into main Nov 28, 2023
@underfin
underfin deleted the 11-23-feat_rust_rendering_runtime_module_in_snapshot_testing branch November 28, 2023 15:38
graphite-app Bot pushed a commit that referenced this pull request Jul 15, 2026
### Description

`crates/rolldown/src/runtime/index.js` is not part of the build, and hasn''t been for a long time. This PR deletes it.

The runtime module is assembled in [`runtime_module_task.rs`](https://github.com/rolldown/rolldown/blob/main/crates/rolldown/src/module_loader/runtime_module_task.rs#L33-L36) from exactly four `include_str!`ed files:

```rust
const RUNTIME_BASE_JS: &str = include_str!("../runtime/runtime-base.js");
const RUNTIME_TAIL_JS: &str = include_str!("../runtime/runtime-tail.js");
const RUNTIME_HEAD_NODE_JS: &str = include_str!("../runtime/runtime-head-node.js");
const RUNTIME_TAIL_NODE_JS: &str = include_str!("../runtime/runtime-tail-node.js");
```

`index.js` is not among them. Nothing else in the repo references it either — there''s no `build.rs` in the crate, and no path reference to it in Rust, JS, or `knip.jsonc`. Its only remaining coverage is incidental: the sibling `tsconfig.json` globs `./**/*`, so it gets type-checked and formatted alongside the files that actually ship.

### How it got here

It''s the original esbuild runtime port from #37. #375 added `runtime-without-comments.js` as the copy actually fed to the bundler; that file was renamed to `runtime-base.js` in #2919 and later split with `runtime-tail.js`. `index.js` was never wired back up — it survived as a copy that edits were hand-mirrored into.

### Why delete rather than leave it

The mirroring has fallen behind, so the file now actively misinforms:

| | `runtime-base.js` (ships) | `index.js` (dead) |
|---|---|---|
| `cb = null` release in `__commonJS` (#9067) | present | **missing** |
| `__exportAll` + `Symbol.toStringTag` | present | still the old `__export` |
| `__require` error text | rewritten to link the rolldown docs (in `runtime-tail.js`) | still esbuild''s "Dynamic require of …" |

Someone grepping for a runtime helper can land here and draw the wrong conclusion about what ships — the missing #9067 fix reads as a live memory leak. It isn''t, because the file is inert. Deleting it removes the trap and the ongoing cost of keeping a second copy in sync.

### Test Plan

Deletion only; no shipped output changes, so no snapshots move. `include_str!` resolves at compile time, so a stale reference would break the build:

- `cargo check -p rolldown --all-targets` — passes
- `tsc --noEmit -p crates/rolldown/src/runtime/tsconfig.json` — passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants