Skip to content

feat: remove unused dynamic imported chunks#3588

Merged
IWANABETHATGUY merged 1 commit into
mainfrom
02-16-feat_remove_unused_dynamic_imported_chunks
Feb 16, 2025
Merged

feat: remove unused dynamic imported chunks#3588
IWANABETHATGUY merged 1 commit into
mainfrom
02-16-feat_remove_unused_dynamic_imported_chunks

Conversation

@IWANABETHATGUY

@IWANABETHATGUY IWANABETHATGUY commented Feb 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  1. Closed [feature]: Remove unused dynamic imported chunks/Rolldown outputs unused dynamic imported chunks #2604
  2. The basic idea is mark a dynamic chunk as dead if all related stmt info are not included in the final bundle.

@IWANABETHATGUY
IWANABETHATGUY marked this pull request as ready for review February 15, 2025 17:04
@IWANABETHATGUY Graphite App

IWANABETHATGUY commented Feb 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify

netlify Bot commented Feb 15, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit f1e3c19
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67b0cc0382261b0008f7f51c
😎 Deploy Preview https://deploy-preview-3588--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IWANABETHATGUY
IWANABETHATGUY force-pushed the 02-16-feat_remove_unused_dynamic_imported_chunks branch 2 times, most recently from f3a5d29 to 3fdabbe Compare February 15, 2025 17:08
@IWANABETHATGUY IWANABETHATGUY changed the title feat: Remove unused dynamic imported chunks feat: remove unused dynamic imported chunks Feb 15, 2025
@IWANABETHATGUY
IWANABETHATGUY force-pushed the 02-16-feat_remove_unused_dynamic_imported_chunks branch from 3fdabbe to f1e3c19 Compare February 15, 2025 17:16
@github-actions

github-actions Bot commented Feb 15, 2025

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(de6e9d2)
  • pr: 02-16-feat_remove_unused_dynamic_imported_chunks(f1e3c19)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     75.1±1.08ms        ? ?/sec    1.00     74.2±0.93ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     94.4±1.00ms        ? ?/sec    1.00     94.6±1.16ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    107.0±1.51ms        ? ?/sec    1.00    107.0±1.36ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     83.8±1.91ms        ? ?/sec    1.00     82.9±1.17ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    122.6±1.06ms        ? ?/sec    1.02    124.7±1.70ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    210.2±2.32ms        ? ?/sec    1.00    210.2±1.98ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    244.7±3.61ms        ? ?/sec    1.01    246.7±5.26ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    135.9±1.30ms        ? ?/sec    1.01    137.1±1.19ms        ? ?/sec
bundle/bundle@threejs                                               1.00     40.8±0.36ms        ? ?/sec    1.03     41.9±1.31ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     93.5±2.18ms        ? ?/sec    1.02     95.0±0.71ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    111.6±2.19ms        ? ?/sec    1.01    113.2±1.25ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     51.0±0.49ms        ? ?/sec    1.03     52.4±0.58ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    433.1±7.76ms        ? ?/sec    1.01    438.9±4.93ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1077.0±6.91ms        ? ?/sec    1.01   1092.3±7.21ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1253.7±10.02ms        ? ?/sec    1.01  1261.0±14.19ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00   504.1±18.29ms        ? ?/sec    1.01    509.0±4.96ms        ? ?/sec
remapping/remapping                                                 1.06     26.8±0.63ms        ? ?/sec    1.00     25.3±2.34ms        ? ?/sec
remapping/render-chunk-remapping                                    1.11     71.1±5.58ms        ? ?/sec    1.00     64.2±0.45ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     95.7±1.00ms        ? ?/sec    1.00     95.4±0.99ms        ? ?/sec
scan/scan@threejs                                                   1.00     31.3±0.44ms        ? ?/sec    1.00     31.4±0.51ms        ? ?/sec
scan/scan@threejs10x                                                1.01    316.9±3.36ms        ? ?/sec    1.00    314.6±4.05ms        ? ?/sec

@IWANABETHATGUY
IWANABETHATGUY added this pull request to the merge queue Feb 16, 2025
Merged via the queue into main with commit a2fc0fc Feb 16, 2025
@IWANABETHATGUY
IWANABETHATGUY deleted the 02-16-feat_remove_unused_dynamic_imported_chunks branch February 16, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyfdev hyfdev hyfdev approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature]: Remove unused dynamic imported chunks/Rolldown outputs unused dynamic imported chunks

2 participants

@IWANABETHATGUY @hyfdev