fix(plugin/json): tree shake json named exports#3346
Merged
IWANABETHATGUY merged 1 commit intorolldown:mainfrom Jan 13, 2025
Merged
fix(plugin/json): tree shake json named exports#3346IWANABETHATGUY merged 1 commit intorolldown:mainfrom
IWANABETHATGUY merged 1 commit intorolldown:mainfrom
Conversation
hi-ogawa
changed the title
IWANABETHATGUY
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was once fixed in #2029, but #3103 added another
JSON.parsewithout pure comment.Someone noticed the same bug on Vite vitejs/vite#19189, so I ported to here.