Skip to content

Comments

fix: propagate augmented hash to parent chunks#3059

Merged
hyf0 merged 5 commits intorolldown:mainfrom
hi-ogawa:fix-propagate-augment_chunk_hash
Dec 6, 2024
Merged

fix: propagate augmented hash to parent chunks#3059
hyf0 merged 5 commits intorolldown:mainfrom
hi-ogawa:fix-propagate-augment_chunk_hash

Conversation

@hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Dec 6, 2024

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 694aac9
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6752637cf913060008d80b3a

@hi-ogawa hi-ogawa marked this pull request as ready for review December 6, 2024 01:04
@hyf0 hyf0 self-assigned this Dec 6, 2024
Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I switched to use IndexSet to ensure stable calculation.

@hyf0 hyf0 enabled auto-merge December 6, 2024 02:38
@hyf0 hyf0 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into rolldown:main with commit 5815d0f Dec 6, 2024
@hi-ogawa hi-ogawa deleted the fix-propagate-augment_chunk_hash branch December 6, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: augmentChunkHash doesn't affect parent chunk's hash

2 participants