Skip to content

refactor(rust): make SharedOptions always exist on AstScanner#2955

Merged
hyfdev merged 1 commit into
mainfrom
11-27-refactor_rust_make_sharedoptions_always_exist_on_astscanner_
Nov 27, 2024
Merged

refactor(rust): make SharedOptions always exist on AstScanner#2955
hyfdev merged 1 commit into
mainfrom
11-27-refactor_rust_make_sharedoptions_always_exist_on_astscanner_

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Just improve the dx of using options in AstScanner and reduce some is_some_and() calls.

@hyfdev hyfdev mentioned this pull request Nov 27, 2024
Merged
@hyfdev Graphite App

hyfdev commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyfdev
hyfdev marked this pull request as ready for review November 27, 2024 09:03
@github-actions

github-actions Bot commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(e126911)
  • pr: 11-27-refactor_rust_make_sharedoptions_always_exist_on_astscanner_(d85a459)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     70.1±0.90ms        ? ?/sec    1.05     73.5±3.95ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     96.8±1.03ms        ? ?/sec    1.02     99.2±1.94ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    111.6±0.99ms        ? ?/sec    1.01    112.6±0.69ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     79.3±1.10ms        ? ?/sec    1.03     81.3±0.97ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    124.0±1.51ms        ? ?/sec    1.01    125.2±1.84ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    212.5±2.02ms        ? ?/sec    1.04    221.5±1.68ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    258.6±3.27ms        ? ?/sec    1.00    258.8±2.27ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    139.3±2.43ms        ? ?/sec    1.00    138.2±1.49ms        ? ?/sec
bundle/bundle@threejs                                               1.00     36.9±2.21ms        ? ?/sec    1.02     37.8±3.79ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     94.1±1.28ms        ? ?/sec    1.01     95.1±1.53ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    105.9±0.67ms        ? ?/sec    1.00    106.2±0.41ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.4±0.57ms        ? ?/sec    1.00     47.2±0.36ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    397.8±2.89ms        ? ?/sec    1.00    398.7±3.45ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1218.6±10.72ms        ? ?/sec    1.00   1219.2±8.96ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1427.0±6.91ms        ? ?/sec    1.00   1420.5±8.28ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    474.5±3.41ms        ? ?/sec    1.00    473.0±2.75ms        ? ?/sec
remapping/remapping                                                 1.00     27.6±0.16ms        ? ?/sec    1.00     27.7±0.23ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     72.9±0.32ms        ? ?/sec    1.03     74.9±0.51ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     97.5±0.87ms        ? ?/sec    1.01     98.9±1.15ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.0±0.86ms        ? ?/sec    1.00     28.1±1.22ms        ? ?/sec
scan/scan@threejs10x                                                1.01    288.7±3.61ms        ? ?/sec    1.00    286.9±2.31ms        ? ?/sec

Base automatically changed from 11-27-feat_disable_resolve_new_url_to_asset_behavior_by_default to main November 27, 2024 12:14
@hyfdev
hyfdev force-pushed the 11-27-refactor_rust_make_sharedoptions_always_exist_on_astscanner_ branch from 144ea77 to d85a459 Compare November 27, 2024 12:14
@netlify

netlify Bot commented Nov 27, 2024

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit d85a459
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67470d31ea98870008a6a8f6

@hyfdev Graphite App

hyfdev commented Nov 27, 2024

Copy link
Copy Markdown
Member Author

Merge activity

  • Nov 27, 7:15 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyfdev
hyfdev added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit f9e04bb Nov 27, 2024
@hyfdev
hyfdev deleted the 11-27-refactor_rust_make_sharedoptions_always_exist_on_astscanner_ branch November 27, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@underfin underfin underfin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyfdev @underfin