Skip to content

feat: disable resolve new URL to asset behavior by default#2953

Merged
hyfdev merged 1 commit into
mainfrom
11-27-feat_disable_resolve_new_url_to_asset_behavior_by_default
Nov 27, 2024
Merged

feat: disable resolve new URL to asset behavior by default#2953
hyfdev merged 1 commit into
mainfrom
11-27-feat_disable_resolve_new_url_to_asset_behavior_by_default

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

I have discussed with @/yyx990803. For lib bundling, it's better to disable it by default.

@hyfdev Graphite App

hyfdev commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify

netlify Bot commented Nov 27, 2024

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit dbc8d9a
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6746de960854d40008ac36db

@hyfdev hyfdev mentioned this pull request Nov 27, 2024
Merged
@hyfdev
hyfdev marked this pull request as ready for review November 27, 2024 09:09
@github-actions

github-actions Bot commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(7a7492e)
  • pr: 11-27-feat_disable_resolve_new_url_to_asset_behavior_by_default(dbc8d9a)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     73.6±1.27ms        ? ?/sec    1.04     76.2±1.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00    101.7±1.54ms        ? ?/sec    1.01    102.7±1.55ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    114.2±1.89ms        ? ?/sec    1.03    117.2±1.38ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     82.9±1.22ms        ? ?/sec    1.02     84.7±1.22ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    125.3±1.40ms        ? ?/sec    1.03    129.6±2.80ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    219.1±4.89ms        ? ?/sec    1.11    243.5±6.48ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    272.5±5.65ms        ? ?/sec    1.02    278.1±5.97ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    138.8±1.28ms        ? ?/sec    1.03    142.7±1.51ms        ? ?/sec
bundle/bundle@threejs                                               1.06     38.0±1.47ms        ? ?/sec    1.00     35.9±0.57ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     95.6±1.27ms        ? ?/sec    1.01     96.6±1.54ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    111.0±0.95ms        ? ?/sec    1.02    113.7±1.15ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.7±0.91ms        ? ?/sec    1.00     47.7±1.23ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    402.9±4.42ms        ? ?/sec    1.01    408.4±3.86ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1245.3±18.87ms        ? ?/sec    1.01  1264.0±13.34ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1448.2±17.63ms        ? ?/sec    1.03  1497.0±11.17ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    476.2±5.58ms        ? ?/sec    1.01    482.4±4.68ms        ? ?/sec
remapping/remapping                                                 1.00     26.7±0.95ms        ? ?/sec    1.03     27.4±0.21ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     74.5±1.50ms        ? ?/sec    1.01     75.3±0.42ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     98.3±1.21ms        ? ?/sec    1.04    102.4±0.84ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.2±0.87ms        ? ?/sec    1.03     29.2±1.11ms        ? ?/sec
scan/scan@threejs10x                                                1.00    287.3±2.82ms        ? ?/sec    1.02    293.5±2.80ms        ? ?/sec

@hyfdev
hyfdev added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit e126911 Nov 27, 2024
@hyfdev
hyfdev deleted the 11-27-feat_disable_resolve_new_url_to_asset_behavior_by_default branch November 27, 2024 12:14
@Boshen Boshen mentioned this pull request May 26, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyfdev @IWANABETHATGUY