Skip to content

chore: improve error message of runtime helper __require#2922

Merged
hyfdev merged 1 commit into
mainfrom
11-26-chore_improve_error_message_of_runtime_helper___require_
Nov 26, 2024
Merged

chore: improve error message of runtime helper __require#2922
hyfdev merged 1 commit into
mainfrom
11-26-chore_improve_error_message_of_runtime_helper___require_

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 25, 2024

Copy link
Copy Markdown
Member

Description

Dynamic require of "' + x + '" is not supported.

is really a confusing message.

hyfdev commented Nov 25, 2024

Copy link
Copy Markdown
Member Author

@hyfdev
hyfdev force-pushed the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch from da49712 to ae91ea7 Compare November 25, 2024 17:55
@hyfdev
hyfdev marked this pull request as ready for review November 25, 2024 17:55
@hyfdev
hyfdev force-pushed the 11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_ branch 2 times, most recently from 4cf86da to 94a1a55 Compare November 25, 2024 17:57
@hyfdev
hyfdev force-pushed the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch from ae91ea7 to 6ab7228 Compare November 25, 2024 17:57
Base automatically changed from 11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_ to main November 25, 2024 18:34
@hyfdev
hyfdev force-pushed the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch from 6ab7228 to dbd7024 Compare November 25, 2024 18:35
@netlify

netlify Bot commented Nov 25, 2024

Copy link
Copy Markdown

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8a7ba82
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67454746a39e8c000839b554

hyfdev commented Nov 25, 2024

Copy link
Copy Markdown
Member Author

Merge activity

  • Nov 25, 1:36 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyfdev
hyfdev force-pushed the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch from dbd7024 to 8a7ba82 Compare November 26, 2024 03:57
@hyfdev
hyfdev added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 2140c92 Nov 26, 2024
@hyfdev
hyfdev deleted the 11-26-chore_improve_error_message_of_runtime_helper___require_ branch November 26, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants