Skip to content

feat(node/esm): polyfill require if format: 'esm' and platform: 'node'#2920

Merged
hyfdev merged 1 commit into
mainfrom
11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_
Nov 25, 2024
Merged

feat(node/esm): polyfill require if format: 'esm' and platform: 'node'#2920
hyfdev merged 1 commit into
mainfrom
11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

@hyfdev Graphite App

hyfdev commented Nov 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyfdev hyfdev mentioned this pull request Nov 25, 2024
Merged
@hyfdev
hyfdev marked this pull request as ready for review November 25, 2024 17:34
@hyfdev
hyfdev force-pushed the 11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_ branch 2 times, most recently from fc52a4a to 3b00fe9 Compare November 25, 2024 17:42
@hyfdev hyfdev mentioned this pull request Nov 25, 2024
Merged
Base automatically changed from 11-26-chore_node_rename_runtime-without-comments.js_with_runtime-base.js_ to main November 25, 2024 17:56
@github-actions

github-actions Bot commented Nov 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(84f2980)
  • pr: 11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_(94a1a55)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     77.6±1.95ms        ? ?/sec    1.02     79.0±1.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.03    108.0±2.88ms        ? ?/sec    1.00    104.7±1.26ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.03    122.6±3.22ms        ? ?/sec    1.00    119.4±1.77ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     86.8±2.54ms        ? ?/sec    1.03     89.7±3.81ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    131.8±1.86ms        ? ?/sec    1.01    133.5±2.40ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    232.7±9.22ms        ? ?/sec    1.02    238.4±5.34ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    276.2±6.62ms        ? ?/sec    1.04   286.8±11.59ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.02    146.7±2.28ms        ? ?/sec    1.00    144.2±2.85ms        ? ?/sec
bundle/bundle@threejs                                               1.02     39.6±1.76ms        ? ?/sec    1.00     38.8±0.89ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     99.2±2.06ms        ? ?/sec    1.01     99.9±2.45ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    112.5±2.49ms        ? ?/sec    1.03    115.8±1.35ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     49.6±0.91ms        ? ?/sec    1.04     51.5±1.04ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    419.6±4.31ms        ? ?/sec    1.04    437.5±8.50ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1312.4±11.26ms        ? ?/sec    1.02  1339.0±25.83ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1544.5±23.01ms        ? ?/sec    1.02  1581.8±21.92ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    498.7±8.38ms        ? ?/sec    1.00    497.2±3.98ms        ? ?/sec
remapping/remapping                                                 1.00     28.8±0.31ms        ? ?/sec    1.04     29.9±0.39ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     78.0±1.33ms        ? ?/sec    1.00     77.0±0.54ms        ? ?/sec
scan/scan@rome-ts                                                   1.04    111.9±2.18ms        ? ?/sec    1.00    107.7±2.35ms        ? ?/sec
scan/scan@threejs                                                   1.03     30.6±1.29ms        ? ?/sec    1.00     29.7±1.23ms        ? ?/sec
scan/scan@threejs10x                                                1.03    311.2±2.71ms        ? ?/sec    1.00    301.6±3.49ms        ? ?/sec

@hyfdev
hyfdev force-pushed the 11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_ branch 2 times, most recently from 4cf86da to 94a1a55 Compare November 25, 2024 17:57
@netlify

netlify Bot commented Nov 25, 2024

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4cf86da
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6744ba85a52e7000085134be

@hyfdev Graphite App

hyfdev commented Nov 25, 2024

Copy link
Copy Markdown
Member Author

Merge activity

  • Nov 25, 12:57 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@netlify

netlify Bot commented Nov 25, 2024

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 94a1a55
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6744ba9a35542e0008041ea9

@hyfdev
hyfdev added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit f1bd92f Nov 25, 2024
@hyfdev
hyfdev deleted the 11-26-feat_node_esm_polyfill_require_if_format_esm_and_platform_node_ branch November 25, 2024 18:34
@hyfdev hyfdev mentioned this pull request Dec 8, 2024
Closed
@haoqunjiang haoqunjiang mentioned this pull request Mar 24, 2025
Merged
@brendanmatkin brendanmatkin mentioned this pull request Dec 8, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Make require('external') runnable in any execution context if possible

2 participants

@hyfdev @IWANABETHATGUY