Skip to content

fix(use_strict): shouldn't care about empty modules#2844

Merged
hyfdev merged 1 commit into
mainfrom
11-21-fix_use_strict_shouldn_t_care_about_empty_modules
Nov 21, 2024
Merged

fix(use_strict): shouldn't care about empty modules#2844
hyfdev merged 1 commit into
mainfrom
11-21-fix_use_strict_shouldn_t_care_about_empty_modules

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@hyfdev Graphite App

hyfdev commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyfdev hyfdev mentioned this pull request Nov 21, 2024
Merged
@hyfdev
hyfdev marked this pull request as ready for review November 21, 2024 11:02
@hyfdev
hyfdev force-pushed the 11-21-fix_use_strict_should_nt_care_about_treeshaked_modules branch from 8b7cdc3 to 13f28de Compare November 21, 2024 11:16
@hyfdev
hyfdev force-pushed the 11-21-fix_use_strict_shouldn_t_care_about_empty_modules branch from 38ecbc0 to 3f32c38 Compare November 21, 2024 11:16
@github-actions

github-actions Bot commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(caa5e87)
  • pr: 11-21-fix_use_strict_shouldn_t_care_about_empty_modules(ae72801)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     59.3±0.84ms        ? ?/sec    1.02     60.5±1.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     85.2±1.19ms        ? ?/sec    1.02     87.0±1.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    100.9±1.04ms        ? ?/sec    1.02    102.5±0.92ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     68.2±0.66ms        ? ?/sec    1.02     69.6±0.73ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    107.8±0.76ms        ? ?/sec    1.01    108.7±0.99ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    203.0±1.72ms        ? ?/sec    1.04    210.8±1.67ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    247.9±1.95ms        ? ?/sec    1.02    252.7±8.58ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    123.4±1.10ms        ? ?/sec    1.00    123.6±1.06ms        ? ?/sec
bundle/bundle@threejs                                               1.00     35.0±0.46ms        ? ?/sec    1.01     35.4±1.50ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     92.4±1.96ms        ? ?/sec    1.00     92.7±1.16ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    108.2±0.74ms        ? ?/sec    1.00    108.5±0.82ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     44.3±0.39ms        ? ?/sec    1.00     44.2±0.28ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    385.8±5.17ms        ? ?/sec    1.01    388.6±5.34ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1211.2±8.43ms        ? ?/sec    1.01   1217.3±8.96ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1421.3±11.85ms        ? ?/sec    1.00   1426.0±8.72ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    450.2±6.91ms        ? ?/sec    1.00    450.2±6.63ms        ? ?/sec
remapping/remapping                                                 1.00     27.3±0.14ms        ? ?/sec    1.03     28.1±0.11ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     75.0±0.47ms        ? ?/sec    1.00     75.3±0.66ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     86.9±0.79ms        ? ?/sec    1.00     87.3±0.77ms        ? ?/sec
scan/scan@threejs                                                   1.00     26.9±0.11ms        ? ?/sec    1.01     27.2±0.85ms        ? ?/sec
scan/scan@threejs10x                                                1.00    280.2±3.84ms        ? ?/sec    1.01    281.9±2.87ms        ? ?/sec

Base automatically changed from 11-21-fix_use_strict_should_nt_care_about_treeshaked_modules to main November 21, 2024 11:50
@hyfdev
hyfdev force-pushed the 11-21-fix_use_strict_shouldn_t_care_about_empty_modules branch from 3f32c38 to 304e7c2 Compare November 21, 2024 11:51
@netlify

netlify Bot commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ae72801
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/673f2457676ba3000822e049

@hyfdev Graphite App

hyfdev commented Nov 21, 2024

Copy link
Copy Markdown
Member Author

Merge activity

  • Nov 21, 6:51 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyfdev
hyfdev force-pushed the 11-21-fix_use_strict_shouldn_t_care_about_empty_modules branch from 304e7c2 to ae72801 Compare November 21, 2024 12:15
@hyfdev
hyfdev added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit ea3f093 Nov 21, 2024
@hyfdev
hyfdev deleted the 11-21-fix_use_strict_shouldn_t_care_about_empty_modules branch November 21, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: remove "use strict" for an empty file

2 participants

@hyfdev @IWANABETHATGUY