Skip to content

fix(use_strict): shouldn't care about treeshaked modules#2843

Merged
hyfdev merged 1 commit into
mainfrom
11-21-fix_use_strict_should_nt_care_about_treeshaked_modules
Nov 21, 2024
Merged

fix(use_strict): shouldn't care about treeshaked modules#2843
hyfdev merged 1 commit into
mainfrom
11-21-fix_use_strict_should_nt_care_about_treeshaked_modules

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 21, 2024

Copy link
Copy Markdown
Member

Description

@hyfdev Graphite App

hyfdev commented Nov 21, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyfdev hyfdev mentioned this pull request Nov 21, 2024
Merged
@hyfdev hyfdev changed the title fix(use_strict): should'nt care about treeshaked modules fix(use_strict): shouldn't care about treeshaked modules Nov 21, 2024
@hyfdev
hyfdev marked this pull request as ready for review November 21, 2024 11:02
@netlify

netlify Bot commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 13f28de
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/673f1683ff46b500082726fb

@hyfdev
hyfdev force-pushed the 11-21-fix_use_strict_should_nt_care_about_treeshaked_modules branch from 8b7cdc3 to 13f28de Compare November 21, 2024 11:16
@hyfdev
hyfdev added this pull request to the merge queue Nov 21, 2024
@github-actions

github-actions Bot commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(ab515a7)
  • pr: 11-21-fix_use_strict_should_nt_care_about_treeshaked_modules(13f28de)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     61.4±1.20ms        ? ?/sec    1.01     61.8±1.23ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.03     88.0±2.18ms        ? ?/sec    1.00     85.8±0.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.01    102.8±1.74ms        ? ?/sec    1.00    101.8±1.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     70.2±1.11ms        ? ?/sec    1.00     69.7±1.35ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    109.4±1.13ms        ? ?/sec    1.00    109.5±0.99ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    208.4±4.00ms        ? ?/sec    1.02    213.4±6.96ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    251.7±3.21ms        ? ?/sec    1.02    255.6±6.32ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    125.1±2.24ms        ? ?/sec    1.00    124.9±1.28ms        ? ?/sec
bundle/bundle@threejs                                               1.03     36.4±1.31ms        ? ?/sec    1.00     35.4±0.41ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     94.1±1.46ms        ? ?/sec    1.00     94.0±1.50ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    109.3±1.40ms        ? ?/sec    1.00    109.5±1.02ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     44.4±0.42ms        ? ?/sec    1.01     44.8±0.42ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    391.7±6.10ms        ? ?/sec    1.00    390.8±5.12ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1231.8±18.29ms        ? ?/sec    1.00  1232.6±10.17ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1440.1±17.43ms        ? ?/sec    1.00  1436.0±10.67ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    448.5±4.42ms        ? ?/sec    1.00    447.6±5.40ms        ? ?/sec
remapping/remapping                                                 1.00     27.0±0.25ms        ? ?/sec    1.05     28.2±0.18ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     74.0±0.48ms        ? ?/sec    1.01     74.7±0.45ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     88.8±0.98ms        ? ?/sec    1.00     87.6±0.97ms        ? ?/sec
scan/scan@threejs                                                   1.01     27.4±0.84ms        ? ?/sec    1.00     27.1±0.27ms        ? ?/sec
scan/scan@threejs10x                                                1.00    283.1±3.01ms        ? ?/sec    1.00    282.1±4.09ms        ? ?/sec

Merged via the queue into main with commit caa5e87 Nov 21, 2024
@hyfdev
hyfdev deleted the 11-21-fix_use_strict_should_nt_care_about_treeshaked_modules branch November 21, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyfdev @IWANABETHATGUY