fix: avoid unresolved promise if load same id at concurrent#2777
Merged
fix: avoid unresolved promise if load same id at concurrent#2777
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
underfin
force-pushed
the
fix-load-same-id-concurrent
branch
from
8937456 to
9268d2c
Compare
Member
|
I try the issue case locally, it does not seems to work, still stuck when bundling |
underfin
force-pushed
the
fix-load-same-id-concurrent
branch
from
b3dc4d4 to
f0ae3f3
Compare
IWANABETHATGUY
approved these changes
Nov 18, 2024
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
The code for `this.load` waited for the `markModuleLoaded` callback to be called. But this should be able to simplify by using a future. This PR refactors the code for `this.load` to wait for a future instead. This should also improve the perf a bit because we no longer have to call `markModuleLoaded` for each module. I wonder if I'm missing something. refs #4156, #2777, #2772, #2687
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #2751