Skip to content

Comments

feat: support mark moduleSideEffects at PluginContext.load#2772

Merged
IWANABETHATGUY merged 1 commit intomainfrom
feat-plugin-context-load-moduleSideEffects
Nov 18, 2024
Merged

feat: support mark moduleSideEffects at PluginContext.load#2772
IWANABETHATGUY merged 1 commit intomainfrom
feat-plugin-context-load-moduleSideEffects

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Nov 18, 2024

Description

close #2752

@netlify
Copy link

netlify bot commented Nov 18, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a75722b
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/673aae19212bdd000891e1ed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

Benchmarks Rust

  • target: main(ac8b28a)
  • pr: feat-plugin-context-load-moduleSideEffects(a75722b)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     61.1±0.86ms        ? ?/sec    1.00     61.2±0.94ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     88.7±3.59ms        ? ?/sec    1.00     87.8±1.40ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    103.1±1.30ms        ? ?/sec    1.00    102.9±1.11ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     70.1±1.66ms        ? ?/sec    1.01     70.6±0.80ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    110.5±0.91ms        ? ?/sec    1.00    109.6±1.23ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.04    213.8±2.91ms        ? ?/sec    1.00    204.8±1.63ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.05   261.8±14.08ms        ? ?/sec    1.00    250.0±2.75ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    127.2±1.27ms        ? ?/sec    1.00    127.6±1.83ms        ? ?/sec
bundle/bundle@threejs                                               1.02     36.1±1.05ms        ? ?/sec    1.00     35.4±0.19ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     93.8±0.76ms        ? ?/sec    1.00     93.4±0.81ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    109.9±2.48ms        ? ?/sec    1.01    111.0±1.56ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.02     46.7±0.80ms        ? ?/sec    1.00     45.6±0.45ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    386.8±2.45ms        ? ?/sec    1.00    387.3±3.07ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.02  1220.3±11.43ms        ? ?/sec    1.00  1200.2±13.93ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1432.2±13.33ms        ? ?/sec    1.00  1414.7±20.73ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    452.6±5.01ms        ? ?/sec    1.00    446.2±4.48ms        ? ?/sec
remapping/remapping                                                 1.02     28.2±0.27ms        ? ?/sec    1.00     27.8±0.28ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     74.7±0.31ms        ? ?/sec    1.00     73.3±0.35ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     86.9±0.51ms        ? ?/sec    1.01     87.5±0.98ms        ? ?/sec
scan/scan@threejs                                                   1.00     27.0±0.16ms        ? ?/sec    1.01     27.2±0.76ms        ? ?/sec
scan/scan@threejs10x                                                1.02    282.7±6.46ms        ? ?/sec    1.00    277.3±2.00ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit ba8a5f1 Nov 18, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the feat-plugin-context-load-moduleSideEffects branch November 18, 2024 03:27
@sapphi-red sapphi-red mentioned this pull request Sep 15, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Sep 16, 2025
@sapphi-red
refactor: wait this.load using futures instead of callbacks (#6222)
392ad04 
The code for `this.load` waited for the `markModuleLoaded` callback to be called. But this should be able to simplify by using a future.
This PR refactors the code for `this.load` to wait for a future instead. This should also improve the perf a bit because we no longer have to call `markModuleLoaded` for each module.
I wonder if I'm missing something.

refs #4156, #2777, #2772, #2687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: assigning to moduleSideEffects returned from this.load has no effect

2 participants

@underfin @IWANABETHATGUY