Skip to content

refactor: extract get_leading_comment function#2755

Merged
IWANABETHATGUY merged 3 commits intomainfrom
11-15-refactor_extract_get_leading_comment_function
Nov 15, 2024
Merged

refactor: extract get_leading_comment function#2755
IWANABETHATGUY merged 3 commits intomainfrom
11-15-refactor_extract_get_leading_comment_function

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Nov 15, 2024

Description

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review November 15, 2024 12:03
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Nov 15, 2024
Merged
@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Nov 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Nov 15, 2024
Merged
@IWANABETHATGUY IWANABETHATGUY changed the title refactor: extract get_leading_comment function refactor: extract get_leading_comment function Nov 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 15, 2024

Benchmarks Rust

  • target: 11-15-refactor_handle_url_import_rewrite_on_the_fly(ee97927)
  • pr: 11-15-refactor_extract_get_leading_comment_function(51f9932)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     60.6±0.68ms        ? ?/sec    1.01     61.1±0.69ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     87.9±1.13ms        ? ?/sec    1.00     87.4±1.12ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    102.0±0.90ms        ? ?/sec    1.00    102.3±1.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     69.0±0.71ms        ? ?/sec    1.00     69.2±0.76ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    111.4±1.85ms        ? ?/sec    1.00    111.1±2.03ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    205.4±1.62ms        ? ?/sec    1.00    205.6±1.36ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    248.5±1.31ms        ? ?/sec    1.00    249.6±1.41ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    124.5±0.69ms        ? ?/sec    1.00    124.4±0.95ms        ? ?/sec
bundle/bundle@threejs                                               1.00     36.9±1.41ms        ? ?/sec    1.01     37.1±1.38ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     94.9±0.60ms        ? ?/sec    1.01     95.8±0.77ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    108.9±1.02ms        ? ?/sec    1.01    109.9±0.87ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     44.3±0.45ms        ? ?/sec    1.00     44.5±0.42ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    388.8±2.91ms        ? ?/sec    1.01    390.8±2.65ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1222.0±10.36ms        ? ?/sec    1.00   1226.5±8.01ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1445.2±8.54ms        ? ?/sec    1.00  1444.7±10.58ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    450.8±4.42ms        ? ?/sec    1.01    453.2±5.04ms        ? ?/sec
remapping/remapping                                                 1.00     28.4±0.61ms        ? ?/sec    1.00     28.3±0.26ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     71.1±0.50ms        ? ?/sec    1.00     69.9±0.37ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     88.0±0.75ms        ? ?/sec    1.00     87.3±0.81ms        ? ?/sec
scan/scan@threejs                                                   1.01     27.5±2.00ms        ? ?/sec    1.00     27.1±0.88ms        ? ?/sec
scan/scan@threejs10x                                                1.01    280.2±2.73ms        ? ?/sec    1.00    278.1±2.46ms        ? ?/sec

Base automatically changed from 11-15-refactor_handle_url_import_rewrite_on_the_fly to main November 15, 2024 12:18
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 3f73e6d Nov 15, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the 11-15-refactor_extract_get_leading_comment_function branch November 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0