Skip to content

refactor: merge handle_new_url_with_string_literal_and_import_meta_url test and rewrite in single pass#2754

Merged
IWANABETHATGUY merged 2 commits intomainfrom
11-15-refactor_handle_url_import_rewrite_on_the_fly
Nov 15, 2024
Merged

refactor: merge handle_new_url_with_string_literal_and_import_meta_url test and rewrite in single pass#2754
IWANABETHATGUY merged 2 commits intomainfrom
11-15-refactor_handle_url_import_rewrite_on_the_fly

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Nov 15, 2024 •
edited
Loading

Description

  1. merge handle_new_url_with_string_literal_and_import_meta_url test and rewrite, reuse pattern matched var should also perf a little

@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Nov 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Nov 15, 2024
Merged
Base automatically changed from fix/opt-out-import-url-import to main November 15, 2024 11:36
@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-15-refactor_handle_url_import_rewrite_on_the_fly branch from aa8207e to 098097b Compare November 15, 2024 11:38
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ee97927
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/673734b5f77b830008b83da0

@IWANABETHATGUY IWANABETHATGUY changed the title refactor: handle url import rewrite on the fly refactor: merge handle_new_url_with_string_literal_and_import_meta_url test and rewrite Nov 15, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title refactor: merge handle_new_url_with_string_literal_and_import_meta_url test and rewrite refactor: merge handle_new_url_with_string_literal_and_import_meta_url test and rewrite in single pass Nov 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 15, 2024

Benchmarks Rust

  • target: main(1839fd3)
  • pr: 11-15-refactor_handle_url_import_rewrite_on_the_fly(ee97927)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     66.6±1.82ms        ? ?/sec    1.00     65.8±1.32ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     93.1±5.53ms        ? ?/sec    1.00     92.3±2.40ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    106.5±2.60ms        ? ?/sec    1.02    108.5±4.63ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     73.6±1.91ms        ? ?/sec    1.01     74.0±1.54ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    112.1±1.28ms        ? ?/sec    1.03    115.0±1.90ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    228.8±8.50ms        ? ?/sec    1.03    235.9±5.55ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    270.5±9.17ms        ? ?/sec    1.03   280.0±10.66ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    127.1±2.50ms        ? ?/sec    1.01    127.7±1.39ms        ? ?/sec
bundle/bundle@threejs                                               1.02     39.8±3.09ms        ? ?/sec    1.00     39.0±1.64ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     99.8±2.61ms        ? ?/sec    1.01    100.9±4.55ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    113.3±2.65ms        ? ?/sec    1.04    117.3±7.24ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     46.1±0.64ms        ? ?/sec    1.02     46.9±2.30ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    392.3±3.92ms        ? ?/sec    1.02    400.5±7.13ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1265.2±12.19ms        ? ?/sec    1.03  1299.8±17.08ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1497.5±12.27ms        ? ?/sec    1.01  1517.5±18.43ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    456.3±8.38ms        ? ?/sec    1.02    463.9±9.64ms        ? ?/sec
remapping/remapping                                                 1.00     27.3±2.74ms        ? ?/sec    1.03     28.2±0.20ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     70.0±0.48ms        ? ?/sec    1.00     69.0±0.44ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     91.7±0.78ms        ? ?/sec    1.00     91.5±1.71ms        ? ?/sec
scan/scan@threejs                                                   1.02     28.8±1.94ms        ? ?/sec    1.00     28.2±0.43ms        ? ?/sec
scan/scan@threejs10x                                                1.00    286.7±3.34ms        ? ?/sec    1.01    289.7±3.91ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review November 15, 2024 12:03
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Nov 15, 2024
Merged
@IWANABETHATGUY IWANABETHATGUY changed the title refactor: merge handle_new_url_with_string_literal_and_import_meta_url test and rewrite in single pass refactor: merge handle_new_url_with_string_literal_and_import_meta_url test and rewrite in single pass Nov 15, 2024
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 30d96e5 Nov 15, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the 11-15-refactor_handle_url_import_rewrite_on_the_fly branch November 15, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0