Skip to content

feat: optout new URL('./foo', import.meta.url) import#2753

Merged
IWANABETHATGUY merged 7 commits intomainfrom
fix/opt-out-import-url-import
Nov 15, 2024
Merged

feat: optout new URL('./foo', import.meta.url) import#2753
IWANABETHATGUY merged 7 commits intomainfrom
fix/opt-out-import-url-import

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Nov 15, 2024 •
edited
Loading

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c39e62f
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/673729167ca3580008cde61f

@IWANABETHATGUY IWANABETHATGUY changed the title optout import url import feat: optout new URL import Nov 15, 2024
hyf0
hyf0 reviewed Nov 15, 2024
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     62.6±1.02ms        ? ?/sec    1.08     67.7±1.14ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     87.9±1.07ms        ? ?/sec    1.06     93.1±1.53ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    103.5±1.44ms        ? ?/sec    1.06    109.6±1.31ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     70.9±1.51ms        ? ?/sec    1.06     75.2±0.99ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    111.3±1.32ms        ? ?/sec    1.03    114.6±1.23ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    221.2±5.84ms        ? ?/sec    1.11    245.2±8.26ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    257.5±4.04ms        ? ?/sec    1.15    295.8±9.23ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    124.8±1.72ms        ? ?/sec    1.04    130.1±1.18ms        ? ?/sec
bundle/bundle@threejs                                               1.00     37.6±0.72ms        ? ?/sec    1.01     38.0±1.15ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     96.6±1.60ms        ? ?/sec    1.03     99.6±1.28ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    112.5±1.47ms        ? ?/sec    1.00    112.0±1.70ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     45.1±0.62ms        ? ?/sec    1.04     46.7±1.43ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    390.1±3.53ms        ? ?/sec    1.00    391.1±3.83ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1246.6±17.61ms        ? ?/sec    1.00  1250.5±13.00ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1462.0±18.39ms        ? ?/sec    1.04  1521.4±18.13ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    447.2±3.64ms        ? ?/sec    1.01    450.9±3.99ms        ? ?/sec
remapping/remapping                                                 1.00     28.6±0.14ms        ? ?/sec    1.01     28.7±0.12ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     69.9±0.34ms        ? ?/sec    1.01     70.6±0.52ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     88.6±0.64ms        ? ?/sec    1.03     91.5±0.84ms        ? ?/sec
scan/scan@threejs                                                   1.00     27.3±0.13ms        ? ?/sec    1.05     28.7±0.19ms        ? ?/sec
scan/scan@threejs10x                                                1.00    284.2±3.80ms        ? ?/sec    1.04    294.2±5.69ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review November 15, 2024 10:58
@IWANABETHATGUY IWANABETHATGUY changed the title feat: optout new URL import feat: optout new URL('', import.meta.url) import Nov 15, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat: optout new URL('', import.meta.url) import feat: optout new URL('./foo', import.meta.url) import Nov 15, 2024
hyf0
hyf0 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure we don't support the wrong pattern.

@IWANABETHATGUY
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Nov 15, 2024

LGTM. Make sure we don't support the wrong pattern.

Yeah, ref https://github.com/vitejs/vite/pull/16590/files

@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Nov 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Nov 15, 2024
Merged
@IWANABETHATGUY IWANABETHATGUY merged commit 1839fd3 into main Nov 15, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the fix/opt-out-import-url-import branch November 15, 2024 11:36
@IWANABETHATGUY
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Nov 15, 2024

merged directly and skip flaky test

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: A way to opt-out the new URL('./foo', import.meta.url) transform

2 participants

@IWANABETHATGUY @hyf0