Closed
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
<!-- Thank you for contributing! --> ### Description Support `PluginContext.load`, ref https://rollupjs.org/plugin-development/#this-load. close #2355. The pr using msg channel to hand extra modules need to load. Here need to use one channel to avoid #2687 (comment). > Here has a another way to do it. Using `load_via_plugins`, like `resolve_id_via_plugins`, but it need to a lot of change the relation crate dependencies and meet a cycle dependencies problem at moving `create_ecma_view`, it is difficult to resolve. try here at #2690. The pr implements it as much as possible, but it also has a problem, consider some cases at here. - `ModuleTables` has not the module `A`, here only fetch it. - `ModuleTables` has module `A` and already fetched, here return already fetched result, using `PluginContext#modules`. - `ModuleTables` has module `A` but it is not fetched finished, here may lost result because here can't ensure the fetch time before the module task is finished. The case maybe happend because it is run at parallel. We could re-fetch it at the case, but it call the module-related hook again, It could be put as low priority to resolve. <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description