Skip to content

feat(cjs/output): generate proper property access pattern for exports#2283

Merged
hyf0 merged 1 commit intomainfrom
09-23-feat_cjs_output_generate_proper_property_access_pattern_for_exports
Sep 23, 2024
Merged

feat(cjs/output): generate proper property access pattern for exports#2283
hyf0 merged 1 commit intomainfrom
09-23-feat_cjs_output_generate_proper_property_access_pattern_for_exports

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 23, 2024

Description

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 mentioned this pull request Sep 23, 2024
Merged
@hyf0 hyf0 marked this pull request as ready for review September 23, 2024 04:33
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(c56991c)
  • pr: 09-23-feat_cjs_output_generate_proper_property_access_pattern_for_exports(fb964b4)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     58.7±0.56ms        ? ?/sec    1.00     58.1±0.60ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     81.4±1.22ms        ? ?/sec    1.00     80.4±0.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.01     98.4±0.86ms        ? ?/sec    1.00     97.7±0.92ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     66.5±0.75ms        ? ?/sec    1.00     66.3±0.57ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    104.4±0.94ms        ? ?/sec    1.00    103.9±1.60ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    192.1±3.95ms        ? ?/sec    1.00    191.2±6.44ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    236.5±2.44ms        ? ?/sec    1.00    236.0±3.52ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    119.2±0.75ms        ? ?/sec    1.00    118.5±1.11ms        ? ?/sec
bundle/bundle@threejs                                               1.05     38.4±2.10ms        ? ?/sec    1.00     36.5±1.38ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     84.1±1.11ms        ? ?/sec    1.00     83.5±1.36ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     99.7±3.30ms        ? ?/sec    1.03    102.8±3.78ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     45.0±0.54ms        ? ?/sec    1.00     44.4±0.35ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    365.3±3.94ms        ? ?/sec    1.00    361.5±3.30ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.02    995.0±9.41ms        ? ?/sec    1.00    978.0±5.71ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01   1269.4±6.66ms        ? ?/sec    1.00   1257.8±8.81ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.02    435.2±6.96ms        ? ?/sec    1.00    428.4±2.70ms        ? ?/sec
remapping/remapping                                                 1.00     33.6±0.14ms        ? ?/sec    1.01     33.7±0.16ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     84.3±0.62ms        ? ?/sec    1.00     84.2±0.69ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     85.1±1.08ms        ? ?/sec    1.00     84.3±0.85ms        ? ?/sec
scan/scan@threejs                                                   1.00     26.0±0.43ms        ? ?/sec    1.01     26.4±0.23ms        ? ?/sec
scan/scan@threejs10x                                                1.00    262.8±2.30ms        ? ?/sec    1.00    262.2±5.17ms        ? ?/sec

@hyf0 hyf0 force-pushed the 09-23-feat_node_experimental_add_disablelivebindings_option branch from 1822f21 to 9c4f35a Compare September 23, 2024 09:51
@hyf0 hyf0 force-pushed the 09-23-feat_cjs_output_generate_proper_property_access_pattern_for_exports branch from 9ca5e6e to 58fa2be Compare September 23, 2024 09:51
Base automatically changed from 09-23-feat_node_experimental_add_disablelivebindings_option to main September 23, 2024 10:12
@hyf0 hyf0 force-pushed the 09-23-feat_cjs_output_generate_proper_property_access_pattern_for_exports branch from 58fa2be to fb964b4 Compare September 23, 2024 10:12
@netlify
Copy link

netlify bot commented Sep 23, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit fb964b4
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66f13f07b4a7820008805ded

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 23, 2024

Merge activity

  • Sep 23, 6:12 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyf0 hyf0 added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit c85538e Sep 23, 2024
@hyf0 hyf0 deleted the 09-23-feat_cjs_output_generate_proper_property_access_pattern_for_exports branch September 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY