feat(node/experimental): add disableLiveBindings option#2282
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
Benchmarks Rust |
| self.strict_execution_order.unwrap_or(false) | ||
| } | ||
|
|
||
| pub fn is_disable_live_bindings_enabled(&self) -> bool { |
Member
There was a problem hiding this comment.
the naming is a little verbose, I think disable_live_bindings is enough.
Member
Author
There was a problem hiding this comment.
Just follow the previous is_strict_execution_order_enabled pattern. But yeah, shorthand pattern is also fine.
Member
There was a problem hiding this comment.
I am ok for both, just a NIT
hyf0
force-pushed
the
09-23-feat_node_experimental_add_disablelivebindings_option
branch
from
1822f21 to
9c4f35a
Compare
IWANABETHATGUY
approved these changes
Sep 23, 2024
hyf0
deleted the
09-23-feat_node_experimental_add_disablelivebindings_option
branch
hyf0
commented
Jan 9, 2026
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
This PR removes `experimental.disableLiveBindings` option. This option was introduced in #2282 to reduce the code size in some cases. Now that Rolldown uses `exports.foo =` instead of `Object.defineProperty(exports, 'foo', { get() { ... } })` if the value is known not to be changed, there are few cases this option is effective.
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
This PR removes `experimental.disableLiveBindings` option. This option was introduced in #2282 to reduce the code size in some cases. Now that Rolldown uses `exports.foo =` instead of `Object.defineProperty(exports, 'foo', { get() { ... } })` if the value is known not to be changed, there are few cases this option is effective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description