Skip to content

Comments

refactor: remove unncecessary ts type import#2249

Merged
IWANABETHATGUY merged 3 commits intomainfrom
chore/refactor-none-type-in-ast-builder
Sep 17, 2024
Merged

refactor: remove unncecessary ts type import#2249
IWANABETHATGUY merged 3 commits intomainfrom
chore/refactor-none-type-in-ast-builder

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Sep 17, 2024 •
edited
Loading

Description

  1. see feat(ast): provide NONE type for AST builder calls oxc-project/oxc#5737 for more details.
  2. Reduce verbose ts ast node imports.

@netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 83dac26
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66e94b21a044790008d6da57

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(5b448c9)
  • pr: chore/refactor-none-type-in-ast-builder(83dac26)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     55.2±0.84ms        ? ?/sec    1.00     54.5±1.01ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     77.3±1.20ms        ? ?/sec    1.00     77.1±0.74ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     94.6±1.03ms        ? ?/sec    1.00     94.7±1.64ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     63.4±0.51ms        ? ?/sec    1.00     62.7±1.02ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    102.4±1.14ms        ? ?/sec    1.00    100.9±0.65ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    184.3±2.84ms        ? ?/sec    1.00    183.9±8.19ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    226.8±4.47ms        ? ?/sec    1.00    227.4±3.62ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.02    118.8±1.76ms        ? ?/sec    1.00    115.9±0.97ms        ? ?/sec
bundle/bundle@threejs                                               1.00     33.5±1.08ms        ? ?/sec    1.00     33.5±1.00ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     76.8±1.25ms        ? ?/sec    1.02     78.1±1.53ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     94.7±1.78ms        ? ?/sec    1.00     94.9±1.47ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     43.2±0.40ms        ? ?/sec    1.00     43.0±0.55ms        ? ?/sec
bundle/bundle@threejs10x                                            1.03    358.8±2.48ms        ? ?/sec    1.00    348.6±2.24ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01    973.1±4.47ms        ? ?/sec    1.00    968.1±4.30ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1247.0±9.13ms        ? ?/sec    1.00  1252.3±15.97ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    427.1±2.73ms        ? ?/sec    1.00    420.9±2.14ms        ? ?/sec
remapping/remapping                                                 1.00     33.2±0.17ms        ? ?/sec    1.00     33.4±0.16ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     84.5±0.29ms        ? ?/sec    1.00     83.8±0.31ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     82.1±1.73ms        ? ?/sec    1.00     81.6±0.69ms        ? ?/sec
scan/scan@threejs                                                   1.00     25.2±0.28ms        ? ?/sec    1.01     25.6±0.81ms        ? ?/sec
scan/scan@threejs10x                                                1.00    255.6±1.99ms        ? ?/sec    1.00    255.5±2.07ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 17, 2024 09:25
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit dab103f Sep 17, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the chore/refactor-none-type-in-ast-builder branch September 17, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0