Skip to content

Comments

chore: remove extra external node:assert in test configs.#1886

Merged
hyf0 merged 2 commits intorolldown:mainfrom
7086cmd:chore/remove-manual-auto-external
Aug 7, 2024
Merged

chore: remove extra external node:assert in test configs.#1886
hyf0 merged 2 commits intorolldown:mainfrom
7086cmd:chore/remove-manual-auto-external

Conversation

@7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Aug 7, 2024

          `node:assert` is external by default.

Originally posted by @IWANABETHATGUY in #1746 (comment)

@7086cmd 7086cmd changed the title chore: remove extra node:assert decl in test configs chore: remove extra external node:assert in test configs. Aug 7, 2024
@netlify
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit f190c66
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66b3002e1e58d80008ef68d6

Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hyf0 hyf0 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into rolldown:main with commit ac6fc00 Aug 7, 2024
@7086cmd 7086cmd deleted the chore/remove-manual-auto-external branch August 7, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants