style(node/lint): prepare codebase for no-unused-vars#1800
Merged
hyf0 merged 2 commits intorolldown:mainfrom Jul 31, 2024
Merged
style(node/lint): prepare codebase for no-unused-vars#1800hyf0 merged 2 commits intorolldown:mainfrom
hyf0 merged 2 commits intorolldown:mainfrom
Conversation
Oxlint will be merging rolldown#4445 soon, which will add warnings to all unused variables. This PR updates rolldown's oxlint config and cleans up some code to prevent your CI from failing.
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “!merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “!merge-as-hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Merge activity
|
hyf0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Oxlint will be adding no-unused-vars soon, which will add warnings to all unused variables. This PR updates Rolldown's
.oxlintrc.jsonand cleans up some code to prevent your CI from failing.