Skip to content

Comments

perf(sourcemap): pre-allocate concat sourcemap builder#1764

Closed
underfin wants to merge 1 commit intomainfrom
pre-allocate-ConcatSourceMapBuilder
Closed

perf(sourcemap): pre-allocate concat sourcemap builder#1764
underfin wants to merge 1 commit intomainfrom
pre-allocate-ConcatSourceMapBuilder

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Jul 28, 2024

Description

@underfin underfin marked this pull request as draft July 28, 2024 03:30
@netlify
Copy link

netlify bot commented Jul 28, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 76167d5
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66a5bb401360b500081bbd12

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(b15d8c5)
  • pr: pre-allocate-ConcatSourceMapBuilder(76167d5)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     46.2±0.59ms        ? ?/sec    1.01     46.7±0.71ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     65.6±0.65ms        ? ?/sec    1.04     68.2±1.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     83.2±0.79ms        ? ?/sec    1.03     85.8±1.79ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     55.6±1.23ms        ? ?/sec    1.02     56.6±0.71ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00     87.7±1.48ms        ? ?/sec    1.01     88.5±1.30ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    143.9±1.03ms        ? ?/sec    1.03    148.4±4.07ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    188.2±1.29ms        ? ?/sec    1.01    189.9±1.67ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    106.7±1.95ms        ? ?/sec    1.01    107.6±1.23ms        ? ?/sec
bundle/bundle@threejs                                               1.01     26.4±0.74ms        ? ?/sec    1.00     26.1±0.33ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     61.7±1.32ms        ? ?/sec    1.00     62.0±1.68ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     80.3±0.90ms        ? ?/sec    1.01     80.7±1.11ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     36.8±0.67ms        ? ?/sec    1.00     36.9±0.76ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    294.4±3.17ms        ? ?/sec    1.00    294.7±1.97ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   883.7±10.50ms        ? ?/sec    1.01   892.0±11.04ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1113.1±9.92ms        ? ?/sec    1.01  1124.2±10.45ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    367.3±4.19ms        ? ?/sec    1.01    372.0±3.40ms        ? ?/sec
remapping/remapping                                                 1.03     34.5±0.48ms        ? ?/sec    1.00     33.4±0.34ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     86.2±0.49ms        ? ?/sec    1.00     85.0±0.44ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     69.6±0.63ms        ? ?/sec    1.00     69.5±0.65ms        ? ?/sec
scan/scan@threejs                                                   1.00     19.2±0.47ms        ? ?/sec    1.00     19.2±0.37ms        ? ?/sec
scan/scan@threejs10x                                                1.00    197.4±1.54ms        ? ?/sec    1.00    197.1±1.48ms        ? ?/sec

@underfin underfin closed this Jul 28, 2024
@underfin underfin mentioned this pull request Aug 6, 2024
Merged
@Brooooooklyn Brooooooklyn deleted the pre-allocate-ConcatSourceMapBuilder branch January 17, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@underfin