fix: reserve reserved-key in json module type.#1746
Merged
hyf0 merged 1 commit intorolldown:mainfrom Jul 26, 2024
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
7086cmd
changed the title
reserved-key in json module type.
hyf0
approved these changes
Jul 26, 2024
Member
|
Thanks! |
crates/rolldown/tests/fixtures/function/module_types/json/object_with_reserved_key/_config.json
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
`node:assert` is external by default. _Originally posted by @IWANABETHATGUY in #1746 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolldown seems to panic when parsing the following JSON before this PR:
{ "null": null }I used functions in
oxc::syntax::keywordto solve it.Notice that
is_reserved_keyword_or_global_objectfunction is suffering wrong calling (related pr: oxc-project/oxc#4484), I'll separately call them in this PR.