Skip to content

Comments

chore: bump oxc to 0.22.1#1726

Merged
hyf0 merged 9 commits intomainfrom
try-next-oxc-2
Jul 28, 2024
Merged

chore: bump oxc to 0.22.1#1726
hyf0 merged 9 commits intomainfrom
try-next-oxc-2

Conversation

@Dunqing
Copy link
Collaborator

@Dunqing Dunqing commented Jul 25, 2024

Description

@netlify
Copy link

netlify bot commented Jul 25, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3e08d53
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66a5a87be2f4630008409e58

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     48.2±0.81ms        ? ?/sec    1.04     50.0±1.75ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     65.1±1.27ms        ? ?/sec    1.06     69.3±1.12ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     83.0±0.88ms        ? ?/sec    1.07     88.8±1.86ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     58.1±1.81ms        ? ?/sec    1.04     60.7±1.97ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00     90.9±1.09ms        ? ?/sec    1.01     91.8±1.02ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    148.1±5.42ms        ? ?/sec    1.08    160.2±5.43ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    192.4±3.59ms        ? ?/sec    1.04    200.2±2.27ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    110.5±1.23ms        ? ?/sec    1.04    114.4±1.46ms        ? ?/sec
bundle/bundle@threejs                                               1.00     27.3±0.83ms        ? ?/sec    1.00     27.2±0.61ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     59.4±2.36ms        ? ?/sec    1.09     64.6±1.28ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     79.7±1.32ms        ? ?/sec    1.06     84.6±2.22ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     37.6±0.74ms        ? ?/sec    1.06     39.8±0.37ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    307.0±5.95ms        ? ?/sec    1.01    308.6±3.96ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   689.7±11.35ms        ? ?/sec    1.34   926.9±10.82ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   926.4±10.22ms        ? ?/sec    1.26  1171.6±12.48ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.05   408.1±10.12ms        ? ?/sec    1.00    389.5±3.60ms        ? ?/sec
remapping/remapping                                                 1.02     34.4±0.48ms        ? ?/sec    1.00     33.6±0.26ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     82.4±0.51ms        ? ?/sec    1.05     86.7±0.62ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     70.7±0.87ms        ? ?/sec    1.03     72.8±1.22ms        ? ?/sec
scan/scan@threejs                                                   1.01     19.8±0.64ms        ? ?/sec    1.00     19.6±0.20ms        ? ?/sec
scan/scan@threejs10x                                                1.00    204.0±2.86ms        ? ?/sec    1.02    207.2±1.84ms        ? ?/sec

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1726 will improve performances by 65.31%

Comparing try-next-oxc-2 (3e08d53) with main (b3179e7)

Summary

⚡ 9 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main try-next-oxc-2 Change
⚡ bundle@multi-duplicated-top-level-symbol-minify 289.6 ms 269.2 ms +7.59%
⚡ bundle@multi-duplicated-top-level-symbol-minify-sourcemap 403.3 ms 380.4 ms +6.02%
⚡ bundle@rome-ts-minify 653.5 ms 609.9 ms +7.14%
⚡ bundle@rome-ts-minify-sourcemap 944.6 ms 897.9 ms +5.2%
⚡ bundle@threejs-minify 251.9 ms 232.1 ms +8.54%
⚡ bundle@threejs-minify-sourcemap 389.4 ms 362.4 ms +7.45%
⚡ bundle@threejs10x-minify 4.3 s 2.6 s +65.31%
⚡ bundle@threejs10x-minify-sourcemap 5.8 s 4 s +43.93%
⚡ render-chunk-remapping 695.5 ms 655.7 ms +6.07%

@Dunqing Dunqing mentioned this pull request Jul 25, 2024
Merged
Dunqing added a commit to oxc-project/oxc that referenced this pull request Jul 25, 2024
@Dunqing
fix(semantic): incorrect symbol’s scope_id after var hoisting (#4458)
e4ca06a 
Bug found in rolldown/rolldown#1726
@Dunqing
Copy link
Collaborator Author

Dunqing commented Jul 26, 2024

It still doesn't work. Can you see what's causing it? @hyf0

@hyf0
Copy link
Member

hyf0 commented Jul 26, 2024 •
edited
Loading

I'll take a look later today.

@hyf0 hyf0 force-pushed the try-next-oxc-2 branch from a568b3f to 99d0877 Compare July 26, 2024 05:38
@hyf0 hyf0 force-pushed the try-next-oxc-2 branch from 99d0877 to 6201f44 Compare July 26, 2024 07:20
@hyf0 hyf0 linked an issue Jul 26, 2024 that may be closed by this pull request
Wrong scope of top level bindings #1743
Closed
@Boshen
Copy link
Member

Boshen commented Jul 27, 2024

@Dunqing Feel free to release at anytime if Rolldown is rolling.

@Brooooooklyn Brooooooklyn mentioned this pull request Jul 27, 2024
Merged
@Dunqing Dunqing changed the title test: next oxc version chore: bump oxc to 0.22.1 Jul 28, 2024
@Dunqing Dunqing marked this pull request as ready for review July 28, 2024 02:10
@hyf0 hyf0 enabled auto-merge July 28, 2024 08:46
@hyf0 hyf0 added this pull request to the merge queue Jul 28, 2024
Merged via the queue into main with commit 22d961c Jul 28, 2024
@hyf0 hyf0 deleted the try-next-oxc-2 branch July 28, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

@underfin underfin Awaiting requested review from underfin

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong scope of top level bindings

3 participants

@Dunqing @hyf0 @Boshen