Skip to content

Comments

chore: bump oxc to 0.22.0#1665

Merged
IWANABETHATGUY merged 13 commits intomainfrom
try-next-oxc
Jul 24, 2024
Merged

chore: bump oxc to 0.22.0#1665
IWANABETHATGUY merged 13 commits intomainfrom
try-next-oxc

Conversation

@Dunqing
Copy link
Collaborator

@Dunqing Dunqing commented Jul 19, 2024 •
edited
Loading

Description

Testing the performance gains from oxc

@Dunqing Dunqing marked this pull request as draft July 19, 2024 01:57
@netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 2c4e6c7
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66a04d080ad3f000083c5ce2

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     46.5±1.01ms        ? ?/sec    1.12     52.1±2.51ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     68.0±0.87ms        ? ?/sec    1.07     72.6±0.83ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     86.0±0.83ms        ? ?/sec    1.05     90.5±1.49ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     58.0±0.59ms        ? ?/sec    1.05     61.1±0.92ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00     90.2±0.76ms        ? ?/sec    1.04     94.0±1.51ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    153.4±2.88ms        ? ?/sec    1.07    163.8±2.04ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    199.0±3.42ms        ? ?/sec    1.04    207.1±1.75ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    109.2±0.93ms        ? ?/sec    1.05    114.8±1.92ms        ? ?/sec
bundle/bundle@threejs                                               1.00     26.8±0.29ms        ? ?/sec    1.02     27.4±0.66ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     61.8±2.23ms        ? ?/sec    1.17     72.4±0.84ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     82.7±1.37ms        ? ?/sec    1.11     91.5±1.51ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     38.4±0.58ms        ? ?/sec    1.00     38.5±0.68ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    303.5±2.63ms        ? ?/sec    1.02    309.9±3.75ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    926.0±7.65ms        ? ?/sec    1.00    929.7±8.75ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1160.7±10.85ms        ? ?/sec    1.01  1168.2±10.92ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    386.5±8.69ms        ? ?/sec    1.03    396.8±8.18ms        ? ?/sec
remapping/remapping                                                 1.00     33.8±0.35ms        ? ?/sec    1.01     34.1±0.12ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     86.3±0.47ms        ? ?/sec    1.00     85.8±2.01ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     70.1±0.70ms        ? ?/sec    1.04     73.2±0.97ms        ? ?/sec
scan/scan@threejs                                                   1.00     19.4±0.10ms        ? ?/sec    1.03     20.0±0.51ms        ? ?/sec
scan/scan@threejs10x                                                1.00    201.8±1.79ms        ? ?/sec    1.03    206.8±1.92ms        ? ?/sec

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1665 will improve performances by 13.35%

Comparing try-next-oxc (2c4e6c7) with main (8aad7d0)

Summary

⚡ 16 improvements
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark main try-next-oxc Change
⚡ bundle@multi-duplicated-top-level-symbol 223.8 ms 211.7 ms +5.73%
⚡ bundle@multi-duplicated-top-level-symbol-minify 310.7 ms 288.3 ms +7.78%
⚡ bundle@multi-duplicated-top-level-symbol-minify-sourcemap 425.5 ms 397.9 ms +6.95%
⚡ bundle@rome-ts 475.9 ms 431.2 ms +10.36%
⚡ bundle@rome-ts-minify 712.6 ms 649.4 ms +9.72%
⚡ bundle@rome-ts-minify-sourcemap 1,020.1 ms 935.6 ms +9.04%
⚡ bundle@rome-ts-sourcemap 630.3 ms 577.4 ms +9.15%
⚡ bundle@threejs 157.9 ms 143.9 ms +9.75%
⚡ bundle@threejs-minify 276.3 ms 249.5 ms +10.76%
⚡ bundle@threejs-minify-sourcemap 411.9 ms 386.4 ms +6.61%
⚡ bundle@threejs10x 1.7 s 1.5 s +8.71%
⚡ bundle@threejs10x-minify 4.6 s 4.3 s +5.12%
⚡ bundle@threejs10x-sourcemap 2.3 s 2.2 s +6.06%
⚡ scan@rome-ts 392.5 ms 347.5 ms +12.96%
⚡ scan@threejs 115.9 ms 102.3 ms +13.35%
⚡ scan@threejs10x 1.2 s 1 s +12.33%

@Dunqing Dunqing changed the title perf: testing oxc performance chore: bump oxc to 0.20.0 Jul 23, 2024
@Dunqing Dunqing changed the title chore: bump oxc to 0.20.0 chore: bump oxc to 0.22.0 Jul 23, 2024
@Dunqing Dunqing mentioned this pull request Jul 23, 2024
Merged
@hyf0
Copy link
Member

hyf0 commented Jul 23, 2024

Looks fine to merge.

@IWANABETHATGUY
Copy link
Member

IWANABETHATGUY commented Jul 23, 2024 •
edited
Loading

oxc release is stuck due to cargo doesn't support dev cyclic dependencies rust-lang/cargo#4242

@hyf0
Copy link
Member

hyf0 commented Jul 23, 2024

oxc release is stuck due to cargo doesn't support dev cyclic dependencies rust-lang/cargo#4242

Rolldown probably has the same problem. Good for now we don't publish rolldown to crates.io. :)

@Dunqing Dunqing marked this pull request as ready for review July 24, 2024 01:22
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 3ddad4a Jul 24, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the try-next-oxc branch July 24, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@hyf0 hyf0 Awaiting requested review from hyf0

@underfin underfin Awaiting requested review from underfin

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dunqing @hyf0 @IWANABETHATGUY