Skip to content

fix: ensure chunk order#1135

Merged
hyf0 merged 1 commit intomainfrom
05-16-fix_ensure_chunk_order
May 15, 2024
Merged

fix: ensure chunk order#1135
hyf0 merged 1 commit intomainfrom
05-16-fix_ensure_chunk_order

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented May 15, 2024 •
edited
Loading

Description

Closes #1011
Fixes #122.

We follow the rollup's behavior. See details in #1011.

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented May 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link
Copy Markdown

netlify bot commented May 15, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b79f4ea
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66450b8c0dbd310008a1d739

@codecov
Copy link
Copy Markdown

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (5eb66a2) to head (b79f4ea).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
+ Coverage   86.64%   86.69%   +0.05%     
==========================================
  Files         121      121              
  Lines        5929     5954      +25     
==========================================
+ Hits         5137     5162      +25     
  Misses        792      792

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 15, 2024

Benchmarks Rust

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     28.9±0.27ms        ? ?/sec    1.00     28.8±0.29ms        ? ?/sec
rolldown benchmark/threejs-scan            1.01     20.5±0.41ms        ? ?/sec    1.00     20.3±0.33ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.02     40.4±1.96ms        ? ?/sec    1.00     39.6±0.68ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    307.6±2.35ms        ? ?/sec    1.00    308.7±2.71ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.01    204.2±2.01ms        ? ?/sec    1.00    202.5±2.50ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    440.5±9.34ms        ? ?/sec    1.01    445.0±9.13ms        ? ?/sec

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 15, 2024

CodSpeed Performance Report

Merging #1135 will not alter performance

Comparing 05-16-fix_ensure_chunk_order (b79f4ea) with main (5eb66a2)

Summary

✅ 6 untouched benchmarks

@hyf0 hyf0 merged commit 975e884 into main May 15, 2024
@hyf0 hyf0 deleted the 05-16-fix_ensure_chunk_order branch May 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure chunk execution order are correct

1 participant

@hyf0