chore(deps): upgrade oxc to 0.141.0#10373
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Contributor
Author
|
@codex review |
camc314
marked this pull request as ready for review
July 21, 2026 21:41
camc314
requested review from
IWANABETHATGUY,
hyfdev and
shulaoda
as code owners
July 21, 2026 21:41
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa9c7691a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Dunqing
reviewed
Jul 22, 2026
…rget
Normalizing an omitted `transform.target` to `esnext` made the RegExp
constructor throw-analysis assume every runtime feature is supported,
so feature-detection probes like
`try { new RegExp('\p{Ll}', 'u') } catch { loadPolyfill() }` became
droppable and could break on engines without the feature — the exact
pattern oxc's target-aware analysis exists to protect
(oxc-project/oxc#18050).
Keep the omitted case as an empty `EngineTargets` instead: oxc treats
`is_any_target()` as "assume no runtime feature support", which is
behaviorally identical to providing no targets, so no separate
explicitness flag is needed. An explicit `transform.target` still opts
into feature-aware analysis through `StmtEvalAnalyzer::engine_targets`.
shulaoda
approved these changes
Jul 22, 2026
IWANABETHATGUY
approved these changes
Jul 22, 2026
Dunqing
approved these changes
Jul 22, 2026
sapphi-red
approved these changes
Jul 22, 2026
Brooooooklyn
added a commit
that referenced
this pull request
Jul 22, 2026
The oxc-0.141 merge auto-merged pnpm-workspace.yaml's catalog bumps (@oxc-project/runtime, @oxc-project/types, oxc-parser, oxc-transform: 0.140.0 -> 0.141.0, from #10373) but pnpm-lock.yaml was resolved to the branch side (--ours), leaving its catalog snapshot at 0.140.0. That mismatch failed `vp install` in CI with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH before any build ran (all 10 red jobs shared this one cause). Regenerated with `pnpm install --lockfile-only` (pnpm 11.9.0, matches CI). Diff is symmetric 192/192, exclusively oxc 0.140.0 -> 0.141.0 (catalog + platform bindings + integrity); emnapi-v2 override, the two @napi-rs patchedDependencies, and the napi-async-runtime alpha pins are untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01T34fMrYCf2V13Mg8BKmnda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
fixes #10279 — RegExp feature-detection probes are no longer dropped: oxc's side-effect analysis is now target-aware, and rolldown stays conservative when no
transform.targetis set (verified against the issue's repro in both dce-only and full-minify modes)fixes #9272 — unreachable mutually-recursive functions are now removed by chunk-level DCE (oxc-project/oxc#24125); verified the issue's repro now produces its expected output