feat: support import.meta.ROLLDOWN_FILE_URL_*#10296
Merged
graphite-app[bot] merged 1 commit intoJul 17, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
sapphi-red
marked this pull request as ready for review
July 15, 2026 11:31
sapphi-red
requested review from
IWANABETHATGUY,
hyfdev and
shulaoda
as code owners
July 15, 2026 11:31
Merging this PR will not alter performance
Comparing 
Footnotes
|
sapphi-red
changed the base branch from
07-10-feat_implement_resolvefileurl_plugin_hook
to
graphite-base/10296
July 16, 2026 08:55
sapphi-red
force-pushed
the
07-15-feat_support_import.meta.rolldown_file_url__
branch
from
July 16, 2026 11:29
42cb429 to
d443874
Compare
sapphi-red
force-pushed
the
graphite-base/10296
branch
from
July 16, 2026 11:29
5f32fc5 to
ada3be7
Compare
sapphi-red
changed the base branch from
graphite-base/10296
to
07-10-feat_implement_resolvefileurl_plugin_hook
July 16, 2026 11:29
hyfdev
approved these changes
Jul 16, 2026
hyfdev
left a comment
hyfdev
left a comment
Member
There was a problem hiding this comment.
The implementation looks good. I verified both prefixes across static, computed, and optional member access, tree-shaking, resolveFileUrl hook dispatch, IIFE/UMD fallback warnings, and unknown-reference diagnostics. The focused fixtures, Rust tests, local build, and relevant CI pass.
A few non-blocking nits:
- For a legacy
ROLLUP_FILE_URL_*reference, the IIFE/UMD warning label currently saysROLLDOWN_FILE_URL_*. Neutral wording such as “This file URL reference...” would accurately cover both aliases. - The compatibility tip in
file-urls.mdsaysROLLUP_FILE_URL_referenceIdis an alias of itself; the second one should beROLLDOWN_FILE_URL_referenceId. - The first paragraph of the
resolveFileUrlhook documentation still presentsROLLUP_FILE_URL_referenceIdas the default, while the next paragraph usesROLLDOWN_FILE_URL_referenceId. internal-docs/ast-mutation/implementation.mdstill references the renamedEcmaView::rollup_file_url_referencesfield. It should userolldown_file_url_referencesand mention that both prefixes enter this table.
sapphi-red
force-pushed
the
07-10-feat_implement_resolvefileurl_plugin_hook
branch
from
July 17, 2026 03:48
ada3be7 to
ba62cde
Compare
sapphi-red
force-pushed
the
07-15-feat_support_import.meta.rolldown_file_url__
branch
from
July 17, 2026 03:48
d443874 to
3b64dfc
Compare
shulaoda
approved these changes
Jul 17, 2026
sapphi-red
force-pushed
the
07-10-feat_implement_resolvefileurl_plugin_hook
branch
from
July 17, 2026 03:53
ba62cde to
072d54e
Compare
sapphi-red
force-pushed
the
07-15-feat_support_import.meta.rolldown_file_url__
branch
from
July 17, 2026 03:53
3b64dfc to
09b3d1e
Compare
Member
Merge activity
|
Support `import.meta.ROLLDOWN_FILE_URL_*` as an alias of `import.meta.ROLLUP_FILE_URL_*` to make it less confusing.
graphite-app
Bot
force-pushed
the
07-10-feat_implement_resolvefileurl_plugin_hook
branch
from
July 17, 2026 06:05
072d54e to
c31bc56
Compare
graphite-app
Bot
force-pushed
the
07-15-feat_support_import.meta.rolldown_file_url__
branch
from
July 17, 2026 06:06
09b3d1e to
afac8ae
Compare
Base automatically changed from
07-10-feat_implement_resolvefileurl_plugin_hook
to
main
July 17, 2026 06:10
graphite-app
Bot
deleted the
07-15-feat_support_import.meta.rolldown_file_url__
branch
July 17, 2026 06:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
import.meta.ROLLDOWN_FILE_URL_*as an alias ofimport.meta.ROLLUP_FILE_URL_*to make it less confusing.