fix(dev): clear tsconfig caches for bare full builds#10276
Merged
graphite-app[bot] merged 1 commit intoJul 15, 2026
Merged
Conversation
shulaoda
requested review from
IWANABETHATGUY,
h-a-n-a and
hyfdev
as code owners
July 14, 2026 11:59
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
h-a-n-a
approved these changes
Jul 14, 2026
Member
Author
Merge activity
|
Closes #10269. The tsconfig detection in `BundlingTask` checks `changed_files()` against the known tsconfig paths, but a bare `TaskInput::FullBuild` carries no changed-file list by construction. Three coordinator paths produce such inputs and erase the file names on the way: `handle_file_changes` in the `FullBuildFailed` state, `trigger_full_build` (which also clears queued tasks), and `merge_with` where `FullBuild` absorbs other inputs. On those paths "did a tsconfig change" cannot be answered, so the caches were never cleared and the full scan reused the stale tsconfig. In the failure-recovery case this locks the dev server up for good: every edit in `FullBuildFailed` becomes a bare `FullBuild`, each one rebuilds with the cached tsconfig, fails again, and returns to `FullBuildFailed`, even though the file on disk has long been fixed. The fix clears the resolver and tsconfig caches for every input with `requires_full_rebuild()`, alongside the existing detection for inputs that still carry their file list. Full builds only happen at startup, on restart, and in failure recovery, so the extra clears are cheap. The `FullReload` client notification still fires only when a tsconfig change is positively detected. Keeping the changed-file information alive through the three coordinator paths would be the precise alternative, but that is a much larger change to the state machine for no practical gain. The regression fixture reproduces the erasure path: the initial build fails on an unresolved import, and the recovery step fixes the import and edits the tsconfig in the same batch, which the `FullBuildFailed` state folds into a bare `FullBuild`. With the fix the recovered output uses the new tsconfig (`useDefineForClassFields` flips the emitted class field), and without it the output keeps the stale semantics, which was verified by temporarily reverting the fix.
graphite-app
Bot
force-pushed
the
07-14-fix_dev_clear_tsconfig_caches_for_bare_full_builds
branch
from
July 15, 2026 02:05
5e55eb8 to
49fa4d6
Compare
graphite-app
Bot
deleted the
07-14-fix_dev_clear_tsconfig_caches_for_bare_full_builds
branch
July 15, 2026 02:10
Merged
shulaoda
added a commit
that referenced
this pull request
Jul 15, 2026
## [1.2.0] - 2026-07-15 ### 🚀 Features - dev: skip shipping factories for newly imported top-level modules (#10223) by @h-a-n-a - dev: per-client ship map for HMR patch sizing (#10208) by @h-a-n-a - dev: client-side HMR (#10164) by @h-a-n-a - dev: send a full-reload update to clients when a tsconfig changes (#10262) by @shulaoda - treat `import.meta['url']` and `import.meta['ROLLUP_FILE_URL_*']` as side-effect free (#10267) by @sapphi-red - rewrite `import.meta['url']` (#10251) by @sapphi-red - add `FILE_NOT_FOUND` error (#10220) by @sapphi-red - treat `import.meta.ROLLUP_FILE_URL_*` as side-effect free (#10217) by @sapphi-red ### 🐛 Bug Fixes - sourcemap: preserve unmapped boundaries during composition (#10254) by @hyfdev - `[format]` in `*FileNames` option for ESM format should be `es` instead of `esm` (#10214) by @sapphi-red - sourcemap: preserve coarse mappings during composition (#10249) by @hyfdev - rolldown_plugin_vite_import_glob: support tsconfig paths with `import.meta.glob` (#10167) by @sapphi-red - dev: clear tsconfig caches for bare full builds (#10276) by @shulaoda - dev: force a full rebuild when a tsconfig changes (#10261) by @shulaoda - treat rooted drive-less module ids as absolute in preserveModules naming (#10235) by @IWANABETHATGUY - watch: rebuild when tsconfig files change (#10258) by @shulaoda - watch: drop tsconfig-merged transform options on each rebuild (#10257) by @shulaoda - incorrect `EMPTY_IMPORT_META` warning for `import.meta.ROLLUP_FILE_URL_*` for CJS output (#10221) by @sapphi-red - deconflict: rename CJS locals shadowing wrapped-ESM namespace objects (#9970) by @IWANABETHATGUY - rolldown: drop the unused runtime module after entry-level external flattening (#10237) by @IWANABETHATGUY - rolldown: re-propagate has_dynamic_exports to transitive star importers (#10239) by @IWANABETHATGUY - tree-shaking: tree-shake destructured dynamic import namespace bindings (#10213) by @logaretm - s390x: use json-escape-simd 3.1.1 for big-endian JSON escaping fix (#10211) by @satyamg1620 ### 🚜 Refactor - dev: move full-reload to client side (#10207) by @h-a-n-a - readability follow-ups to the ReplaceWith migration (#10286) by @IWANABETHATGUY - replace take_in-then-write-back with ReplaceWith and by-value moves (#10285) by @Boshen - share the main resolver's cache with the transformer's tsconfig lookups (#10205) by @shulaoda - rolldown: extract the ns star-external __reExport emission rule into LinkingMetadata (#10238) by @IWANABETHATGUY - rolldown: unify link/generate diagnostics into a Diagnostics accumulator (#10234) by @IWANABETHATGUY - sourcemap_filenames: drop dead sourcemap-filename plumbing (#10189) by @IWANABETHATGUY - extract external import symbol merging into a method (#10224) by @IWANABETHATGUY - rolldown: skip CJS namespace merging under strict execution order (#10203) by @hyfdev - resolve the manual tsconfig per file instead of once at startup (#10200) by @shulaoda - rolldown: route interop ESM init emission through a shared init-target view (#10202) by @hyfdev - rolldown: collapse vestigial wrap-kind state and share chunk sort helper (#10201) by @hyfdev ### 📚 Documentation - show plugin kinds in JSDoc and each hook's description (#10218) by @sapphi-red - add an explanation about removing imports from external modules without any messages (#10215) by @sapphi-red ### ⚡ Performance - sourcemap: owned merge in SourceJoiner::join (4005->5 allocs/chunk) (#10250) by @Boshen - avoid redundant sourcemap string copies in collapse and minify paths (#10093) by @Boshen ### 🧪 Testing - code-splitting: establish strict-order review baselines (#10287) by @hyfdev - dev: add hot API test cases (#10181) by @h-a-n-a - code-splitting: normalize strict execution order variants (#10277) by @hyfdev - code-splitting: harden strict execution order coverage (#10252) by @hyfdev - code-splitting: add strict execution order regressions (#10253) by @hyfdev ### ⚙️ Miscellaneous Tasks - deps: update github actions (#10241) by @renovate[bot] - deps: update oxc to 0.140.0 (#10274) by @shulaoda - update Yunfei's GitHub username (#10275) by @hyfdev - deps: update napi (#10260) by @renovate[bot] - deps: update test262 submodule for tests (#10266) by @rolldown-guard[bot] - deps: update dependency vite-plus to v0.2.4 (#10256) by @renovate[bot] - deps: update napi (#10240) by @renovate[bot] - deps: update oxc resolver to v11.24.2 (#10245) by @renovate[bot] - deps: update rust crates (#10244) by @renovate[bot] - disable Renovate updates for idna_adapter (#10248) by @shulaoda - deps: update oxc resolver to v11.24.1 (#10232) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v8.1.1 (#10233) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.27.0 (#10206) by @renovate[bot] - deps: upgrade sugar_path to v3 (#10230) by @hyfdev - add `dist-*` to `.gitignore` in sourcemap-filenames/hash-final-content fixture (#10216) by @sapphi-red - deps: update dependency rust to v1.97.0 (#10209) by @renovate[bot] ### ❤️ New Contributors * @satyamg1620 made their first contribution in [#10211](#10211) Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10269.
The tsconfig detection in
BundlingTaskcheckschanged_files()against the known tsconfig paths, but a bareTaskInput::FullBuildcarries no changed-file list by construction. Three coordinator paths produce such inputs and erase the file names on the way:handle_file_changesin theFullBuildFailedstate,trigger_full_build(which also clears queued tasks), andmerge_withwhereFullBuildabsorbs other inputs. On those paths "did a tsconfig change" cannot be answered, so the caches were never cleared and the full scan reused the stale tsconfig. In the failure-recovery case this locks the dev server up for good: every edit inFullBuildFailedbecomes a bareFullBuild, each one rebuilds with the cached tsconfig, fails again, and returns toFullBuildFailed, even though the file on disk has long been fixed.The fix clears the resolver and tsconfig caches for every input with
requires_full_rebuild(), alongside the existing detection for inputs that still carry their file list. Full builds only happen at startup, on restart, and in failure recovery, so the extra clears are cheap. TheFullReloadclient notification still fires only when a tsconfig change is positively detected. Keeping the changed-file information alive through the three coordinator paths would be the precise alternative, but that is a much larger change to the state machine for no practical gain.The regression fixture reproduces the erasure path: the initial build fails on an unresolved import, and the recovery step fixes the import and edits the tsconfig in the same batch, which the
FullBuildFailedstate folds into a bareFullBuild. With the fix the recovered output uses the new tsconfig (useDefineForClassFieldsflips the emitted class field), and without it the output keeps the stale semantics, which was verified by temporarily reverting the fix.