feat(dev): send a full-reload update to clients when a tsconfig changes#10262
Merged
graphite-app[bot] merged 1 commit intoJul 14, 2026
Conversation
This was referenced Jul 13, 2026
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
shulaoda
marked this pull request as ready for review
July 13, 2026 13:42
shulaoda
requested review from
IWANABETHATGUY,
h-a-n-a and
hyfdev
as code owners
July 13, 2026 13:42
Merging this PR will not alter performance
Comparing 
Footnotes
|
Member
Author
Merge activity
|
h-a-n-a
approved these changes
Jul 14, 2026
shulaoda
force-pushed
the
07-13-fix_dev_force_a_full_rebuild_when_a_tsconfig_changes
branch
from
July 14, 2026 06:37
39f5019 to
a0be807
Compare
shulaoda
force-pushed
the
07-13-feat_dev_send_a_full-reload_update_to_clients_when_a_tsconfig_changes
branch
from
July 14, 2026 06:37
3f44d6f to
59b4740
Compare
graphite-app
Bot
force-pushed
the
07-13-fix_dev_force_a_full_rebuild_when_a_tsconfig_changes
branch
from
July 14, 2026 06:51
a0be807 to
2e8179b
Compare
graphite-app
Bot
force-pushed
the
07-13-feat_dev_send_a_full-reload_update_to_clients_when_a_tsconfig_changes
branch
from
July 14, 2026 06:51
59b4740 to
cd261c1
Compare
graphite-app
Bot
force-pushed
the
07-13-fix_dev_force_a_full_rebuild_when_a_tsconfig_changes
branch
2 times, most recently
from
July 14, 2026 07:07
d97d9b5 to
4a8a396
Compare
graphite-app
Bot
force-pushed
the
07-13-feat_dev_send_a_full-reload_update_to_clients_when_a_tsconfig_changes
branch
from
July 14, 2026 07:07
cd261c1 to
4c3992d
Compare
…es (#10262) Part of #9598, on top of the full-rebuild PR. This is the last piece of the tsconfig watching work on the rolldown side. The previous PR makes the dev engine rebuild fully with fresh caches when a known tsconfig changes, but connected clients were not told anything, so the browser kept running the old bundle until a manual refresh. The bundling task now sends a `FullReload` update (reason: "tsconfig change") to every client before the rebuild, matching the ordering of the existing full-reload flow where updates are emitted first and the dev server's build-stable machinery gates the follow-up fetch. Two HMR fixtures cover both sides that a tsconfig governs. `tsconfig_change` flips `useDefineForClassFields` and the rebuilt output switches from a constructor assignment to a class field declaration. `tsconfig_paths_change` remaps `compilerOptions.paths` so the same import resolves to a different file, which proves the shared resolver cache is really cleared, since a stale cache would keep resolving the old target. Both snapshots record the full-reload update with its reason and the rebuilt output. The test harness additionally asserts that the changed tsconfig is present in the watched files and that the incremental scan state matches a fresh full build after each step. Remaining known limits of the tsconfig watching work, tracked on #9598: `extends` chains wait on oxc-resolver reporting the loaded files, creating a brand-new tsconfig.json cannot be watched by the per-file watcher, and a solution-style root tsconfig that only routes to references is not reported by `find_tsconfig`. <!-- - What is this PR solving? Write a clear and concise description. - Reference the issues it solves (e.g. `fixes #123`). - What other alternatives have you explored? - Are there any parts you think require more attention from reviewers? Also, please make sure you do the following: - Read the Contributing Guidelines at https://rolldown.rs/contribution-guide/. - Check that there isn't already a PR that solves the problem the same way. If you find a duplicate, please help us review it. - Update the corresponding documentation if needed. - Include relevant tests that fail without this PR but pass with it. If the tests are not included, explain why. Thank you for contributing to Rolldown! -->
graphite-app
Bot
force-pushed
the
07-13-fix_dev_force_a_full_rebuild_when_a_tsconfig_changes
branch
from
July 14, 2026 07:45
4a8a396 to
9f4030d
Compare
graphite-app
Bot
force-pushed
the
07-13-feat_dev_send_a_full-reload_update_to_clients_when_a_tsconfig_changes
branch
from
July 14, 2026 07:45
4c3992d to
654075e
Compare
Base automatically changed from
07-13-fix_dev_force_a_full_rebuild_when_a_tsconfig_changes
to
main
July 14, 2026 07:49
graphite-app
Bot
deleted the
07-13-feat_dev_send_a_full-reload_update_to_clients_when_a_tsconfig_changes
branch
July 14, 2026 07:50
Merged
shulaoda
added a commit
that referenced
this pull request
Jul 15, 2026
## [1.2.0] - 2026-07-15 ### 🚀 Features - dev: skip shipping factories for newly imported top-level modules (#10223) by @h-a-n-a - dev: per-client ship map for HMR patch sizing (#10208) by @h-a-n-a - dev: client-side HMR (#10164) by @h-a-n-a - dev: send a full-reload update to clients when a tsconfig changes (#10262) by @shulaoda - treat `import.meta['url']` and `import.meta['ROLLUP_FILE_URL_*']` as side-effect free (#10267) by @sapphi-red - rewrite `import.meta['url']` (#10251) by @sapphi-red - add `FILE_NOT_FOUND` error (#10220) by @sapphi-red - treat `import.meta.ROLLUP_FILE_URL_*` as side-effect free (#10217) by @sapphi-red ### 🐛 Bug Fixes - sourcemap: preserve unmapped boundaries during composition (#10254) by @hyfdev - `[format]` in `*FileNames` option for ESM format should be `es` instead of `esm` (#10214) by @sapphi-red - sourcemap: preserve coarse mappings during composition (#10249) by @hyfdev - rolldown_plugin_vite_import_glob: support tsconfig paths with `import.meta.glob` (#10167) by @sapphi-red - dev: clear tsconfig caches for bare full builds (#10276) by @shulaoda - dev: force a full rebuild when a tsconfig changes (#10261) by @shulaoda - treat rooted drive-less module ids as absolute in preserveModules naming (#10235) by @IWANABETHATGUY - watch: rebuild when tsconfig files change (#10258) by @shulaoda - watch: drop tsconfig-merged transform options on each rebuild (#10257) by @shulaoda - incorrect `EMPTY_IMPORT_META` warning for `import.meta.ROLLUP_FILE_URL_*` for CJS output (#10221) by @sapphi-red - deconflict: rename CJS locals shadowing wrapped-ESM namespace objects (#9970) by @IWANABETHATGUY - rolldown: drop the unused runtime module after entry-level external flattening (#10237) by @IWANABETHATGUY - rolldown: re-propagate has_dynamic_exports to transitive star importers (#10239) by @IWANABETHATGUY - tree-shaking: tree-shake destructured dynamic import namespace bindings (#10213) by @logaretm - s390x: use json-escape-simd 3.1.1 for big-endian JSON escaping fix (#10211) by @satyamg1620 ### 🚜 Refactor - dev: move full-reload to client side (#10207) by @h-a-n-a - readability follow-ups to the ReplaceWith migration (#10286) by @IWANABETHATGUY - replace take_in-then-write-back with ReplaceWith and by-value moves (#10285) by @Boshen - share the main resolver's cache with the transformer's tsconfig lookups (#10205) by @shulaoda - rolldown: extract the ns star-external __reExport emission rule into LinkingMetadata (#10238) by @IWANABETHATGUY - rolldown: unify link/generate diagnostics into a Diagnostics accumulator (#10234) by @IWANABETHATGUY - sourcemap_filenames: drop dead sourcemap-filename plumbing (#10189) by @IWANABETHATGUY - extract external import symbol merging into a method (#10224) by @IWANABETHATGUY - rolldown: skip CJS namespace merging under strict execution order (#10203) by @hyfdev - resolve the manual tsconfig per file instead of once at startup (#10200) by @shulaoda - rolldown: route interop ESM init emission through a shared init-target view (#10202) by @hyfdev - rolldown: collapse vestigial wrap-kind state and share chunk sort helper (#10201) by @hyfdev ### 📚 Documentation - show plugin kinds in JSDoc and each hook's description (#10218) by @sapphi-red - add an explanation about removing imports from external modules without any messages (#10215) by @sapphi-red ### ⚡ Performance - sourcemap: owned merge in SourceJoiner::join (4005->5 allocs/chunk) (#10250) by @Boshen - avoid redundant sourcemap string copies in collapse and minify paths (#10093) by @Boshen ### 🧪 Testing - code-splitting: establish strict-order review baselines (#10287) by @hyfdev - dev: add hot API test cases (#10181) by @h-a-n-a - code-splitting: normalize strict execution order variants (#10277) by @hyfdev - code-splitting: harden strict execution order coverage (#10252) by @hyfdev - code-splitting: add strict execution order regressions (#10253) by @hyfdev ### ⚙️ Miscellaneous Tasks - deps: update github actions (#10241) by @renovate[bot] - deps: update oxc to 0.140.0 (#10274) by @shulaoda - update Yunfei's GitHub username (#10275) by @hyfdev - deps: update napi (#10260) by @renovate[bot] - deps: update test262 submodule for tests (#10266) by @rolldown-guard[bot] - deps: update dependency vite-plus to v0.2.4 (#10256) by @renovate[bot] - deps: update napi (#10240) by @renovate[bot] - deps: update oxc resolver to v11.24.2 (#10245) by @renovate[bot] - deps: update rust crates (#10244) by @renovate[bot] - disable Renovate updates for idna_adapter (#10248) by @shulaoda - deps: update oxc resolver to v11.24.1 (#10232) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v8.1.1 (#10233) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.27.0 (#10206) by @renovate[bot] - deps: upgrade sugar_path to v3 (#10230) by @hyfdev - add `dist-*` to `.gitignore` in sourcemap-filenames/hash-final-content fixture (#10216) by @sapphi-red - deps: update dependency rust to v1.97.0 (#10209) by @renovate[bot] ### ❤️ New Contributors * @satyamg1620 made their first contribution in [#10211](#10211) Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9598, on top of the full-rebuild PR. This is the last piece of the tsconfig watching work on the rolldown side.
The previous PR makes the dev engine rebuild fully with fresh caches when a known tsconfig changes, but connected clients were not told anything, so the browser kept running the old bundle until a manual refresh. The bundling task now sends a
FullReloadupdate (reason: "tsconfig change") to every client before the rebuild, matching the ordering of the existing full-reload flow where updates are emitted first and the dev server's build-stable machinery gates the follow-up fetch.Two HMR fixtures cover both sides that a tsconfig governs.
tsconfig_changeflipsuseDefineForClassFieldsand the rebuilt output switches from a constructor assignment to a class field declaration.tsconfig_paths_changeremapscompilerOptions.pathsso the same import resolves to a different file, which proves the shared resolver cache is really cleared, since a stale cache would keep resolving the old target. Both snapshots record the full-reload update with its reason and the rebuilt output. The test harness additionally asserts that the changed tsconfig is present in the watched files and that the incremental scan state matches a fresh full build after each step.Remaining known limits of the tsconfig watching work, tracked on #9598:
extendschains wait on oxc-resolver reporting the loaded files, creating a brand-new tsconfig.json cannot be watched by the per-file watcher, and a solution-style root tsconfig that only routes to references is not reported byfind_tsconfig.