Skip to content

feat(dev): skip shipping factories for newly imported top-level modules#10223

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules
Jul 15, 2026
Merged

feat(dev): skip shipping factories for newly imported top-level modules#10223
graphite-app[bot] merged 1 commit into
mainfrom
07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules

Conversation

@h-a-n-a

@h-a-n-a h-a-n-a commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

For full design and principles, please refer to #10164 (comment).

The dev server tracks which module factories it has shipped per client in #10208. But modules that the entry chunk evaluated at top level never in the ship map. A lazy compile that subtracts only the ship man therefor re-ships factories the client already holds, which causes a size bloat in lazy-compilation chunks.

This PR introduces a second per-client record - the top_level_evaluated map. This map contains the statically evaluated modules so that these modules are not shipped as factories in lazy compilation chunks again when the factories are not changed and only their exports are needed.

h-a-n-a commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@h-a-n-a
h-a-n-a force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from bd57fc6 to 7665d2f Compare July 10, 2026 17:15
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch 2 times, most recently from 3c9b031 to 945b89c Compare July 13, 2026 10:24
@h-a-n-a
h-a-n-a force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from 7665d2f to 372cedb Compare July 13, 2026 10:24
@h-a-n-a
h-a-n-a marked this pull request as ready for review July 14, 2026 05:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 372cedb996

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/rolldown/src/bundler/impl_bundler_hmr.rs
@codspeed-hq

codspeed-hq Bot commented Jul 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 7 untouched benchmarks
⏩ 10 skipped benchmarks1


Comparing 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules (a34f8df) with 07-09-refactor_dev_move_full-reload_to_client_side (8a48270)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on 07-09-refactor_dev_move_full-reload_to_client_side (8baa0fe) during the generation of this report, so 1cb732b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@h-a-n-a
h-a-n-a force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from 372cedb to f7248a0 Compare July 14, 2026 13:52
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch 2 times, most recently from 7bd246f to d362549 Compare July 15, 2026 03:08
@h-a-n-a
h-a-n-a force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from f7248a0 to 24af7ca Compare July 15, 2026 03:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24af7ca60d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/rolldown_dev/src/types/client_session.rs
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from d362549 to 91ac23a Compare July 15, 2026 04:08
@h-a-n-a
h-a-n-a force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from 24af7ca to 96e7872 Compare July 15, 2026 04:08
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from 91ac23a to c6aa5bc Compare July 15, 2026 05:01
@h-a-n-a
h-a-n-a force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch 2 times, most recently from 7b64a5c to d983037 Compare July 15, 2026 06:17
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from c6aa5bc to ec2a8f7 Compare July 15, 2026 06:17
@h-a-n-a
h-a-n-a force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from d983037 to a99ebc1 Compare July 15, 2026 06:41
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from ec2a8f7 to 8a48270 Compare July 15, 2026 06:41
@h-a-n-a
h-a-n-a force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from a99ebc1 to a34f8df Compare July 15, 2026 07:13
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from 8a48270 to 8baa0fe Compare July 15, 2026 07:13
@graphite-app

graphite-app Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Merge activity

@graphite-app
graphite-app Bot changed the base branch from 07-09-refactor_dev_move_full-reload_to_client_side to graphite-base/10223 July 15, 2026 07:31
graphite-app Bot pushed a commit that referenced this pull request Jul 15, 2026
…es (#10223)

<!--
- What is this PR solving? Write a clear and concise description.
- Reference the issues it solves (e.g. `fixes #123`).
- What other alternatives have you explored?
- Are there any parts you think require more attention from reviewers?

Also, please make sure you do the following:

- Read the Contributing Guidelines at https://rolldown.rs/contribution-guide/.
- Check that there isn't already a PR that solves the problem the same way. If you find a duplicate, please help us review it.
- Update the corresponding documentation if needed.
- Include relevant tests that fail without this PR but pass with it. If the tests are not included, explain why.

Thank you for contributing to Rolldown!
-->

## Summary

For full design and principles, please refer to #10164 (comment).

The dev server tracks which module factories it has shipped per client in #10208. But modules that the entry chunk evaluated at top level never in the ship map. A lazy compile that subtracts only the ship man therefor re-ships factories the client already holds, which causes a size bloat in lazy-compilation chunks.

This PR introduces a second per-client record - the `top_level_evaluated` map. This map contains the statically evaluated modules so that these modules are not shipped as factories in lazy compilation chunks again when the factories are not changed and only their exports are needed.
@graphite-app
graphite-app Bot force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from a34f8df to 603151d Compare July 15, 2026 07:38
@graphite-app
graphite-app Bot changed the base branch from graphite-base/10223 to 07-09-refactor_dev_move_full-reload_to_client_side July 15, 2026 07:39
Base automatically changed from 07-09-refactor_dev_move_full-reload_to_client_side to main July 15, 2026 07:42

@hyfdev hyfdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One important correctness issue.

Comment thread crates/rolldown_dev/src/dev_engine.rs

@hyfdev hyfdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the important correctness follow-up noted in the review.

…es (#10223)

<!--
- What is this PR solving? Write a clear and concise description.
- Reference the issues it solves (e.g. `fixes #123`).
- What other alternatives have you explored?
- Are there any parts you think require more attention from reviewers?

Also, please make sure you do the following:

- Read the Contributing Guidelines at https://rolldown.rs/contribution-guide/.
- Check that there isn't already a PR that solves the problem the same way. If you find a duplicate, please help us review it.
- Update the corresponding documentation if needed.
- Include relevant tests that fail without this PR but pass with it. If the tests are not included, explain why.

Thank you for contributing to Rolldown!
-->

## Summary

For full design and principles, please refer to #10164 (comment).

The dev server tracks which module factories it has shipped per client in #10208. But modules that the entry chunk evaluated at top level never in the ship map. A lazy compile that subtracts only the ship man therefor re-ships factories the client already holds, which causes a size bloat in lazy-compilation chunks.

This PR introduces a second per-client record - the `top_level_evaluated` map. This map contains the statically evaluated modules so that these modules are not shipped as factories in lazy compilation chunks again when the factories are not changed and only their exports are needed.
@graphite-app
graphite-app Bot force-pushed the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch from 603151d to 1d3fb15 Compare July 15, 2026 08:06
@netlify

netlify Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 1d3fb15
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6a573f8a2f3aa6000845661e
😎 Deploy Preview https://deploy-preview-10223--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@graphite-app
graphite-app Bot merged commit 1d3fb15 into main Jul 15, 2026
33 of 34 checks passed
@graphite-app
graphite-app Bot deleted the 07-10-feat_dev_skip_shipping_factories_for_newly_imported_top-level_modules branch July 15, 2026 08:13
@rolldown-guard rolldown-guard Bot mentioned this pull request Jul 15, 2026
shulaoda added a commit that referenced this pull request Jul 15, 2026
## [1.2.0] - 2026-07-15

### 🚀 Features

- dev: skip shipping factories for newly imported top-level modules (#10223) by @h-a-n-a
- dev: per-client ship map for HMR patch sizing (#10208) by @h-a-n-a
- dev: client-side HMR (#10164) by @h-a-n-a
- dev: send a full-reload update to clients when a tsconfig changes (#10262) by @shulaoda
- treat `import.meta['url']` and `import.meta['ROLLUP_FILE_URL_*']` as side-effect free (#10267) by @sapphi-red
- rewrite `import.meta['url']` (#10251) by @sapphi-red
- add `FILE_NOT_FOUND` error (#10220) by @sapphi-red
- treat `import.meta.ROLLUP_FILE_URL_*` as side-effect free (#10217) by @sapphi-red

### 🐛 Bug Fixes

- sourcemap: preserve unmapped boundaries during composition (#10254) by @hyfdev
- `[format]` in `*FileNames` option for ESM format should be `es` instead of `esm` (#10214) by @sapphi-red
- sourcemap: preserve coarse mappings during composition (#10249) by @hyfdev
- rolldown_plugin_vite_import_glob: support tsconfig paths with `import.meta.glob` (#10167) by @sapphi-red
- dev: clear tsconfig caches for bare full builds (#10276) by @shulaoda
- dev: force a full rebuild when a tsconfig changes (#10261) by @shulaoda
- treat rooted drive-less module ids as absolute in preserveModules naming (#10235) by @IWANABETHATGUY
- watch: rebuild when tsconfig files change (#10258) by @shulaoda
- watch: drop tsconfig-merged transform options on each rebuild (#10257) by @shulaoda
- incorrect `EMPTY_IMPORT_META` warning for `import.meta.ROLLUP_FILE_URL_*` for CJS output (#10221) by @sapphi-red
- deconflict: rename CJS locals shadowing wrapped-ESM namespace objects (#9970) by @IWANABETHATGUY
- rolldown: drop the unused runtime module after entry-level external flattening (#10237) by @IWANABETHATGUY
- rolldown: re-propagate has_dynamic_exports to transitive star importers (#10239) by @IWANABETHATGUY
- tree-shaking: tree-shake destructured dynamic import namespace bindings (#10213) by @logaretm
- s390x: use json-escape-simd 3.1.1 for big-endian JSON escaping fix (#10211) by @satyamg1620

### 🚜 Refactor

- dev: move full-reload to client side (#10207) by @h-a-n-a
- readability follow-ups to the ReplaceWith migration (#10286) by @IWANABETHATGUY
- replace take_in-then-write-back with ReplaceWith and by-value moves (#10285) by @Boshen
- share the main resolver's cache with the transformer's tsconfig lookups (#10205) by @shulaoda
- rolldown: extract the ns star-external __reExport emission rule into LinkingMetadata (#10238) by @IWANABETHATGUY
- rolldown: unify link/generate diagnostics into a Diagnostics accumulator (#10234) by @IWANABETHATGUY
- sourcemap_filenames: drop dead sourcemap-filename plumbing (#10189) by @IWANABETHATGUY
- extract external import symbol merging into a method (#10224) by @IWANABETHATGUY
- rolldown: skip CJS namespace merging under strict execution order (#10203) by @hyfdev
- resolve the manual tsconfig per file instead of once at startup (#10200) by @shulaoda
- rolldown: route interop ESM init emission through a shared init-target view (#10202) by @hyfdev
- rolldown: collapse vestigial wrap-kind state and share chunk sort helper (#10201) by @hyfdev

### 📚 Documentation

- show plugin kinds in JSDoc and each hook's description (#10218) by @sapphi-red
- add an explanation about removing imports from external modules without any messages (#10215) by @sapphi-red

### ⚡ Performance

- sourcemap: owned merge in SourceJoiner::join (4005->5 allocs/chunk) (#10250) by @Boshen
- avoid redundant sourcemap string copies in collapse and minify paths (#10093) by @Boshen

### 🧪 Testing

- code-splitting: establish strict-order review baselines (#10287) by @hyfdev
- dev: add hot API test cases (#10181) by @h-a-n-a
- code-splitting: normalize strict execution order variants (#10277) by @hyfdev
- code-splitting: harden strict execution order coverage (#10252) by @hyfdev
- code-splitting: add strict execution order regressions (#10253) by @hyfdev

### ⚙️ Miscellaneous Tasks

- deps: update github actions (#10241) by @renovate[bot]
- deps: update oxc to 0.140.0 (#10274) by @shulaoda
- update Yunfei's GitHub username (#10275) by @hyfdev
- deps: update napi (#10260) by @renovate[bot]
- deps: update test262 submodule for tests (#10266) by @rolldown-guard[bot]
- deps: update dependency vite-plus to v0.2.4 (#10256) by @renovate[bot]
- deps: update napi (#10240) by @renovate[bot]
- deps: update oxc resolver to v11.24.2 (#10245) by @renovate[bot]
- deps: update rust crates (#10244) by @renovate[bot]
- disable Renovate updates for idna_adapter (#10248) by @shulaoda
- deps: update oxc resolver to v11.24.1 (#10232) by @renovate[bot]
- deps: update rust crate oxc_sourcemap to v8.1.1 (#10233) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to ^0.27.0 (#10206) by @renovate[bot]
- deps: upgrade sugar_path to v3 (#10230) by @hyfdev
- add `dist-*` to `.gitignore` in sourcemap-filenames/hash-final-content fixture (#10216) by @sapphi-red
- deps: update dependency rust to v1.97.0 (#10209) by @renovate[bot]

### ❤️ New Contributors

* @satyamg1620 made their first contribution in [#10211](#10211)

Co-authored-by: shulaoda <[email protected]>
Brooooooklyn added a commit that referenced this pull request Jul 16, 2026
…d flavor

`dev()` spawns the BindingDevEngine, which the CurrentThread runtime flavor
does not support (UnsupportedRuntimeFeatureError). The sibling test already
guards with `test.skipIf(isSingleThread)`; this newer #10223 case merged in
without the guard, so it threw under `ROLLDOWN_RUNTIME=single`. The
factory-omission logic it exercises (hmr_stage.rs) is byte-identical to main
and runs under the multi-thread flavor.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Brooooooklyn added a commit that referenced this pull request Jul 16, 2026
…thread flavor

Same class as the dev-lazy-compile guard: this #10223 watcher test calls
`dev()`, which the CurrentThread runtime flavor rejects. Its four siblings in
this file already chain `.skipIf(isSingleThread)` before `.concurrent`; the
merged case lacked it and threw under `ROLLDOWN_RUNTIME=single test:watcher`.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants