Skip to content

fix: incorrect EMPTY_IMPORT_META warning for import.meta.ROLLUP_FILE_URL_* for CJS output#10221

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-10-fix_incorrect_empty_import_meta_warning_for_import.meta.rollup_file_url__for_cjs_output
Jul 13, 2026
Merged

fix: incorrect EMPTY_IMPORT_META warning for import.meta.ROLLUP_FILE_URL_* for CJS output#10221
graphite-app[bot] merged 1 commit into
mainfrom
07-10-fix_incorrect_empty_import_meta_warning_for_import.meta.rollup_file_url__for_cjs_output

Conversation

@sapphi-red

@sapphi-red sapphi-red commented Jul 10, 2026

Copy link
Copy Markdown
Member

Avoid EMPTY_IMPORT_META warning which was output for output.format: 'cjs' even though the import.meta.url is replaced.

sapphi-red commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red
sapphi-red force-pushed the 07-10-fix_incorrect_empty_import_meta_warning_for_import.meta.rollup_file_url__for_cjs_output branch from 6ab45f3 to 9e0e85d Compare July 10, 2026 13:33
@sapphi-red
sapphi-red force-pushed the 07-10-feat_add_file_not_found_error branch from 8848674 to 69c82a4 Compare July 10, 2026 13:33
@sapphi-red
sapphi-red marked this pull request as ready for review July 10, 2026 13:41
@sapphi-red sapphi-red self-assigned this Jul 10, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 7 untouched benchmarks
⏩ 10 skipped benchmarks1


Comparing 07-10-fix_incorrect_empty_import_meta_warning_for_import.meta.rollup_file_url__for_cjs_output (8c35aa3) with 07-10-feat_add_file_not_found_error (efd56d3)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sapphi-red
sapphi-red changed the base branch from 07-10-feat_add_file_not_found_error to graphite-base/10221 July 13, 2026 03:35
@sapphi-red
sapphi-red force-pushed the graphite-base/10221 branch from 69c82a4 to efd56d3 Compare July 13, 2026 03:43
@sapphi-red
sapphi-red force-pushed the 07-10-fix_incorrect_empty_import_meta_warning_for_import.meta.rollup_file_url__for_cjs_output branch from 9e0e85d to 8c35aa3 Compare July 13, 2026 03:43
@sapphi-red
sapphi-red changed the base branch from graphite-base/10221 to 07-10-feat_add_file_not_found_error July 13, 2026 03:43

sapphi-red commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Merge activity

  • Jul 13, 3:44 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 13, 4:09 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Jul 13, 4:15 AM UTC: Merged by the Graphite merge queue.

…LE_URL_*` for CJS output (#10221)

Avoid `EMPTY_IMPORT_META` warning which was output for `output.format: 'cjs'` even though the `import.meta.url` is replaced.
@graphite-app
graphite-app Bot force-pushed the 07-10-feat_add_file_not_found_error branch from efd56d3 to a41c903 Compare July 13, 2026 04:10
@graphite-app
graphite-app Bot force-pushed the 07-10-fix_incorrect_empty_import_meta_warning_for_import.meta.rollup_file_url__for_cjs_output branch from 8c35aa3 to bad54f7 Compare July 13, 2026 04:11
Base automatically changed from 07-10-feat_add_file_not_found_error to main July 13, 2026 04:14
@graphite-app
graphite-app Bot merged commit bad54f7 into main Jul 13, 2026
30 of 31 checks passed
@graphite-app
graphite-app Bot deleted the 07-10-fix_incorrect_empty_import_meta_warning_for_import.meta.rollup_file_url__for_cjs_output branch July 13, 2026 04:15
@rolldown-guard rolldown-guard Bot mentioned this pull request Jul 15, 2026
shulaoda added a commit that referenced this pull request Jul 15, 2026
## [1.2.0] - 2026-07-15

### 🚀 Features

- dev: skip shipping factories for newly imported top-level modules (#10223) by @h-a-n-a
- dev: per-client ship map for HMR patch sizing (#10208) by @h-a-n-a
- dev: client-side HMR (#10164) by @h-a-n-a
- dev: send a full-reload update to clients when a tsconfig changes (#10262) by @shulaoda
- treat `import.meta['url']` and `import.meta['ROLLUP_FILE_URL_*']` as side-effect free (#10267) by @sapphi-red
- rewrite `import.meta['url']` (#10251) by @sapphi-red
- add `FILE_NOT_FOUND` error (#10220) by @sapphi-red
- treat `import.meta.ROLLUP_FILE_URL_*` as side-effect free (#10217) by @sapphi-red

### 🐛 Bug Fixes

- sourcemap: preserve unmapped boundaries during composition (#10254) by @hyfdev
- `[format]` in `*FileNames` option for ESM format should be `es` instead of `esm` (#10214) by @sapphi-red
- sourcemap: preserve coarse mappings during composition (#10249) by @hyfdev
- rolldown_plugin_vite_import_glob: support tsconfig paths with `import.meta.glob` (#10167) by @sapphi-red
- dev: clear tsconfig caches for bare full builds (#10276) by @shulaoda
- dev: force a full rebuild when a tsconfig changes (#10261) by @shulaoda
- treat rooted drive-less module ids as absolute in preserveModules naming (#10235) by @IWANABETHATGUY
- watch: rebuild when tsconfig files change (#10258) by @shulaoda
- watch: drop tsconfig-merged transform options on each rebuild (#10257) by @shulaoda
- incorrect `EMPTY_IMPORT_META` warning for `import.meta.ROLLUP_FILE_URL_*` for CJS output (#10221) by @sapphi-red
- deconflict: rename CJS locals shadowing wrapped-ESM namespace objects (#9970) by @IWANABETHATGUY
- rolldown: drop the unused runtime module after entry-level external flattening (#10237) by @IWANABETHATGUY
- rolldown: re-propagate has_dynamic_exports to transitive star importers (#10239) by @IWANABETHATGUY
- tree-shaking: tree-shake destructured dynamic import namespace bindings (#10213) by @logaretm
- s390x: use json-escape-simd 3.1.1 for big-endian JSON escaping fix (#10211) by @satyamg1620

### 🚜 Refactor

- dev: move full-reload to client side (#10207) by @h-a-n-a
- readability follow-ups to the ReplaceWith migration (#10286) by @IWANABETHATGUY
- replace take_in-then-write-back with ReplaceWith and by-value moves (#10285) by @Boshen
- share the main resolver's cache with the transformer's tsconfig lookups (#10205) by @shulaoda
- rolldown: extract the ns star-external __reExport emission rule into LinkingMetadata (#10238) by @IWANABETHATGUY
- rolldown: unify link/generate diagnostics into a Diagnostics accumulator (#10234) by @IWANABETHATGUY
- sourcemap_filenames: drop dead sourcemap-filename plumbing (#10189) by @IWANABETHATGUY
- extract external import symbol merging into a method (#10224) by @IWANABETHATGUY
- rolldown: skip CJS namespace merging under strict execution order (#10203) by @hyfdev
- resolve the manual tsconfig per file instead of once at startup (#10200) by @shulaoda
- rolldown: route interop ESM init emission through a shared init-target view (#10202) by @hyfdev
- rolldown: collapse vestigial wrap-kind state and share chunk sort helper (#10201) by @hyfdev

### 📚 Documentation

- show plugin kinds in JSDoc and each hook's description (#10218) by @sapphi-red
- add an explanation about removing imports from external modules without any messages (#10215) by @sapphi-red

### ⚡ Performance

- sourcemap: owned merge in SourceJoiner::join (4005->5 allocs/chunk) (#10250) by @Boshen
- avoid redundant sourcemap string copies in collapse and minify paths (#10093) by @Boshen

### 🧪 Testing

- code-splitting: establish strict-order review baselines (#10287) by @hyfdev
- dev: add hot API test cases (#10181) by @h-a-n-a
- code-splitting: normalize strict execution order variants (#10277) by @hyfdev
- code-splitting: harden strict execution order coverage (#10252) by @hyfdev
- code-splitting: add strict execution order regressions (#10253) by @hyfdev

### ⚙️ Miscellaneous Tasks

- deps: update github actions (#10241) by @renovate[bot]
- deps: update oxc to 0.140.0 (#10274) by @shulaoda
- update Yunfei's GitHub username (#10275) by @hyfdev
- deps: update napi (#10260) by @renovate[bot]
- deps: update test262 submodule for tests (#10266) by @rolldown-guard[bot]
- deps: update dependency vite-plus to v0.2.4 (#10256) by @renovate[bot]
- deps: update napi (#10240) by @renovate[bot]
- deps: update oxc resolver to v11.24.2 (#10245) by @renovate[bot]
- deps: update rust crates (#10244) by @renovate[bot]
- disable Renovate updates for idna_adapter (#10248) by @shulaoda
- deps: update oxc resolver to v11.24.1 (#10232) by @renovate[bot]
- deps: update rust crate oxc_sourcemap to v8.1.1 (#10233) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to ^0.27.0 (#10206) by @renovate[bot]
- deps: upgrade sugar_path to v3 (#10230) by @hyfdev
- add `dist-*` to `.gitignore` in sourcemap-filenames/hash-final-content fixture (#10216) by @sapphi-red
- deps: update dependency rust to v1.97.0 (#10209) by @renovate[bot]

### ❤️ New Contributors

* @satyamg1620 made their first contribution in [#10211](#10211)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants