feat(dev): per-client ship map for HMR patch sizing by h-a-n-a · Pull Request #10208 · rolldown/rolldown

h-a-n-a · 2026-07-09T12:14:50Z

Summary

For full design and principles, please refer to #10164 (comment).

This PR adds the server-side ship map: a per-client record of which factory versions each browser tab already has, so patches and lazy chunks carry only changed, not-yet-shipped factories.

Example

The stateful server's ship map would incrementally ship factories that are only outdated or never shipped.

The module graph

flowchart LR
    app["app.js"] --> foo["foo.js<br/>(import.meta.hot.accept — boundary)"]
    foo --> bar["bar.js"]
    bar --> baz["baz.js<br/>(edited twice)"]

Server & client interaction

sequenceDiagram
    participant S as Server (keeps shipped[C])
    participant C as Browser tab C

    Note over C: initial bundle is scope-hoisted — no factories registered on the client yet
    Note over S: shipped[C] = { }

    Note over S,C: ① first edit of baz.js
    S->>C: patch 1 — factories foo@v0 + bar@v0 + baz@v1 (whole re-run chain, nothing shipped yet)
    C->>C: re-run baz → bar → foo, foo accepts
    Note over S: shipped[C] = { foo@v0, bar@v0, baz@v1 }

    Note over S,C: ② second edit of baz.js
    S->>C: patch 2 — factory baz@v2 only (foo@v0 and bar@v0 are still current in shipped[C])
    C->>C: re-run baz → bar → foo, foo accepts
    Note over S: shipped[C] = { foo@v0, bar@v0, baz@v2 }

The first edit ships the whole re-run chain because the initial bundle is scope-hoisted, so the client holds no factories yet. The second edit ships only baz — the ship map says foo and bar were already delivered and are not stale.

Rendered, the flow reads:

app.js ──> foo.js ──> bar.js ──> baz.js
(accept) (edited)

edit ① patch = [foo@v0, bar@v0, baz@v1] shipped[C]: {} -> {foo@v0, bar@v0, baz@v1}
edit ② patch = [baz@v2] shipped[C]: baz v1 -> v2, rest untouched

h-a-n-a · 2026-07-09T12:15:09Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3169c399fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codspeed-hq · 2026-07-14T05:46:12Z

Merging this PR will not alter performance

✅ 7 untouched benchmarks
⏩ 10 skipped benchmarks¹

_{Comparing 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing (408e889) with main (ab584a3)}

10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

sapphi-red

(I only checked the behavior explanation comment in the test cases)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe5254dde5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80e1e7d421

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

graphite-app · 2026-07-15T06:53:25Z

Merge activity

Jul 15, 6:53 AM UTC: h-a-n-a added this pull request to the Graphite merge queue.
Jul 15, 6:59 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
Jul 15, 7:18 AM UTC: h-a-n-a added this pull request to the Graphite merge queue.
Jul 15, 7:29 AM UTC: Merged by the Graphite merge queue.

netlify · 2026-07-15T07:14:38Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`80c3022`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6a5735c8c0eca500082e802a
😎 Deploy Preview	https://deploy-preview-10208--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hyfdev

I found three important issues; details inline.

hyfdev · 2026-07-15T07:14:50Z

+            let stable_id = normal_dep.stable_id.as_str();
+            if shipped.get(stable_id).is_some_and(|stamp| !stamp_table.is_stale(stable_id, *stamp))
+            {
+              continue;


Important: please keep traversing through current shipped modules. The Vite client does skip fetching a patch when the entire update is irrelevant to that tab, but a fetched patch can still co-carry an unexecuted importer from the server's static superset. I reproduced this with two tabs: a lazy module imports an executed shared module and another never-delivered dependency; editing the shared module makes the second tab fetch a patch that carries the lazy module but not that other dependency, so delivery records the lazy module as current. When that tab later loads the route, this continue skips the missing dependency and the parked factory throws MissingFactoryError from initModule. Please separate "visited" from "carried": omit the already-current module itself, but still walk through its static dependencies.

hyfdev · 2026-07-15T07:14:50Z

+                  modules: std::mem::take(&mut patch.carried),
+                },
+              )
+              .await;


Important: please drop updates whose client disconnected during computation. If a client disappears after the snapshot, the sequence-assignment loop leaves its patch at the placeholder seq = 0, but this unconditional insertion recreates a pending entry after remove_client already cleaned that session, and the invalid update is still exposed through on_hmr_updates. Vite ignores it because its socket lookup fails, so the pending entry can never be consumed; repeated races with fresh client IDs grow pending_payloads without a global bound. Retain only updates whose session was still present when the sequence was assigned.

hyfdev · 2026-07-15T07:14:50Z

+            }
          }
+
+          let update = self.render_hmr_patch(carried, changed_ids.clone(), stamp_table).await?;


Important: please bound the lifetime of these per-client patch artifacts. This loop now creates a distinct filename, and usually a sourcemap, for every client on every edit. The pinned Vite consumer stores them in BundledDev.memoryFiles, whose only cleanup is clear() when the server closes; importing a patch does not remove it. A long-running dev server therefore permanently retains roughly clients × edits complete patch artifacts. Please add delivery-time deletion plus bounded eviction for files never requested, or share one rendered artifact when clients have the same carried set.

hyfdev

Approved with the important follow-ups noted inline.

## Summary For full design and principles, please refer to #10164 (comment). This PR adds the server-side **ship map**: a per-client record of which factory versions each browser tab already has, so patches and lazy chunks carry only changed, not-yet-shipped factories. ## Example The stateful server's ship map would incrementally ship factories that are only outdated or never shipped. ### The module graph ```mermaid flowchart LR app["app.js"] --> foo["foo.js<br/>(import.meta.hot.accept — boundary)"] foo --> bar["bar.js"] bar --> baz["baz.js<br/>(edited twice)"] ``` ### Server & client interaction ```mermaid sequenceDiagram participant S as Server (keeps shipped[C]) participant C as Browser tab C Note over C: initial bundle is scope-hoisted — no factories registered on the client yet Note over S: shipped[C] = { } Note over S,C: ① first edit of baz.js S->>C: patch 1 — factories foo@v0 + bar@v0 + baz@v1 (whole re-run chain, nothing shipped yet) C->>C: re-run baz → bar → foo, foo accepts Note over S: shipped[C] = { foo@v0, bar@v0, baz@v1 } Note over S,C: ② second edit of baz.js S->>C: patch 2 — factory baz@v2 only (foo@v0 and bar@v0 are still current in shipped[C]) C->>C: re-run baz → bar → foo, foo accepts Note over S: shipped[C] = { foo@v0, bar@v0, baz@v2 } ``` The first edit ships the whole re-run chain because the initial bundle is scope-hoisted, so the client holds no factories yet. The second edit ships only `baz` — the ship map says `foo` and `bar` were already delivered and are not stale. Rendered, the flow reads: app.js ──> foo.js ──> bar.js ──> baz.js (accept) (edited) edit ① patch = [foo@v0, bar@v0, baz@v1] shipped[C]: {} -> {foo@v0, bar@v0, baz@v1} edit ② patch = [baz@v2] shipped[C]: baz v1 -> v2, rest untouched

…es (#10223)  ## Summary For full design and principles, please refer to #10164 (comment). The dev server tracks which module factories it has shipped per client in #10208. But modules that the entry chunk evaluated at top level never in the ship map. A lazy compile that subtracts only the ship man therefor re-ships factories the client already holds, which causes a size bloat in lazy-compilation chunks. This PR introduces a second per-client record - the `top_level_evaluated` map. This map contains the statically evaluated modules so that these modules are not shipped as factories in lazy compilation chunks again when the factories are not changed and only their exports are needed.

@h-a-n-a

## [1.2.0] - 2026-07-15 ### 🚀 Features - dev: skip shipping factories for newly imported top-level modules (#10223) by @h-a-n-a - dev: per-client ship map for HMR patch sizing (#10208) by @h-a-n-a - dev: client-side HMR (#10164) by @h-a-n-a - dev: send a full-reload update to clients when a tsconfig changes (#10262) by @shulaoda - treat `import.meta['url']` and `import.meta['ROLLUP_FILE_URL_*']` as side-effect free (#10267) by @sapphi-red - rewrite `import.meta['url']` (#10251) by @sapphi-red - add `FILE_NOT_FOUND` error (#10220) by @sapphi-red - treat `import.meta.ROLLUP_FILE_URL_*` as side-effect free (#10217) by @sapphi-red ### 🐛 Bug Fixes - sourcemap: preserve unmapped boundaries during composition (#10254) by @hyfdev - `[format]` in `*FileNames` option for ESM format should be `es` instead of `esm` (#10214) by @sapphi-red - sourcemap: preserve coarse mappings during composition (#10249) by @hyfdev - rolldown_plugin_vite_import_glob: support tsconfig paths with `import.meta.glob` (#10167) by @sapphi-red - dev: clear tsconfig caches for bare full builds (#10276) by @shulaoda - dev: force a full rebuild when a tsconfig changes (#10261) by @shulaoda - treat rooted drive-less module ids as absolute in preserveModules naming (#10235) by @IWANABETHATGUY - watch: rebuild when tsconfig files change (#10258) by @shulaoda - watch: drop tsconfig-merged transform options on each rebuild (#10257) by @shulaoda - incorrect `EMPTY_IMPORT_META` warning for `import.meta.ROLLUP_FILE_URL_*` for CJS output (#10221) by @sapphi-red - deconflict: rename CJS locals shadowing wrapped-ESM namespace objects (#9970) by @IWANABETHATGUY - rolldown: drop the unused runtime module after entry-level external flattening (#10237) by @IWANABETHATGUY - rolldown: re-propagate has_dynamic_exports to transitive star importers (#10239) by @IWANABETHATGUY - tree-shaking: tree-shake destructured dynamic import namespace bindings (#10213) by @logaretm - s390x: use json-escape-simd 3.1.1 for big-endian JSON escaping fix (#10211) by @satyamg1620 ### 🚜 Refactor - dev: move full-reload to client side (#10207) by @h-a-n-a - readability follow-ups to the ReplaceWith migration (#10286) by @IWANABETHATGUY - replace take_in-then-write-back with ReplaceWith and by-value moves (#10285) by @Boshen - share the main resolver's cache with the transformer's tsconfig lookups (#10205) by @shulaoda - rolldown: extract the ns star-external __reExport emission rule into LinkingMetadata (#10238) by @IWANABETHATGUY - rolldown: unify link/generate diagnostics into a Diagnostics accumulator (#10234) by @IWANABETHATGUY - sourcemap_filenames: drop dead sourcemap-filename plumbing (#10189) by @IWANABETHATGUY - extract external import symbol merging into a method (#10224) by @IWANABETHATGUY - rolldown: skip CJS namespace merging under strict execution order (#10203) by @hyfdev - resolve the manual tsconfig per file instead of once at startup (#10200) by @shulaoda - rolldown: route interop ESM init emission through a shared init-target view (#10202) by @hyfdev - rolldown: collapse vestigial wrap-kind state and share chunk sort helper (#10201) by @hyfdev ### 📚 Documentation - show plugin kinds in JSDoc and each hook's description (#10218) by @sapphi-red - add an explanation about removing imports from external modules without any messages (#10215) by @sapphi-red ### ⚡ Performance - sourcemap: owned merge in SourceJoiner::join (4005->5 allocs/chunk) (#10250) by @Boshen - avoid redundant sourcemap string copies in collapse and minify paths (#10093) by @Boshen ### 🧪 Testing - code-splitting: establish strict-order review baselines (#10287) by @hyfdev - dev: add hot API test cases (#10181) by @h-a-n-a - code-splitting: normalize strict execution order variants (#10277) by @hyfdev - code-splitting: harden strict execution order coverage (#10252) by @hyfdev - code-splitting: add strict execution order regressions (#10253) by @hyfdev ### ⚙️ Miscellaneous Tasks - deps: update github actions (#10241) by @renovate[bot] - deps: update oxc to 0.140.0 (#10274) by @shulaoda - update Yunfei's GitHub username (#10275) by @hyfdev - deps: update napi (#10260) by @renovate[bot] - deps: update test262 submodule for tests (#10266) by @rolldown-guard[bot] - deps: update dependency vite-plus to v0.2.4 (#10256) by @renovate[bot] - deps: update napi (#10240) by @renovate[bot] - deps: update oxc resolver to v11.24.2 (#10245) by @renovate[bot] - deps: update rust crates (#10244) by @renovate[bot] - disable Renovate updates for idna_adapter (#10248) by @shulaoda - deps: update oxc resolver to v11.24.1 (#10232) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v8.1.1 (#10233) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.27.0 (#10206) by @renovate[bot] - deps: upgrade sugar_path to v3 (#10230) by @hyfdev - add `dist-*` to `.gitignore` in sourcemap-filenames/hash-final-content fixture (#10216) by @sapphi-red - deps: update dependency rust to v1.97.0 (#10209) by @renovate[bot] ### ❤️ New Contributors * @satyamg1620 made their first contribution in [#10211](#10211) Co-authored-by: shulaoda <[email protected]>

This was referenced Jul 9, 2026

feat(dev): client-side HMR #10164

Merged

test(dev): add hot API test cases #10181

Merged

h-a-n-a mentioned this pull request Jul 9, 2026

refactor(dev): move full-reload to client side #10207

Merged

h-a-n-a changed the title ~~feat(dev): per-client shipped ledger for HMR patch sizing~~ feat(dev): per-client shipped map for HMR patch sizing Jul 9, 2026

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 4306577 to 824e009 Compare July 9, 2026 14:29

h-a-n-a changed the title ~~feat(dev): per-client shipped map for HMR patch sizing~~ feat(dev): per-client ship map for HMR patch sizing Jul 9, 2026

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 824e009 to b7dd607 Compare July 9, 2026 16:51

h-a-n-a force-pushed the 07-07-feat_dev_client-side_hmr branch 2 times, most recently from cc1cfa2 to 9f4db0d Compare July 10, 2026 05:40

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch 2 times, most recently from b1eafbf to a0d4f5c Compare July 10, 2026 06:15

h-a-n-a force-pushed the 07-07-feat_dev_client-side_hmr branch from e5793fc to 49a06d5 Compare July 10, 2026 06:15

h-a-n-a mentioned this pull request Jul 10, 2026

feat(dev): skip shipping factories for newly imported top-level modules #10223

Merged

h-a-n-a force-pushed the 07-07-feat_dev_client-side_hmr branch from 49a06d5 to a90f3de Compare July 10, 2026 17:15

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from a0d4f5c to 49572b5 Compare July 10, 2026 17:15

h-a-n-a force-pushed the 07-07-feat_dev_client-side_hmr branch from a90f3de to 671f1e7 Compare July 13, 2026 10:24

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 49572b5 to 3169c39 Compare July 13, 2026 10:24

h-a-n-a marked this pull request as ready for review July 14, 2026 05:39

h-a-n-a requested review from IWANABETHATGUY, hyfdev, sapphi-red and shulaoda as code owners July 14, 2026 05:39

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/rolldown/src/hmr/hmr_stage.rs

h-a-n-a mentioned this pull request Jul 14, 2026

docs(dev): add HMR design #10271

Draft

sapphi-red approved these changes Jul 14, 2026

View reviewed changes

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 3169c39 to fe5254d Compare July 14, 2026 13:52

h-a-n-a force-pushed the 07-07-feat_dev_client-side_hmr branch from 671f1e7 to 079f19e Compare July 14, 2026 13:52

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/rolldown/src/hmr/hmr_stage.rs

h-a-n-a force-pushed the 07-07-feat_dev_client-side_hmr branch from 079f19e to ab763dd Compare July 15, 2026 03:08

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from fe5254d to 80e1e7d Compare July 15, 2026 03:08

chatgpt-codex-connector Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread crates/rolldown_dev/src/bundling_task.rs

h-a-n-a force-pushed the 07-07-feat_dev_client-side_hmr branch from ab763dd to f9ee937 Compare July 15, 2026 04:08

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch 2 times, most recently from 18e4ff3 to e1d592c Compare July 15, 2026 05:01

h-a-n-a force-pushed the 07-07-feat_dev_client-side_hmr branch 2 times, most recently from 8d37643 to fad060c Compare July 15, 2026 06:17

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from e1d592c to 7194a94 Compare July 15, 2026 06:17

graphite-app Bot changed the base branch from 07-07-feat_dev_client-side_hmr to graphite-base/10208 July 15, 2026 06:52

shulaoda approved these changes Jul 15, 2026

View reviewed changes

graphite-app Bot changed the base branch from graphite-base/10208 to main July 15, 2026 06:58

h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 7194a94 to 408e889 Compare July 15, 2026 07:13

hyfdev reviewed Jul 15, 2026

View reviewed changes

hyfdev approved these changes Jul 15, 2026

View reviewed changes

shulaoda added the graphite: merge-when-ready label Jul 15, 2026

graphite-app Bot force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 408e889 to 80c3022 Compare July 15, 2026 07:24

graphite-app Bot merged commit 80c3022 into main Jul 15, 2026
33 of 34 checks passed

graphite-app Bot removed the graphite: merge-when-ready label Jul 15, 2026

graphite-app Bot deleted the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch July 15, 2026 07:29

h-a-n-a mentioned this pull request Jul 15, 2026

[Feature Request]: compute HMR boundaries on the client instead of the server #10039

Open

rolldown-guard Bot mentioned this pull request Jul 15, 2026

release: v1.2.0 #10292

Merged

h-a-n-a mentioned this pull request Jul 15, 2026

test: unify Vite in vite-test and test-dev-server #10293

Merged

Uh oh!

Conversation

h-a-n-a commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Example

The module graph

Server & client interaction

Uh oh!

h-a-n-a commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codspeed-hq Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

graphite-app Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

hyfdev left a comment

Choose a reason for hiding this comment

Uh oh!

hyfdev Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

hyfdev Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

hyfdev Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

hyfdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

h-a-n-a commented Jul 9, 2026 •

edited

Loading

h-a-n-a commented Jul 9, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 14, 2026 •

edited

Loading

graphite-app Bot commented Jul 15, 2026 •

edited

Loading

netlify Bot commented Jul 15, 2026 •

edited

Loading