Skip to content

refactor(dev): move full-reload to client side#10207

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-09-refactor_dev_move_full-reload_to_client_side
Jul 15, 2026
Merged

refactor(dev): move full-reload to client side#10207
graphite-app[bot] merged 1 commit into
mainfrom
07-09-refactor_dev_move_full-reload_to_client_side

Conversation

@h-a-n-a

@h-a-n-a h-a-n-a commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary

For full design and principles, please refer to #10164 (comment).

This PR removes the full-reload decision from the server's HMR update type, so the client decides to reload from its own boundary result.

h-a-n-a commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@h-a-n-a
h-a-n-a changed the base branch from 07-07-feat_dev_client-side_hmr to graphite-base/10207 July 9, 2026 12:14
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from a5cca16 to e326387 Compare July 9, 2026 12:14
@h-a-n-a
h-a-n-a force-pushed the graphite-base/10207 branch from 0cb9954 to 4306577 Compare July 9, 2026 12:14
@h-a-n-a
h-a-n-a changed the base branch from graphite-base/10207 to 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing July 9, 2026 12:14
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 4306577 to 824e009 Compare July 9, 2026 14:29
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch 3 times, most recently from 37e3584 to 01f91d8 Compare July 9, 2026 16:51
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 824e009 to b7dd607 Compare July 9, 2026 16:51
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from 01f91d8 to 5dcb6e5 Compare July 10, 2026 05:40
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from b7dd607 to b1eafbf Compare July 10, 2026 05:40
h-a-n-a added a commit that referenced this pull request Jul 10, 2026
This branch still emits HmrUpdate::FullReload. Vite d07220fa removed
the FullReload handler (the client decides reloads now), so reload-
dependent browser tests time out against it. The bump to d07220fa
belongs to the full-reload refactor branch (#10207).

Co-Authored-By: Claude Fable 5 <[email protected]>
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from 5dcb6e5 to b235992 Compare July 10, 2026 06:15
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from b1eafbf to a0d4f5c Compare July 10, 2026 06:15
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from a0d4f5c to 49572b5 Compare July 10, 2026 17:15
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch 2 times, most recently from 3c9b031 to 945b89c Compare July 13, 2026 10:24
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 49572b5 to 3169c39 Compare July 13, 2026 10:24
@h-a-n-a
h-a-n-a marked this pull request as ready for review July 14, 2026 05:39
@codspeed-hq

codspeed-hq Bot commented Jul 14, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 19.94%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 6 untouched benchmarks
⏩ 10 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
collapse_codegen_chain 13.8 ms 11.5 ms +19.94%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing 07-09-refactor_dev_move_full-reload_to_client_side (8baa0fe) with 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing (408e889)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from 91ac23a to c6aa5bc Compare July 15, 2026 05:01
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 18e4ff3 to e1d592c Compare July 15, 2026 05:01
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from c6aa5bc to ec2a8f7 Compare July 15, 2026 06:17
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from e1d592c to 7194a94 Compare July 15, 2026 06:17
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from ec2a8f7 to 8a48270 Compare July 15, 2026 06:41
@h-a-n-a
h-a-n-a requested a review from sapphi-red July 15, 2026 06:47
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from 8a48270 to 8baa0fe Compare July 15, 2026 07:13
@h-a-n-a
h-a-n-a force-pushed the 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing branch from 7194a94 to 408e889 Compare July 15, 2026 07:13
@graphite-app
graphite-app Bot changed the base branch from 07-09-feat_dev_per-client_shipped_ledger_for_hmr_patch_sizing to graphite-base/10207 July 15, 2026 07:24
@graphite-app

graphite-app Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Merge activity

  • Jul 15, 7:25 AM UTC: h-a-n-a added this pull request to the Graphite merge queue.
  • Jul 15, 7:31 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Jul 15, 7:31 AM UTC: The merge label 'graphite: merge-when-ready' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jul 15, 7:31 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 15, 7:32 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jul 15, 7:36 AM UTC: h-a-n-a added this pull request to the Graphite merge queue.
  • Jul 15, 7:42 AM UTC: Merged by the Graphite merge queue.

@graphite-app
graphite-app Bot changed the base branch from graphite-base/10207 to main July 15, 2026 07:29
@h-a-n-a
h-a-n-a force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from 8baa0fe to 435dd2d Compare July 15, 2026 07:31
@netlify

netlify Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3bd65ff
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6a5738e200c9170008ceab66

<!--
- What is this PR solving? Write a clear and concise description.
- Reference the issues it solves (e.g. `fixes #123`).
- What other alternatives have you explored?
- Are there any parts you think require more attention from reviewers?

Also, please make sure you do the following:

- Read the Contributing Guidelines at https://rolldown.rs/contribution-guide/.
- Check that there isn't already a PR that solves the problem the same way. If you find a duplicate, please help us review it.
- Update the corresponding documentation if needed.
- Include relevant tests that fail without this PR but pass with it. If the tests are not included, explain why.

Thank you for contributing to Rolldown!
-->

## Summary

For full design and principles, please refer to #10164 (comment).

This PR removes the full-reload decision from the server's HMR update type, so the client decides to reload from its own boundary result.
@graphite-app
graphite-app Bot force-pushed the 07-09-refactor_dev_move_full-reload_to_client_side branch from 435dd2d to 3bd65ff Compare July 15, 2026 07:38
@graphite-app
graphite-app Bot merged commit 3bd65ff into main Jul 15, 2026
33 of 34 checks passed
@graphite-app
graphite-app Bot deleted the 07-09-refactor_dev_move_full-reload_to_client_side branch July 15, 2026 07:42
@rolldown-guard rolldown-guard Bot mentioned this pull request Jul 15, 2026
shulaoda added a commit that referenced this pull request Jul 15, 2026
## [1.2.0] - 2026-07-15

### 🚀 Features

- dev: skip shipping factories for newly imported top-level modules (#10223) by @h-a-n-a
- dev: per-client ship map for HMR patch sizing (#10208) by @h-a-n-a
- dev: client-side HMR (#10164) by @h-a-n-a
- dev: send a full-reload update to clients when a tsconfig changes (#10262) by @shulaoda
- treat `import.meta['url']` and `import.meta['ROLLUP_FILE_URL_*']` as side-effect free (#10267) by @sapphi-red
- rewrite `import.meta['url']` (#10251) by @sapphi-red
- add `FILE_NOT_FOUND` error (#10220) by @sapphi-red
- treat `import.meta.ROLLUP_FILE_URL_*` as side-effect free (#10217) by @sapphi-red

### 🐛 Bug Fixes

- sourcemap: preserve unmapped boundaries during composition (#10254) by @hyfdev
- `[format]` in `*FileNames` option for ESM format should be `es` instead of `esm` (#10214) by @sapphi-red
- sourcemap: preserve coarse mappings during composition (#10249) by @hyfdev
- rolldown_plugin_vite_import_glob: support tsconfig paths with `import.meta.glob` (#10167) by @sapphi-red
- dev: clear tsconfig caches for bare full builds (#10276) by @shulaoda
- dev: force a full rebuild when a tsconfig changes (#10261) by @shulaoda
- treat rooted drive-less module ids as absolute in preserveModules naming (#10235) by @IWANABETHATGUY
- watch: rebuild when tsconfig files change (#10258) by @shulaoda
- watch: drop tsconfig-merged transform options on each rebuild (#10257) by @shulaoda
- incorrect `EMPTY_IMPORT_META` warning for `import.meta.ROLLUP_FILE_URL_*` for CJS output (#10221) by @sapphi-red
- deconflict: rename CJS locals shadowing wrapped-ESM namespace objects (#9970) by @IWANABETHATGUY
- rolldown: drop the unused runtime module after entry-level external flattening (#10237) by @IWANABETHATGUY
- rolldown: re-propagate has_dynamic_exports to transitive star importers (#10239) by @IWANABETHATGUY
- tree-shaking: tree-shake destructured dynamic import namespace bindings (#10213) by @logaretm
- s390x: use json-escape-simd 3.1.1 for big-endian JSON escaping fix (#10211) by @satyamg1620

### 🚜 Refactor

- dev: move full-reload to client side (#10207) by @h-a-n-a
- readability follow-ups to the ReplaceWith migration (#10286) by @IWANABETHATGUY
- replace take_in-then-write-back with ReplaceWith and by-value moves (#10285) by @Boshen
- share the main resolver's cache with the transformer's tsconfig lookups (#10205) by @shulaoda
- rolldown: extract the ns star-external __reExport emission rule into LinkingMetadata (#10238) by @IWANABETHATGUY
- rolldown: unify link/generate diagnostics into a Diagnostics accumulator (#10234) by @IWANABETHATGUY
- sourcemap_filenames: drop dead sourcemap-filename plumbing (#10189) by @IWANABETHATGUY
- extract external import symbol merging into a method (#10224) by @IWANABETHATGUY
- rolldown: skip CJS namespace merging under strict execution order (#10203) by @hyfdev
- resolve the manual tsconfig per file instead of once at startup (#10200) by @shulaoda
- rolldown: route interop ESM init emission through a shared init-target view (#10202) by @hyfdev
- rolldown: collapse vestigial wrap-kind state and share chunk sort helper (#10201) by @hyfdev

### 📚 Documentation

- show plugin kinds in JSDoc and each hook's description (#10218) by @sapphi-red
- add an explanation about removing imports from external modules without any messages (#10215) by @sapphi-red

### ⚡ Performance

- sourcemap: owned merge in SourceJoiner::join (4005->5 allocs/chunk) (#10250) by @Boshen
- avoid redundant sourcemap string copies in collapse and minify paths (#10093) by @Boshen

### 🧪 Testing

- code-splitting: establish strict-order review baselines (#10287) by @hyfdev
- dev: add hot API test cases (#10181) by @h-a-n-a
- code-splitting: normalize strict execution order variants (#10277) by @hyfdev
- code-splitting: harden strict execution order coverage (#10252) by @hyfdev
- code-splitting: add strict execution order regressions (#10253) by @hyfdev

### ⚙️ Miscellaneous Tasks

- deps: update github actions (#10241) by @renovate[bot]
- deps: update oxc to 0.140.0 (#10274) by @shulaoda
- update Yunfei's GitHub username (#10275) by @hyfdev
- deps: update napi (#10260) by @renovate[bot]
- deps: update test262 submodule for tests (#10266) by @rolldown-guard[bot]
- deps: update dependency vite-plus to v0.2.4 (#10256) by @renovate[bot]
- deps: update napi (#10240) by @renovate[bot]
- deps: update oxc resolver to v11.24.2 (#10245) by @renovate[bot]
- deps: update rust crates (#10244) by @renovate[bot]
- disable Renovate updates for idna_adapter (#10248) by @shulaoda
- deps: update oxc resolver to v11.24.1 (#10232) by @renovate[bot]
- deps: update rust crate oxc_sourcemap to v8.1.1 (#10233) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to ^0.27.0 (#10206) by @renovate[bot]
- deps: upgrade sugar_path to v3 (#10230) by @hyfdev
- add `dist-*` to `.gitignore` in sourcemap-filenames/hash-final-content fixture (#10216) by @sapphi-red
- deps: update dependency rust to v1.97.0 (#10209) by @renovate[bot]

### ❤️ New Contributors

* @satyamg1620 made their first contribution in [#10211](#10211)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants