refactor(sourcemap_filenames): drop dead sourcemap-filename plumbing#10189
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
IWANABETHATGUY
changed the title
graphite-app
Bot
changed the base branch from
fix/sourcemap-filenames-diagnostic-name
to
graphite-base/10189
July 8, 2026 06:02
graphite-app
Bot
force-pushed
the
graphite-base/10189
branch
from
July 8, 2026 06:06
69d2f3c to
fb1d3b4
Compare
graphite-app
Bot
force-pushed
the
refactor/sourcemap-preliminary-filename
branch
from
July 8, 2026 06:06
2280edc to
f389f72
Compare
graphite-app
Bot
force-pushed
the
refactor/sourcemap-preliminary-filename
branch
from
July 8, 2026 06:07
f389f72 to
072da29
Compare
✅ Deploy Preview for rolldown-rs canceled.
|
IWANABETHATGUY
force-pushed
the
refactor/sourcemap-preliminary-filename
branch
from
July 12, 2026 11:06
072da29 to
f920fd4
Compare
IWANABETHATGUY
marked this pull request as ready for review
July 12, 2026 11:08
hyfdev
approved these changes
Jul 12, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Member
Author
Merge activity
|
…10189) ## Summary Dead-code cleanup around sourcemap filename generation. **No behavior change** — all `output/sourcemap-filenames/*` fixtures pass unchanged. - Remove `JsOutputChunk.preliminary_sourcemap_filename`: it is written from the JS side but never read back, and leaked a phantom `preliminarySourcemapFilename?: string` into the published binding typings (`binding.d.cts`). - Replace the three-state `PreliminarySourcemapFilename` enum with plain `Option<PreliminaryFilename>`. The `Uninstantiated` state was unreachable after generation, so the sourcemap filename is now generated in lockstep with `preliminary_filename` inside the single `is_none()` block, and the skip guard collapses to `preliminary_filename.is_some()`. - Drop the now-dead filename-only `PartialEq`/`Eq` on `PreliminaryFilename` (nothing compares them once the enum's derive is gone). ## Test Plan - `cargo clippy -p rolldown -p rolldown_common --lib --features experimental -- --deny warnings` - `just build-rolldown` + all `output/sourcemap-filenames/*` fixtures pass (8/8). Stacked on #10188.
graphite-app
Bot
force-pushed
the
refactor/sourcemap-preliminary-filename
branch
from
July 12, 2026 12:22
f920fd4 to
1c14bb3
Compare
Merged
shulaoda
added a commit
that referenced
this pull request
Jul 15, 2026
## [1.2.0] - 2026-07-15 ### 🚀 Features - dev: skip shipping factories for newly imported top-level modules (#10223) by @h-a-n-a - dev: per-client ship map for HMR patch sizing (#10208) by @h-a-n-a - dev: client-side HMR (#10164) by @h-a-n-a - dev: send a full-reload update to clients when a tsconfig changes (#10262) by @shulaoda - treat `import.meta['url']` and `import.meta['ROLLUP_FILE_URL_*']` as side-effect free (#10267) by @sapphi-red - rewrite `import.meta['url']` (#10251) by @sapphi-red - add `FILE_NOT_FOUND` error (#10220) by @sapphi-red - treat `import.meta.ROLLUP_FILE_URL_*` as side-effect free (#10217) by @sapphi-red ### 🐛 Bug Fixes - sourcemap: preserve unmapped boundaries during composition (#10254) by @hyfdev - `[format]` in `*FileNames` option for ESM format should be `es` instead of `esm` (#10214) by @sapphi-red - sourcemap: preserve coarse mappings during composition (#10249) by @hyfdev - rolldown_plugin_vite_import_glob: support tsconfig paths with `import.meta.glob` (#10167) by @sapphi-red - dev: clear tsconfig caches for bare full builds (#10276) by @shulaoda - dev: force a full rebuild when a tsconfig changes (#10261) by @shulaoda - treat rooted drive-less module ids as absolute in preserveModules naming (#10235) by @IWANABETHATGUY - watch: rebuild when tsconfig files change (#10258) by @shulaoda - watch: drop tsconfig-merged transform options on each rebuild (#10257) by @shulaoda - incorrect `EMPTY_IMPORT_META` warning for `import.meta.ROLLUP_FILE_URL_*` for CJS output (#10221) by @sapphi-red - deconflict: rename CJS locals shadowing wrapped-ESM namespace objects (#9970) by @IWANABETHATGUY - rolldown: drop the unused runtime module after entry-level external flattening (#10237) by @IWANABETHATGUY - rolldown: re-propagate has_dynamic_exports to transitive star importers (#10239) by @IWANABETHATGUY - tree-shaking: tree-shake destructured dynamic import namespace bindings (#10213) by @logaretm - s390x: use json-escape-simd 3.1.1 for big-endian JSON escaping fix (#10211) by @satyamg1620 ### 🚜 Refactor - dev: move full-reload to client side (#10207) by @h-a-n-a - readability follow-ups to the ReplaceWith migration (#10286) by @IWANABETHATGUY - replace take_in-then-write-back with ReplaceWith and by-value moves (#10285) by @Boshen - share the main resolver's cache with the transformer's tsconfig lookups (#10205) by @shulaoda - rolldown: extract the ns star-external __reExport emission rule into LinkingMetadata (#10238) by @IWANABETHATGUY - rolldown: unify link/generate diagnostics into a Diagnostics accumulator (#10234) by @IWANABETHATGUY - sourcemap_filenames: drop dead sourcemap-filename plumbing (#10189) by @IWANABETHATGUY - extract external import symbol merging into a method (#10224) by @IWANABETHATGUY - rolldown: skip CJS namespace merging under strict execution order (#10203) by @hyfdev - resolve the manual tsconfig per file instead of once at startup (#10200) by @shulaoda - rolldown: route interop ESM init emission through a shared init-target view (#10202) by @hyfdev - rolldown: collapse vestigial wrap-kind state and share chunk sort helper (#10201) by @hyfdev ### 📚 Documentation - show plugin kinds in JSDoc and each hook's description (#10218) by @sapphi-red - add an explanation about removing imports from external modules without any messages (#10215) by @sapphi-red ### ⚡ Performance - sourcemap: owned merge in SourceJoiner::join (4005->5 allocs/chunk) (#10250) by @Boshen - avoid redundant sourcemap string copies in collapse and minify paths (#10093) by @Boshen ### 🧪 Testing - code-splitting: establish strict-order review baselines (#10287) by @hyfdev - dev: add hot API test cases (#10181) by @h-a-n-a - code-splitting: normalize strict execution order variants (#10277) by @hyfdev - code-splitting: harden strict execution order coverage (#10252) by @hyfdev - code-splitting: add strict execution order regressions (#10253) by @hyfdev ### ⚙️ Miscellaneous Tasks - deps: update github actions (#10241) by @renovate[bot] - deps: update oxc to 0.140.0 (#10274) by @shulaoda - update Yunfei's GitHub username (#10275) by @hyfdev - deps: update napi (#10260) by @renovate[bot] - deps: update test262 submodule for tests (#10266) by @rolldown-guard[bot] - deps: update dependency vite-plus to v0.2.4 (#10256) by @renovate[bot] - deps: update napi (#10240) by @renovate[bot] - deps: update oxc resolver to v11.24.2 (#10245) by @renovate[bot] - deps: update rust crates (#10244) by @renovate[bot] - disable Renovate updates for idna_adapter (#10248) by @shulaoda - deps: update oxc resolver to v11.24.1 (#10232) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v8.1.1 (#10233) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.27.0 (#10206) by @renovate[bot] - deps: upgrade sugar_path to v3 (#10230) by @hyfdev - add `dist-*` to `.gitignore` in sourcemap-filenames/hash-final-content fixture (#10216) by @sapphi-red - deps: update dependency rust to v1.97.0 (#10209) by @renovate[bot] ### ❤️ New Contributors * @satyamg1620 made their first contribution in [#10211](#10211) Co-authored-by: shulaoda <[email protected]>
Brooooooklyn
added a commit
that referenced
this pull request
Jul 16, 2026
…rations main's #10189 removed `preliminary_sourcemap_filename` from the Rust binding types, so native binding.d.cts no longer declares it. The WASI declarations (rolldown-binding.wasi.d.cts / .wasip1.d.cts) still carried the field because their regeneration is gated behind a WASI build that hadn't succeeded, tripping wasi-declaration-consistency's target-neutral JsOutputChunk check. Remove the stale member so all three declarations match (as a WASI rebuild would produce). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dead-code cleanup around sourcemap filename generation. No behavior change — all
output/sourcemap-filenames/*fixtures pass unchanged.JsOutputChunk.preliminary_sourcemap_filename: it is written from the JS side but never read back, and leaked a phantompreliminarySourcemapFilename?: stringinto the published binding typings (binding.d.cts).PreliminarySourcemapFilenameenum with plainOption<PreliminaryFilename>. TheUninstantiatedstate was unreachable after generation, so the sourcemap filename is now generated in lockstep withpreliminary_filenameinside the singleis_none()block, and the skip guard collapses topreliminary_filename.is_some().PartialEq/EqonPreliminaryFilename(nothing compares them once the enum's derive is gone).Test Plan
cargo clippy -p rolldown -p rolldown_common --lib --features experimental -- --deny warningsjust build-rolldown+ alloutput/sourcemap-filenames/*fixtures pass (8/8).Stacked on #10188.