fix(rolldown_plugin_vite_import_glob): support tsconfig paths with import.meta.glob#10167
Conversation
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
import.meta.globimport.meta.glob
This comment was marked as outdated.
This comment was marked as outdated.
Merging this PR will not alter performance
Comparing Footnotes
|
…ck (#1282) Adds `resolve_path_alias_or_base_url` method to `TsConfig` struct. This method resolves a specifier with tsconfig paths / baseUrl without checking the file existence. This is needed for rolldown/rolldown#10167.
e52c163 to
b26058f
Compare
b26058f to
0f2fcd7
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f2fcd7504
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0f2fcd7 to
d07232e
Compare
Merge activity
|
…mport.meta.glob` (#10167) Implements tsconfig paths support for `import.meta.glob` in a similar way to how subpath imports support is implemented. This PR does not support the case when the `paths` has multiple items in the array. Doing so requires the resolution to happen in the `rolldown_plugin_vite_import_glob` plugin because the candidates cannot be returned from `this.resolve`. But that could break plugins that resolves in between these plugins. An alternative approach is to make oxc-resolver possible to resolve globs. But this requires a huge change and I think it's not worth at this point. implements vitejs/vite#22881 requires oxc-project/oxc-resolver#1282
d07232e to
152ff69
Compare
## [1.2.0] - 2026-07-15 ### 🚀 Features - dev: skip shipping factories for newly imported top-level modules (#10223) by @h-a-n-a - dev: per-client ship map for HMR patch sizing (#10208) by @h-a-n-a - dev: client-side HMR (#10164) by @h-a-n-a - dev: send a full-reload update to clients when a tsconfig changes (#10262) by @shulaoda - treat `import.meta['url']` and `import.meta['ROLLUP_FILE_URL_*']` as side-effect free (#10267) by @sapphi-red - rewrite `import.meta['url']` (#10251) by @sapphi-red - add `FILE_NOT_FOUND` error (#10220) by @sapphi-red - treat `import.meta.ROLLUP_FILE_URL_*` as side-effect free (#10217) by @sapphi-red ### 🐛 Bug Fixes - sourcemap: preserve unmapped boundaries during composition (#10254) by @hyfdev - `[format]` in `*FileNames` option for ESM format should be `es` instead of `esm` (#10214) by @sapphi-red - sourcemap: preserve coarse mappings during composition (#10249) by @hyfdev - rolldown_plugin_vite_import_glob: support tsconfig paths with `import.meta.glob` (#10167) by @sapphi-red - dev: clear tsconfig caches for bare full builds (#10276) by @shulaoda - dev: force a full rebuild when a tsconfig changes (#10261) by @shulaoda - treat rooted drive-less module ids as absolute in preserveModules naming (#10235) by @IWANABETHATGUY - watch: rebuild when tsconfig files change (#10258) by @shulaoda - watch: drop tsconfig-merged transform options on each rebuild (#10257) by @shulaoda - incorrect `EMPTY_IMPORT_META` warning for `import.meta.ROLLUP_FILE_URL_*` for CJS output (#10221) by @sapphi-red - deconflict: rename CJS locals shadowing wrapped-ESM namespace objects (#9970) by @IWANABETHATGUY - rolldown: drop the unused runtime module after entry-level external flattening (#10237) by @IWANABETHATGUY - rolldown: re-propagate has_dynamic_exports to transitive star importers (#10239) by @IWANABETHATGUY - tree-shaking: tree-shake destructured dynamic import namespace bindings (#10213) by @logaretm - s390x: use json-escape-simd 3.1.1 for big-endian JSON escaping fix (#10211) by @satyamg1620 ### 🚜 Refactor - dev: move full-reload to client side (#10207) by @h-a-n-a - readability follow-ups to the ReplaceWith migration (#10286) by @IWANABETHATGUY - replace take_in-then-write-back with ReplaceWith and by-value moves (#10285) by @Boshen - share the main resolver's cache with the transformer's tsconfig lookups (#10205) by @shulaoda - rolldown: extract the ns star-external __reExport emission rule into LinkingMetadata (#10238) by @IWANABETHATGUY - rolldown: unify link/generate diagnostics into a Diagnostics accumulator (#10234) by @IWANABETHATGUY - sourcemap_filenames: drop dead sourcemap-filename plumbing (#10189) by @IWANABETHATGUY - extract external import symbol merging into a method (#10224) by @IWANABETHATGUY - rolldown: skip CJS namespace merging under strict execution order (#10203) by @hyfdev - resolve the manual tsconfig per file instead of once at startup (#10200) by @shulaoda - rolldown: route interop ESM init emission through a shared init-target view (#10202) by @hyfdev - rolldown: collapse vestigial wrap-kind state and share chunk sort helper (#10201) by @hyfdev ### 📚 Documentation - show plugin kinds in JSDoc and each hook's description (#10218) by @sapphi-red - add an explanation about removing imports from external modules without any messages (#10215) by @sapphi-red ### ⚡ Performance - sourcemap: owned merge in SourceJoiner::join (4005->5 allocs/chunk) (#10250) by @Boshen - avoid redundant sourcemap string copies in collapse and minify paths (#10093) by @Boshen ### 🧪 Testing - code-splitting: establish strict-order review baselines (#10287) by @hyfdev - dev: add hot API test cases (#10181) by @h-a-n-a - code-splitting: normalize strict execution order variants (#10277) by @hyfdev - code-splitting: harden strict execution order coverage (#10252) by @hyfdev - code-splitting: add strict execution order regressions (#10253) by @hyfdev ### ⚙️ Miscellaneous Tasks - deps: update github actions (#10241) by @renovate[bot] - deps: update oxc to 0.140.0 (#10274) by @shulaoda - update Yunfei's GitHub username (#10275) by @hyfdev - deps: update napi (#10260) by @renovate[bot] - deps: update test262 submodule for tests (#10266) by @rolldown-guard[bot] - deps: update dependency vite-plus to v0.2.4 (#10256) by @renovate[bot] - deps: update napi (#10240) by @renovate[bot] - deps: update oxc resolver to v11.24.2 (#10245) by @renovate[bot] - deps: update rust crates (#10244) by @renovate[bot] - disable Renovate updates for idna_adapter (#10248) by @shulaoda - deps: update oxc resolver to v11.24.1 (#10232) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v8.1.1 (#10233) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.27.0 (#10206) by @renovate[bot] - deps: upgrade sugar_path to v3 (#10230) by @hyfdev - add `dist-*` to `.gitignore` in sourcemap-filenames/hash-final-content fixture (#10216) by @sapphi-red - deps: update dependency rust to v1.97.0 (#10209) by @renovate[bot] ### ❤️ New Contributors * @satyamg1620 made their first contribution in [#10211](#10211) Co-authored-by: shulaoda <[email protected]>
Single-reconciliation merge of 52 new main commits (replaying 194 branch commits as a rebase would cascade Cargo.lock/Cargo.toml regen across dozens of steps). All conflicts resolved preserving the drop-tokio ports on top of main's changes: - plugin_vite_import_glob: kept the branch's pre-resolved async glob lookup; re-applied main's #10167 always-insert `ViteImportGlob(is_sub_imports_pattern)` into the branch's relocated resolve in lib.rs so tsconfig-paths glob support survives. - plugin_vite_dynamic_import_vars: branch's block_on-free transform_program + main's relative_path_as_js_specifier normalization. - asset_module / copy_module: dropped both tokio (branch) and the now-unused sugar_path (main cleanup). - rolldown_dev + rolldown_watcher: async_lock::Mutex (branch) + main's HMR delivery protocol (stamp_table/pending_payloads/shipped/seq). Ported main's new tokio::sync::Mutex fields to async_lock; rebuilt generate_hmr_updates as main's protocol body with the branch's async DevCallbackResult callbacks; dropped main-removed has_full_reload_update; awaited the tsconfig full-reload callback. - binding_dev_engine + dev-engine.ts: main's client protocol (registerClient / notifyPayloadDelivered / removeClient, compileEntry -> BindingLazyChunkOutput) wrapped in the branch's lifecycle; dropped invalidate (main deleted it). Adapted rolldown_binding to the re-pinned napi v3.10.5 (56e32d5c): ObjectFinalize now takes `self`; AsyncBlockBuilder needs `<V, F>` for the defaulted Dispose; PromiseRaw::new is safe. Full workspace compiles clean. KNOWN GAP (not pushed): main bumped oxc 0.139.0 -> 0.140.0 (#10274), so the `patch/oxc-0.139.0-no-tokio-rt` patch no longer applies and oxc 0.140.0's *_napi crates re-enable napi/tokio_rt -> tokio reappears in the shipped graph. Needs a `patch/oxc-0.140.0-no-tokio-rt` branch (0.140.0 + PR #24475) before the drop-tokio invariant holds. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01T34fMrYCf2V13Mg8BKmnda

Implements tsconfig paths support for
import.meta.globin a similar way to how subpath imports support is implemented.This PR does not support the case when the
pathshas multiple items in the array. Doing so requires the resolution to happen in therolldown_plugin_vite_import_globplugin because the candidates cannot be returned fromthis.resolve. But that could break plugins that resolves in between these plugins.An alternative approach is to make oxc-resolver possible to resolve globs. But this requires a huge change and I think it's not worth at this point.
implements vitejs/vite#22881
requires oxc-project/oxc-resolver#1282