Conversation
underfin
commented
Apr 30, 2024
|
|
||
| ```js | ||
| import "./c.mjs"; | ||
| import "./b.mjs"; |
Contributor
Author
There was a problem hiding this comment.
Here should be
import "./b.mjs";
import "./c.mjs";
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
approved these changes
Apr 30, 2024
Member
There was a problem hiding this comment.
It's known by me and that's why #122 remains open. I'm still solving it with considering the stability of hash and correctness of execution order rather than only one aspect. Leave it to me. #1002 (comment)
I will record this test in #122.
Member
|
It's interesting that I found esbuild only ensure chunk order is deterministic, the order is calculated by some deterministic keys rather execution order. Rollup calculated the imported chunk order per module rather than follow the global module execution order calculated by Example
Notices:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description