Code smell: `bindingifyAddon` always creates a function and pass it to rust

Maybe we should make an issue to track these two `FIXME` comments.

_Originally posted by @sapphi-red in https://github.com/rolldown/rolldown/pull/7487#discussion_r2619453707_


https://github.com/rolldown/rolldown/blob/27d96accc96eaf8f232296efadf84ce687bbc854/packages/rolldown/src/utils/bindingify-output-options.ts#L63-L66


https://github.com/rolldown/rolldown/blob/27d96accc96eaf8f232296efadf84ce687bbc854/packages/rolldown/src/utils/bindingify-output-options.ts#L98-L106

	banner: bindingifyAddon(banner),
	footer: bindingifyAddon(footer),
	intro: bindingifyAddon(intro),
	outro: bindingifyAddon(outro),

	function bindingifyAddon(
	configAddon: OutputOptions[AddonKeys],
	): BindingOutputOptions[AddonKeys] {
	return async (chunk) => {
	if (typeof configAddon === 'function') {
	return configAddon(transformRenderedChunk(chunk));
	}
	return configAddon \|\| '';
	};

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code smell: `bindingifyAddon` always creates a function and pass it to rust #7514

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Code smell: bindingifyAddon always creates a function and pass it to rust #7514

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Code smell: `bindingifyAddon` always creates a function and pass it to rust #7514