-
Notifications
You must be signed in to change notification settings - Fork 698
Description
Right now, the alias plugin causes a panic if non-string values are passed. Similar to #5817, we could convert them into Strings at runtime.
If that behavior is not desired, we should at least omit a warning.
More info: vitejs/rolldown-vite#406 (comment)
Error message
rolldown-vite v7.1.8 building SSR bundle for production...
thread '<unnamed>' panicked at crates/rolldown_binding/src/utils/normalize_binding_options.rs:472:37:
Should convert to builtin plugin: Alias
StringExpected, Failed to convert JavaScript value `Boolean false ` into rust type `String` on BindingAliasPluginAlias.replacement on BindingAliasPluginConfig.entries
stack backtrace:
0: 0x11f25850c - _napi_register_module_v1
1: 0x11eaef580 - _blake3_compress_in_place_portable
2: 0x11f256fdc - _napi_register_module_v1
3: 0x11f2583cc - _napi_register_module_v1
4: 0x11f256c00 - _napi_register_module_v1
5: 0x11f27b9cc - _napi_register_module_v1
6: 0x11f27b93c - _napi_register_module_v1
7: 0x11f27c9f0 - _napi_register_module_v1
8: 0x11f2e4084 - _napi_register_module_v1
9: 0x11f2e2e18 - _napi_register_module_v1
10: 0x11e813e68 - <unknown>
11: 0x11ea56290 - <unknown>
12: 0x11ea66088 - <unknown>
13: 0x11ea64304 - <unknown>
fatal runtime error: failed to initiate panic, error 5, abortingReactions are currently unavailable