Skip to content

[Bug]: changing a file registered by this.addWatchFile does not trigger HMR #5220

New issue
New issue
Closed
Bug
Closed
[Bug]: changing a file registered by this.addWatchFile does not trigger HMR#5220
Bug
Assignees
hyf0
Labels
p2: significant / minor bugscope: devRelated to dev mode
@sapphi-red

Description

@sapphi-red
sapphi-red
opened on Jul 9, 2025

Reproduction link or steps

See #5219

What is expected?

generateHmrPatch returns a value with fullReload: true

What is actually happening?

generateHmrPatch returns undefined

System Info

https://github.com/rolldown/rolldown/tree/49f5c23d1b73cf0013091735eb3f5e22de83b165

Any additional comments?

I think generateHmrPatch is returning undefined because this part does not check the watched files.

rolldown/crates/rolldown/src/hmr/hmr_manager.rs

Lines 111 to 116 in 49f5c23

for changed_file_path in changed_file_paths {
let changed_file_path = ArcStr::from(changed_file_path);
if let Some(module_idx) = self.module_idx_by_abs_path.get(&changed_file_path) {
changed_modules.insert(*module_idx);
}
}

Watch mode handles this in a completely different way, so I'm not sure how this should be fixed.

rolldown/crates/rolldown/src/bundler.rs

Lines 118 to 123 in 49f5c23

let mode =
if !self.options.experimental.is_incremental_build_enabled() || changed_ids.is_empty() {
ScanMode::Full
} else {
ScanMode::Partial(changed_ids)
};

Metadata

Metadata

Assignees

Labels

p2: significant / minor bugscope: devRelated to dev mode

Type

Bug

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions