fix(rust): correct hooks order of DataUriPlugin

hyf0 · hyf0 · commit cf44664cc916 · 2026-02-22T17:48:50.000+08:00
diff --git a/crates/rolldown/src/utils/apply_inner_plugins.rs b/crates/rolldown/src/utils/apply_inner_plugins.rs
@@ -21,8 +21,10 @@ pub fn apply_inner_plugins(
   options: &NormalizedBundlerOptions,
   user_plugins: &mut Vec<SharedPluginable>,
 ) -> ApplyInnerPluginsReturn {
-  let mut before_user_plugins: Vec<SharedPluginable> =
-    vec![Arc::new(rolldown_plugin_oxc_runtime::OxcRuntimePlugin)];
+  let mut before_user_plugins: Vec<SharedPluginable> = vec![
+    Arc::new(rolldown_plugin_data_uri::DataUriPlugin::default()),
+    Arc::new(rolldown_plugin_oxc_runtime::OxcRuntimePlugin),
+  ];
 
   let mut lazy_compilation_context = None;
 
@@ -47,8 +49,6 @@ pub fn apply_inner_plugins(
     user_plugins.splice(0..0, before_user_plugins);
   }
 
-  user_plugins.push(Arc::new(rolldown_plugin_data_uri::DataUriPlugin::default()));
-
   let copy_module_plugin =
     rolldown_plugin_copy_module::CopyModulePlugin::new(&options.module_types);
   if copy_module_plugin.is_active() {
diff --git a/crates/rolldown_plugin_data_uri/src/lib.rs b/crates/rolldown_plugin_data_uri/src/lib.rs
@@ -4,7 +4,8 @@ use arcstr::ArcStr;
 use rolldown_common::ModuleType;
 use rolldown_plugin::{
   HookLoadArgs, HookLoadOutput, HookLoadReturn, HookResolveIdArgs, HookResolveIdOutput,
-  HookResolveIdReturn, HookUsage, Plugin, PluginContext, SharedLoadPluginContext,
+  HookResolveIdReturn, HookUsage, Plugin, PluginContext, PluginHookMeta, PluginOrder,
+  SharedLoadPluginContext,
 };
 use rolldown_utils::{
   dashmap::FxDashMap,
@@ -27,6 +28,15 @@ impl Plugin for DataUriPlugin {
     Cow::Borrowed("builtin:data-uri")
   }
 
+  fn register_hook_usage(&self) -> HookUsage {
+    HookUsage::ResolveId | HookUsage::Load
+  }
+
+  fn resolve_id_meta(&self) -> Option<PluginHookMeta> {
+    // Users might have other plugins to handle data URLs, we should give them a chance to do so by resolving data URLs as late as possible.
+    Some(PluginHookMeta { order: Some(PluginOrder::PinPost) })
+  }
+
   async fn resolve_id(
     &self,
     _ctx: &PluginContext,
@@ -66,6 +76,11 @@ impl Plugin for DataUriPlugin {
     Ok(None)
   }
 
+  fn load_meta(&self) -> Option<PluginHookMeta> {
+    // If a `data URL` is resolved by this plugin, we want to provide the content directly without letting other plugins or rolldown to handle it.
+    Some(PluginHookMeta { order: Some(PluginOrder::Pre) })
+  }
+
   async fn load(&self, _ctx: SharedLoadPluginContext, args: &HookLoadArgs<'_>) -> HookLoadReturn {
     if is_data_url(args.id) {
       let Some(resolved) = self.resolved_data_uri.get(args.id) else {
@@ -81,8 +96,4 @@ impl Plugin for DataUriPlugin {
       Ok(None)
     }
   }
-
-  fn register_hook_usage(&self) -> HookUsage {
-    HookUsage::ResolveId | HookUsage::Load
-  }
 }
