Merge branch 'main' into 01-29-fix_6036

IWANABETHATGUY · web-flow · commit 994d3f8ff052 · 2026-03-04T16:27:50.000+08:00
diff --git a/crates/rolldown/src/ast_scanner/mod.rs b/crates/rolldown/src/ast_scanner/mod.rs
@@ -523,16 +523,11 @@ impl<'me, 'ast: 'me> AstScanner<'me, 'ast> {
   fn add_local_export(&mut self, export_name: &str, local: SymbolId, span: Span) {
     let symbol_ref: SymbolRef = (self.immutable_ctx.idx, local).into();
 
-    let is_const = self.result.symbol_ref_db.scoping().symbol_flags(local).is_const_variable();
-
     // If there is any write reference to the local variable, it is reassigned.
     let is_reassigned =
       self.result.symbol_ref_db.get_resolved_references(local).any(Reference::is_write);
 
     let ref_flags = symbol_ref.flags_mut(&mut self.result.symbol_ref_db);
-    if is_const {
-      ref_flags.insert(SymbolRefFlags::IsConst);
-    }
     if !is_reassigned {
       ref_flags.insert(SymbolRefFlags::IsNotReassigned);
     }
diff --git a/crates/rolldown/src/utils/chunk/render_chunk_exports.rs b/crates/rolldown/src/utils/chunk/render_chunk_exports.rs
@@ -368,8 +368,7 @@ fn must_keep_live_binding(
 ) -> bool {
   let canonical_ref = symbol_db.canonical_ref_for(export_ref);
 
-  if canonical_ref.is_declared_by_const(symbol_db).unwrap_or(false) {
-    // For unknown case, we consider it as not declared by `const`.
+  if canonical_ref.is_declared_by_const(symbol_db) {
     return false;
   }
 
diff --git a/crates/rolldown_common/src/types/symbol_ref.rs b/crates/rolldown_common/src/types/symbol_ref.rs
@@ -37,11 +37,8 @@ impl SymbolRef {
     db.local_db_mut(self.owner).flags.entry(self.symbol).or_default()
   }
 
-  // `None` means we don't know if it's declared by `const`.
-  pub fn is_declared_by_const(&self, db: &SymbolRefDb) -> Option<bool> {
-    let flags = self.flags(db)?;
-    // Not having this flag means we don't know if it's declared by `const` instead of it's not declared by `const`.
-    flags.contains(SymbolRefFlags::IsConst).then_some(true)
+  pub fn is_declared_by_const(&self, db: &SymbolRefDb) -> bool {
+    db.local_db(self.owner).ast_scopes.scoping().symbol_flags(self.symbol).is_const_variable()
   }
 
   /// `None` means we don't know if it gets reassigned.
diff --git a/crates/rolldown_common/src/types/symbol_ref_db.rs b/crates/rolldown_common/src/types/symbol_ref_db.rs
@@ -26,8 +26,6 @@ bitflags::bitflags! {
   #[derive(Debug, Default, Clone, Copy)]
   pub struct SymbolRefFlags: u8 {
     const IsNotReassigned = 1;
-    /// If this symbol is declared by `const`. Eg. `const a = 1;`
-    const IsConst = 1 << 1;
     const MustStartWithCapitalLetterForJSX = 1 << 2;
     /// If the SymbolRef points to a side-effects-free function
     const SideEffectsFreeFunction = 1 << 3;

Original file line number	Diff line number	Diff line change
`@@ -368,8 +368,7 @@ fn must_keep_live_binding(`
`368`	`368`	`) -> bool {`
`369`	`369`	`let canonical_ref = symbol_db.canonical_ref_for(export_ref);`
`370`	`370`
`371`		`- if canonical_ref.is_declared_by_const(symbol_db).unwrap_or(false) {`
`372`		- // For unknown case, we consider it as not declared by `const`.
	`371`	`+ if canonical_ref.is_declared_by_const(symbol_db) {`
`373`	`372`	`return false;`
`374`	`373`	`}`
`375`	`374`
Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,8 @@ impl SymbolRef {`
`37`	`37`	`db.local_db_mut(self.owner).flags.entry(self.symbol).or_default()`
`38`	`38`	`}`
`39`	`39`
`40`		- // `None` means we don't know if it's declared by `const`.
`41`		`- pub fn is_declared_by_const(&self, db: &SymbolRefDb) -> Option<bool> {`
`42`		`- let flags = self.flags(db)?;`
`43`		- // Not having this flag means we don't know if it's declared by `const` instead of it's not declared by `const`.
`44`		`- flags.contains(SymbolRefFlags::IsConst).then_some(true)`
	`40`	`+ pub fn is_declared_by_const(&self, db: &SymbolRefDb) -> bool {`
	`41`	`+ db.local_db(self.owner).ast_scopes.scoping().symbol_flags(self.symbol).is_const_variable()`
`45`	`42`	`}`
`46`	`43`
`47`	`44`	/// `None` means we don't know if it gets reassigned.