chore: ban expect.assertions in fixture tests (#8387)

sapphi-red · sapphi-red · commit 8ac9b7865f24 · 2026-02-19T15:06:38.000Z
To catch #8383
diff --git a/.oxlintrc.json b/.oxlintrc.json
@@ -1,6 +1,7 @@
 {
   "$schema": "./node_modules/oxlint/configuration_schema.json",
   "plugins": ["import", "jsdoc", "unicorn", "typescript", "oxc"],
+  "jsPlugins": ["./scripts/lint/index.ts"],
   "ignorePatterns": [
     "crates/**",
     "packages/rollup-tests/**",
@@ -68,6 +69,12 @@
           }
         ]
       }
+    },
+    {
+      "files": ["**/packages/rolldown/tests/fixtures/context/default-value/_config.ts"],
+      "rules": {
+        "rolldown-custom/ban-expect-assertions": "error"
+      }
     }
   ]
 }
diff --git a/knip.jsonc b/knip.jsonc
@@ -88,7 +88,7 @@
       "entry": ["**/*.{test,spec}.{js,ts}"],
     },
     "scripts": {
-      "entry": ["misc/**"],
+      "entry": ["misc/**", "lint/index.ts"],
     },
     "packages/test-dev-server/tests/fixtures/*": {
       "entry": ["dev.config.mjs", "src/*.js"], // no @rolldown/test-dev-server plugin
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/scripts/lint/index.ts b/scripts/lint/index.ts
@@ -0,0 +1,32 @@
+import { eslintCompatPlugin, type CreateOnceRule, type VisitorWithHooks } from '@oxlint/plugins';
+
+const banExpectAssertionsRule: CreateOnceRule = {
+  createOnce(context) {
+    return {
+      CallExpression(node) {
+        if (
+          node.callee.type === 'MemberExpression' &&
+          node.callee.object.type === 'Identifier' &&
+          node.callee.object.name === 'expect' &&
+          node.callee.property.type === 'Identifier' &&
+          node.callee.property.name === 'assertions'
+        ) {
+          context.report({
+            message:
+              'Fixture tests run concurrently and `expect.assertions` does not work with global expect. Use `vi.fn()` instead.',
+            node,
+          });
+        }
+      },
+    } as VisitorWithHooks;
+  },
+};
+
+export default eslintCompatPlugin({
+  meta: {
+    name: 'rolldown-custom',
+  },
+  rules: {
+    'ban-expect-assertions': banExpectAssertionsRule,
+  },
+});
diff --git a/scripts/package.json b/scripts/package.json
@@ -26,6 +26,7 @@
   },
   "devDependencies": {
     "@oxc-node/cli": "catalog:",
+    "@oxlint/plugins": "^1.48.0",
     "acorn": "catalog:",
     "astring": "catalog:",
     "diff": "catalog:",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"$schema": "./node_modules/oxlint/configuration_schema.json",`
`3`	`3`	`"plugins": ["import", "jsdoc", "unicorn", "typescript", "oxc"],`
	`4`	`+ "jsPlugins": ["./scripts/lint/index.ts"],`
`4`	`5`	`"ignorePatterns": [`
`5`	`6`	`"crates/**",`
`6`	`7`	`"packages/rollup-tests/**",`
`@@ -68,6 +69,12 @@`
`68`	`69`	`}`
`69`	`70`	`]`
`70`	`71`	`}`
	`72`	`+ },`
	`73`	`+ {`
	`74`	`+ "files": ["**/packages/rolldown/tests/fixtures/context/default-value/_config.ts"],`
	`75`	`+ "rules": {`
	`76`	`+ "rolldown-custom/ban-expect-assertions": "error"`
	`77`	`+ }`
`71`	`78`	`}`
`72`	`79`	`]`
`73`	`80`	`}`